From: Rob Herring <robh@kernel.org>
To: Paul Elder <paul.elder@ideasonboard.com>
Cc: linux-media@vger.kernel.org,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH 3/3] arm64: dts: mediatek: mt8365-pumpkin: Add overlays for thp7312 cameras
Date: Fri, 8 Sep 2023 15:52:22 -0500 [thread overview]
Message-ID: <20230908205222.GA320762-robh@kernel.org> (raw)
In-Reply-To: <20230905233118.183140-4-paul.elder@ideasonboard.com>
On Wed, Sep 06, 2023 at 08:31:18AM +0900, Paul Elder wrote:
> Add overlays for the Pumpkin i350 to support THP7312 cameras.
>
> Signed-off-by: Paul Elder <paul.elder@ideasonboard.com>
> ---
> arch/arm64/boot/dts/mediatek/Makefile | 4 +
> .../mt8365-pumpkin-common-thp7312.dtsi | 23 ++++++
> .../mt8365-pumpkin-csi0-thp7312-imx258.dtso | 73 +++++++++++++++++++
> .../mt8365-pumpkin-csi1-thp7312-imx258.dtso | 73 +++++++++++++++++++
> 4 files changed, 173 insertions(+)
> create mode 100644 arch/arm64/boot/dts/mediatek/mt8365-pumpkin-common-thp7312.dtsi
> create mode 100644 arch/arm64/boot/dts/mediatek/mt8365-pumpkin-csi0-thp7312-imx258.dtso
> create mode 100644 arch/arm64/boot/dts/mediatek/mt8365-pumpkin-csi1-thp7312-imx258.dtso
>
> diff --git a/arch/arm64/boot/dts/mediatek/Makefile b/arch/arm64/boot/dts/mediatek/Makefile
> index 20570bc40de8..ceaf24105001 100644
> --- a/arch/arm64/boot/dts/mediatek/Makefile
> +++ b/arch/arm64/boot/dts/mediatek/Makefile
> @@ -56,4 +56,8 @@ dtb-$(CONFIG_ARCH_MEDIATEK) += mt8365-evk.dtb
> dtb-$(CONFIG_ARCH_MEDIATEK) += mt8365-pumpkin.dtb
> dtb-$(CONFIG_ARCH_MEDIATEK) += mt8516-pumpkin.dtb
>
> +mtk-mt8365-pumpkin-dtbs := mt8365-pumpkin.dtb mt8365-pumpkin-csi0-thp7312-imx258.dtbo
> +mtk-mt8365-pumpkin-dtbs := mt8365-pumpkin.dtb mt8365-pumpkin-csi1-thp7312-imx258.dtbo
> mtk-mt8365-pumpkin-dtbs := mt8365-pumpkin.dtb mt8365-pumpkin-ethernet-usb.dtbo
This has no effect. You are assigning the same variable 3 times. It
needs to be every overlay applied to its base is a *-dtbs variable and
then those are all added to 'dtb-y'. IOW, we don't allow overlays which
can't be applied at build time.
Assuming the overlays aren't mutually exclusive, you could do:
mtk-mt8365-pumpkin-dtbs := mt8365-pumpkin.dtb mt8365-pumpkin-ethernet-usb.dtbo
mtk-mt8365-pumpkin-dtbs += mt8365-pumpkin-csi0-thp7312-imx258.dtbo
mtk-mt8365-pumpkin-dtbs += mt8365-pumpkin-csi1-thp7312-imx258.dtbo
This works the same way as '-objs' variables to group .o files into a
module.
> +
> +dtb-$(CONFIG_ARCH_MEDIATEK) += mtk-mt8365-pumpkin.dtb
Looks like mtk-mt8365-pumpkin.dtb failed to get built before. In any
case, that's a terrible name. What's the difference between
mt8365-pumpkin.dtb and mtk-mt8365-pumpkin.dtb? There's no clue.
Rob
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Paul Elder <paul.elder@ideasonboard.com>
Cc: linux-media@vger.kernel.org,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH 3/3] arm64: dts: mediatek: mt8365-pumpkin: Add overlays for thp7312 cameras
Date: Fri, 8 Sep 2023 15:52:22 -0500 [thread overview]
Message-ID: <20230908205222.GA320762-robh@kernel.org> (raw)
In-Reply-To: <20230905233118.183140-4-paul.elder@ideasonboard.com>
On Wed, Sep 06, 2023 at 08:31:18AM +0900, Paul Elder wrote:
> Add overlays for the Pumpkin i350 to support THP7312 cameras.
>
> Signed-off-by: Paul Elder <paul.elder@ideasonboard.com>
> ---
> arch/arm64/boot/dts/mediatek/Makefile | 4 +
> .../mt8365-pumpkin-common-thp7312.dtsi | 23 ++++++
> .../mt8365-pumpkin-csi0-thp7312-imx258.dtso | 73 +++++++++++++++++++
> .../mt8365-pumpkin-csi1-thp7312-imx258.dtso | 73 +++++++++++++++++++
> 4 files changed, 173 insertions(+)
> create mode 100644 arch/arm64/boot/dts/mediatek/mt8365-pumpkin-common-thp7312.dtsi
> create mode 100644 arch/arm64/boot/dts/mediatek/mt8365-pumpkin-csi0-thp7312-imx258.dtso
> create mode 100644 arch/arm64/boot/dts/mediatek/mt8365-pumpkin-csi1-thp7312-imx258.dtso
>
> diff --git a/arch/arm64/boot/dts/mediatek/Makefile b/arch/arm64/boot/dts/mediatek/Makefile
> index 20570bc40de8..ceaf24105001 100644
> --- a/arch/arm64/boot/dts/mediatek/Makefile
> +++ b/arch/arm64/boot/dts/mediatek/Makefile
> @@ -56,4 +56,8 @@ dtb-$(CONFIG_ARCH_MEDIATEK) += mt8365-evk.dtb
> dtb-$(CONFIG_ARCH_MEDIATEK) += mt8365-pumpkin.dtb
> dtb-$(CONFIG_ARCH_MEDIATEK) += mt8516-pumpkin.dtb
>
> +mtk-mt8365-pumpkin-dtbs := mt8365-pumpkin.dtb mt8365-pumpkin-csi0-thp7312-imx258.dtbo
> +mtk-mt8365-pumpkin-dtbs := mt8365-pumpkin.dtb mt8365-pumpkin-csi1-thp7312-imx258.dtbo
> mtk-mt8365-pumpkin-dtbs := mt8365-pumpkin.dtb mt8365-pumpkin-ethernet-usb.dtbo
This has no effect. You are assigning the same variable 3 times. It
needs to be every overlay applied to its base is a *-dtbs variable and
then those are all added to 'dtb-y'. IOW, we don't allow overlays which
can't be applied at build time.
Assuming the overlays aren't mutually exclusive, you could do:
mtk-mt8365-pumpkin-dtbs := mt8365-pumpkin.dtb mt8365-pumpkin-ethernet-usb.dtbo
mtk-mt8365-pumpkin-dtbs += mt8365-pumpkin-csi0-thp7312-imx258.dtbo
mtk-mt8365-pumpkin-dtbs += mt8365-pumpkin-csi1-thp7312-imx258.dtbo
This works the same way as '-objs' variables to group .o files into a
module.
> +
> +dtb-$(CONFIG_ARCH_MEDIATEK) += mtk-mt8365-pumpkin.dtb
Looks like mtk-mt8365-pumpkin.dtb failed to get built before. In any
case, that's a terrible name. What's the difference between
mt8365-pumpkin.dtb and mtk-mt8365-pumpkin.dtb? There's no clue.
Rob
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-09-08 20:52 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-05 23:31 [PATCH 0/3] media: i2c: Add driver for THine THP7312 ISP Paul Elder
2023-09-05 23:31 ` Paul Elder
2023-09-05 23:31 ` [PATCH 1/3] dt-bindings: media: Add " Paul Elder
2023-09-06 0:10 ` Rob Herring
2023-09-06 7:18 ` Krzysztof Kozlowski
2023-09-06 8:15 ` Laurent Pinchart
2023-09-07 14:49 ` Paul Elder
2023-09-07 14:56 ` Laurent Pinchart
2023-09-07 14:53 ` Paul Elder
2023-09-05 23:31 ` [PATCH 2/3] media: i2c: Add driver for THine THP7312 Paul Elder
2023-09-06 7:25 ` Krzysztof Kozlowski
2023-09-06 9:03 ` Laurent Pinchart
2023-09-06 10:50 ` Dave Stevenson
2023-09-07 14:54 ` Paul Elder
2023-09-06 10:58 ` Laurent Pinchart
2023-09-05 23:31 ` [PATCH 3/3] arm64: dts: mediatek: mt8365-pumpkin: Add overlays for thp7312 cameras Paul Elder
2023-09-05 23:31 ` Paul Elder
2023-09-06 7:27 ` Krzysztof Kozlowski
2023-09-06 7:27 ` Krzysztof Kozlowski
2023-09-06 8:32 ` Laurent Pinchart
2023-09-06 8:32 ` Laurent Pinchart
2023-09-06 8:48 ` Krzysztof Kozlowski
2023-09-06 8:48 ` Krzysztof Kozlowski
2023-09-06 9:00 ` Laurent Pinchart
2023-09-06 9:00 ` Laurent Pinchart
2023-09-06 9:21 ` Krzysztof Kozlowski
2023-09-06 9:21 ` Krzysztof Kozlowski
2023-09-06 9:35 ` Laurent Pinchart
2023-09-06 9:35 ` Laurent Pinchart
2023-09-06 11:01 ` Kieran Bingham
2023-09-06 11:01 ` Kieran Bingham
2023-09-06 11:14 ` Laurent Pinchart
2023-09-06 11:14 ` Laurent Pinchart
2023-09-07 14:55 ` Paul Elder
2023-09-07 14:55 ` Paul Elder
2023-09-07 15:04 ` Laurent Pinchart
2023-09-07 15:04 ` Laurent Pinchart
2023-09-07 15:04 ` Laurent Pinchart
2023-09-07 15:04 ` Laurent Pinchart
2023-09-08 20:52 ` Rob Herring [this message]
2023-09-08 20:52 ` Rob Herring
2023-09-09 15:37 ` Laurent Pinchart
2023-09-09 15:37 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230908205222.GA320762-robh@kernel.org \
--to=robh@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=mchehab@kernel.org \
--cc=paul.elder@ideasonboard.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.