* [PATCH] fs/proc: do_task_stat: use __for_each_thread()
@ 2023-09-09 16:45 Oleg Nesterov
0 siblings, 0 replies; only message in thread
From: Oleg Nesterov @ 2023-09-09 16:45 UTC (permalink / raw)
To: Andrew Morton; +Cc: Eric W. Biederman, linux-kernel
do/while_each_thread should be avoided when possible.
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
---
fs/proc/array.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/fs/proc/array.c b/fs/proc/array.c
index 2c2efbe685d8..ff08a8957552 100644
--- a/fs/proc/array.c
+++ b/fs/proc/array.c
@@ -536,12 +536,13 @@ static int do_task_stat(struct seq_file *m, struct pid_namespace *ns,
/* add up live thread stats at the group level */
if (whole) {
- struct task_struct *t = task;
- do {
+ struct task_struct *t;
+
+ __for_each_thread(sig, t) {
min_flt += t->min_flt;
maj_flt += t->maj_flt;
gtime += task_gtime(t);
- } while_each_thread(task, t);
+ }
min_flt += sig->min_flt;
maj_flt += sig->maj_flt;
--
2.25.1.362.g51ebf55
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2023-09-09 16:46 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-09 16:45 [PATCH] fs/proc: do_task_stat: use __for_each_thread() Oleg Nesterov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.