From: Tony Lindgren <tony@atomide.com>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Janusz Krzysztofik <jmkrzyszt@gmail.com>,
Linus Walleij <linus.walleij@linaro.org>,
Aaro Koskinen <aaro.koskinen@iki.fi>,
Russell King <linux@armlinux.org.uk>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Dipen Patel <dipenp@nvidia.com>,
Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Hans de Goede <hdegoede@redhat.com>,
Mark Gross <markgross@kernel.org>,
linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-acpi@vger.kernel.org, timestamp@lists.linux.dev,
linux-tegra@vger.kernel.org, platform-driver-x86@vger.kernel.org,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Subject: Re: [RFT PATCH 15/21] arm: omap1: ams-delta: stop using gpiochip_find()
Date: Mon, 11 Sep 2023 15:50:46 +0300 [thread overview]
Message-ID: <20230911125046.GA5285@atomide.com> (raw)
In-Reply-To: <CAMRc=Mfrk9q6fJyEAuxDXYPpbjVHeLJaTjHEcKiYHzrE3r+_7A@mail.gmail.com>
* Bartosz Golaszewski <brgl@bgdev.pl> [230911 11:10]:
> On Fri, Sep 8, 2023 at 8:07 PM Janusz Krzysztofik <jmkrzyszt@gmail.com> wrote:
> >
> > Dnia czwartek, 7 września 2023 09:31:01 CEST Linus Walleij pisze:
> > > On Tue, Sep 5, 2023 at 8:53 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
> > >
> > > > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> > > >
> > > > gpiochip_find() is going away as it's not hot-unplug safe. This platform
> > > > is not affected by any of the related problems as this GPIO controller
> > > > cannot really go away but in order to finally remove this function, we
> > > > need to convert it to using gpio_device_find() as well.
> > > >
> > > > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> > >
> > > I was cleaning this one just some merge cycle ago, now it
> > > looks even better!
> > > Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> >
> > Acked-by: Janusz Krzysztofik <jmkrzyszt@gmail.com>
> >
>
> Janusz,
>
> Is it fine if I take it through the GPIO tree?
Works for me at least:
Acked-by: Tony Lindgren <tony@atomide.com>
WARNING: multiple messages have this Message-ID (diff)
From: Tony Lindgren <tony@atomide.com>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Janusz Krzysztofik <jmkrzyszt@gmail.com>,
Linus Walleij <linus.walleij@linaro.org>,
Aaro Koskinen <aaro.koskinen@iki.fi>,
Russell King <linux@armlinux.org.uk>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Dipen Patel <dipenp@nvidia.com>,
Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Hans de Goede <hdegoede@redhat.com>,
Mark Gross <markgross@kernel.org>,
linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-acpi@vger.kernel.org, timestamp@lists.linux.dev,
linux-tegra@vger.kernel.org, platform-driver-x86@vger.kernel.org,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Subject: Re: [RFT PATCH 15/21] arm: omap1: ams-delta: stop using gpiochip_find()
Date: Mon, 11 Sep 2023 15:50:46 +0300 [thread overview]
Message-ID: <20230911125046.GA5285@atomide.com> (raw)
In-Reply-To: <CAMRc=Mfrk9q6fJyEAuxDXYPpbjVHeLJaTjHEcKiYHzrE3r+_7A@mail.gmail.com>
* Bartosz Golaszewski <brgl@bgdev.pl> [230911 11:10]:
> On Fri, Sep 8, 2023 at 8:07 PM Janusz Krzysztofik <jmkrzyszt@gmail.com> wrote:
> >
> > Dnia czwartek, 7 września 2023 09:31:01 CEST Linus Walleij pisze:
> > > On Tue, Sep 5, 2023 at 8:53 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
> > >
> > > > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> > > >
> > > > gpiochip_find() is going away as it's not hot-unplug safe. This platform
> > > > is not affected by any of the related problems as this GPIO controller
> > > > cannot really go away but in order to finally remove this function, we
> > > > need to convert it to using gpio_device_find() as well.
> > > >
> > > > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> > >
> > > I was cleaning this one just some merge cycle ago, now it
> > > looks even better!
> > > Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> >
> > Acked-by: Janusz Krzysztofik <jmkrzyszt@gmail.com>
> >
>
> Janusz,
>
> Is it fine if I take it through the GPIO tree?
Works for me at least:
Acked-by: Tony Lindgren <tony@atomide.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-09-11 21:27 UTC|newest]
Thread overview: 174+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-05 18:52 [PATCH 00/21] gpio: convert users to gpio_device_find() and remove gpiochip_find() Bartosz Golaszewski
2023-09-05 18:52 ` Bartosz Golaszewski
2023-09-05 18:52 ` [PATCH 01/21] gpiolib: make gpio_device_get() and gpio_device_put() public Bartosz Golaszewski
2023-09-05 18:52 ` Bartosz Golaszewski
2023-09-07 7:02 ` Linus Walleij
2023-09-07 7:02 ` Linus Walleij
2023-09-05 18:52 ` [PATCH 02/21] gpiolib: provide gpio_device_find() Bartosz Golaszewski
2023-09-05 18:52 ` Bartosz Golaszewski
2023-09-06 14:10 ` Andy Shevchenko
2023-09-06 14:10 ` Andy Shevchenko
2023-09-11 13:14 ` Bartosz Golaszewski
2023-09-11 13:14 ` Bartosz Golaszewski
2023-09-07 7:05 ` Linus Walleij
2023-09-07 7:05 ` Linus Walleij
2023-09-05 18:52 ` [PATCH 03/21] gpiolib: provide gpio_device_find_by_label() Bartosz Golaszewski
2023-09-05 18:52 ` Bartosz Golaszewski
2023-09-06 14:13 ` Andy Shevchenko
2023-09-06 14:13 ` Andy Shevchenko
2023-09-07 7:06 ` Linus Walleij
2023-09-07 7:06 ` Linus Walleij
2023-09-05 18:52 ` [PATCH 04/21] gpiolib: provide gpio_device_get_desc() Bartosz Golaszewski
2023-09-05 18:52 ` Bartosz Golaszewski
2023-09-06 14:15 ` Andy Shevchenko
2023-09-06 14:15 ` Andy Shevchenko
2023-09-07 7:07 ` Linus Walleij
2023-09-07 7:07 ` Linus Walleij
2023-09-05 18:52 ` [PATCH 05/21] gpiolib: add support for scope-based management to gpio_device Bartosz Golaszewski
2023-09-05 18:52 ` Bartosz Golaszewski
2023-09-07 7:09 ` Linus Walleij
2023-09-07 7:09 ` Linus Walleij
2023-09-05 18:52 ` [PATCH 06/21] gpiolib: provide gpiod_to_device() Bartosz Golaszewski
2023-09-05 18:52 ` Bartosz Golaszewski
2023-09-06 14:17 ` Andy Shevchenko
2023-09-06 14:17 ` Andy Shevchenko
2023-09-07 7:10 ` Linus Walleij
2023-09-07 7:10 ` Linus Walleij
2023-09-05 18:52 ` [PATCH 07/21] gpiolib: provide gpio_device_get_base() Bartosz Golaszewski
2023-09-05 18:52 ` Bartosz Golaszewski
2023-09-07 7:17 ` Linus Walleij
2023-09-07 7:17 ` Linus Walleij
2023-09-07 7:57 ` Bartosz Golaszewski
2023-09-07 7:57 ` Bartosz Golaszewski
2023-10-03 20:32 ` Dipen Patel
2023-10-03 20:32 ` Dipen Patel
2023-09-05 18:52 ` [PATCH 08/21] gpio: acpi: provide acpi_gpio_device_free_interrupts() Bartosz Golaszewski
2023-09-05 18:52 ` Bartosz Golaszewski
2023-09-06 7:10 ` Mika Westerberg
2023-09-06 7:10 ` Mika Westerberg
2023-09-05 18:52 ` [PATCH 09/21] gpiolib: reluctantly provide gpio_device_get_chip() Bartosz Golaszewski
2023-09-05 18:52 ` Bartosz Golaszewski
2023-09-07 7:19 ` Linus Walleij
2023-09-07 7:19 ` Linus Walleij
2023-09-05 18:52 ` [PATCH 10/21] gpiolib: replace find_chip_by_name() with gpio_device_find_by_label() Bartosz Golaszewski
2023-09-05 18:52 ` Bartosz Golaszewski
2023-09-06 14:23 ` Andy Shevchenko
2023-09-06 14:23 ` Andy Shevchenko
2023-09-07 7:20 ` Linus Walleij
2023-09-07 7:20 ` Linus Walleij
2023-09-05 18:52 ` [RFT PATCH 11/21] platform: x86: android-tablets: don't access GPIOLIB private members Bartosz Golaszewski
2023-09-05 18:52 ` Bartosz Golaszewski
2023-09-06 13:01 ` Hans de Goede
2023-09-06 13:01 ` Hans de Goede
2023-09-06 14:27 ` Bartosz Golaszewski
2023-09-06 14:27 ` Bartosz Golaszewski
2023-09-09 14:17 ` Hans de Goede
2023-09-09 14:17 ` Hans de Goede
2023-09-11 10:05 ` Andy Shevchenko
2023-09-11 10:05 ` Andy Shevchenko
2023-09-05 18:53 ` [PATCH 12/21] hte: allow building modules with COMPILE_TEST enabled Bartosz Golaszewski
2023-09-05 18:53 ` Bartosz Golaszewski
2023-09-07 7:22 ` Linus Walleij
2023-09-07 7:22 ` Linus Walleij
2023-09-07 7:31 ` Bartosz Golaszewski
2023-09-07 7:31 ` Bartosz Golaszewski
2023-09-05 18:53 ` [PATCH 13/21] hte: tegra194: improve the GPIO-related comment Bartosz Golaszewski
2023-09-05 18:53 ` Bartosz Golaszewski
2023-09-07 7:24 ` Linus Walleij
2023-09-07 7:24 ` Linus Walleij
2023-09-05 18:53 ` [RFT PATCH 14/21] hte: tegra194: don't access struct gpio_chip Bartosz Golaszewski
2023-09-05 18:53 ` Bartosz Golaszewski
2023-09-06 14:47 ` Andy Shevchenko
2023-09-06 14:47 ` Andy Shevchenko
2023-09-07 7:28 ` Linus Walleij
2023-09-07 7:28 ` Linus Walleij
2023-10-04 12:00 ` Bartosz Golaszewski
2023-10-04 12:00 ` Bartosz Golaszewski
2023-10-04 20:30 ` Dipen Patel
2023-10-04 20:30 ` Dipen Patel
2023-10-04 20:33 ` Dipen Patel
2023-10-04 20:33 ` Dipen Patel
2023-10-04 22:54 ` Dipen Patel
2023-10-04 22:54 ` Dipen Patel
2023-10-04 23:51 ` Dipen Patel
2023-10-04 23:51 ` Dipen Patel
2023-10-05 13:48 ` Bartosz Golaszewski
2023-10-05 13:48 ` Bartosz Golaszewski
2023-10-05 18:12 ` Dipen Patel
2023-10-05 18:12 ` Dipen Patel
2023-10-05 19:05 ` Bartosz Golaszewski
2023-10-05 19:05 ` Bartosz Golaszewski
2023-10-05 19:43 ` Dipen Patel
2023-10-05 19:43 ` Dipen Patel
2023-10-05 19:47 ` Bartosz Golaszewski
2023-10-05 19:47 ` Bartosz Golaszewski
2023-10-09 6:48 ` Bartosz Golaszewski
2023-10-09 6:48 ` Bartosz Golaszewski
2023-10-09 16:34 ` Dipen Patel
2023-10-09 16:34 ` Dipen Patel
2023-10-09 17:46 ` Dipen Patel
2023-10-09 17:46 ` Dipen Patel
2023-09-05 18:53 ` [RFT PATCH 15/21] arm: omap1: ams-delta: stop using gpiochip_find() Bartosz Golaszewski
2023-09-05 18:53 ` Bartosz Golaszewski
2023-09-06 14:48 ` Andy Shevchenko
2023-09-06 14:48 ` Andy Shevchenko
2023-09-06 14:56 ` Bartosz Golaszewski
2023-09-06 14:56 ` Bartosz Golaszewski
2023-09-07 7:31 ` Linus Walleij
2023-09-07 7:31 ` Linus Walleij
2023-09-08 18:07 ` Janusz Krzysztofik
2023-09-08 18:07 ` Janusz Krzysztofik
2023-09-11 11:09 ` Bartosz Golaszewski
2023-09-11 11:09 ` Bartosz Golaszewski
2023-09-11 12:50 ` Tony Lindgren [this message]
2023-09-11 12:50 ` Tony Lindgren
2023-09-11 17:17 ` Janusz Krzysztofik
2023-09-11 17:17 ` Janusz Krzysztofik
2023-09-07 7:35 ` Linus Walleij
2023-09-07 7:35 ` Linus Walleij
2023-09-07 7:57 ` Bartosz Golaszewski
2023-09-07 7:57 ` Bartosz Golaszewski
2023-10-04 11:59 ` Bartosz Golaszewski
2023-10-04 11:59 ` Bartosz Golaszewski
2023-09-05 18:53 ` [PATCH 16/21] gpio: of: correct notifier return codes Bartosz Golaszewski
2023-09-05 18:53 ` Bartosz Golaszewski
2023-09-07 7:36 ` Linus Walleij
2023-09-07 7:36 ` Linus Walleij
2023-09-05 18:53 ` [PATCH 17/21] gpio: of: replace gpiochip_find_* with gpio_device_find_* Bartosz Golaszewski
2023-09-05 18:53 ` Bartosz Golaszewski
2023-09-07 7:37 ` Linus Walleij
2023-09-07 7:37 ` Linus Walleij
2023-09-07 7:38 ` Linus Walleij
2023-09-07 7:38 ` Linus Walleij
2023-09-05 18:53 ` [PATCH 18/21] gpio: acpi: replace gpiochip_find() with gpio_device_find() Bartosz Golaszewski
2023-09-05 18:53 ` Bartosz Golaszewski
2023-09-06 14:50 ` Andy Shevchenko
2023-09-06 14:50 ` Andy Shevchenko
2023-09-07 7:39 ` Linus Walleij
2023-09-07 7:39 ` Linus Walleij
2023-09-05 18:53 ` [PATCH 19/21] gpio: swnode: replace gpiochip_find() with gpio_device_find_by_label() Bartosz Golaszewski
2023-09-05 18:53 ` Bartosz Golaszewski
2023-09-06 14:52 ` Andy Shevchenko
2023-09-06 14:52 ` Andy Shevchenko
2023-09-07 7:40 ` Linus Walleij
2023-09-07 7:40 ` Linus Walleij
2024-01-24 14:59 ` Paul Cercueil
2024-01-24 14:59 ` Paul Cercueil
2024-01-24 15:04 ` Bartosz Golaszewski
2024-01-24 15:04 ` Bartosz Golaszewski
2024-01-24 15:11 ` Paul Cercueil
2024-01-24 15:11 ` Paul Cercueil
2024-01-24 15:18 ` Paul Cercueil
2024-01-24 15:18 ` Paul Cercueil
2023-09-05 18:53 ` [PATCH 20/21] gpio: sysfs: drop the mention of gpiochip_find() from sysfs code Bartosz Golaszewski
2023-09-05 18:53 ` Bartosz Golaszewski
2023-09-07 7:40 ` Linus Walleij
2023-09-07 7:40 ` Linus Walleij
2023-09-05 18:53 ` [PATCH 21/21] gpiolib: remove gpiochip_find() Bartosz Golaszewski
2023-09-05 18:53 ` Bartosz Golaszewski
2023-09-06 14:53 ` Andy Shevchenko
2023-09-06 14:53 ` Andy Shevchenko
2023-09-07 7:42 ` Linus Walleij
2023-09-07 7:42 ` Linus Walleij
2023-09-07 7:00 ` [PATCH 00/21] gpio: convert users to gpio_device_find() and " Linus Walleij
2023-09-07 7:00 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230911125046.GA5285@atomide.com \
--to=tony@atomide.com \
--cc=aaro.koskinen@iki.fi \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bartosz.golaszewski@linaro.org \
--cc=brgl@bgdev.pl \
--cc=dipenp@nvidia.com \
--cc=hdegoede@redhat.com \
--cc=jmkrzyszt@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=linus.walleij@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=markgross@kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=thierry.reding@gmail.com \
--cc=timestamp@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.