All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: Waiman Long <longman@redhat.com>,
	Matthew Wilcox <willy@infradead.org>,
	Ingo Molnar <mingo@redhat.com>, Will Deacon <will@kernel.org>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	Chandan Babu R <chandan.babu@oracle.com>,
	"Darrick J . Wong" <djwong@kernel.org>,
	linux-xfs@vger.kernel.org
Subject: Re: [PATCH 1/5] locking: Add rwsem_is_write_locked()
Date: Tue, 12 Sep 2023 11:03:42 +0200	[thread overview]
Message-ID: <20230912090342.GC35261@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <ZP+U49yfkm0Fpfej@dread.disaster.area>

On Tue, Sep 12, 2023 at 08:29:55AM +1000, Dave Chinner wrote:

> So, once again, we have mixed messages from the lock maintainers.
> One says "no, it might get abused", another says "I'm fine with
> that", and now we have a maintainer disagreement stalemate.

I didn't say no, I was trying to see if there's alternatives because the
is_locked pattern has a history of abuse.

If not, then sure we can do this; it's not like I managed to get rid of
muteX_is_locked() -- and I actually tried at some point :/

And just now I grepped for it, and look what I find:

drivers/hid/hid-nintendo.c:     if (unlikely(mutex_is_locked(&ctlr->output_mutex))) {
drivers/nvdimm/btt.c:           if (mutex_is_locked(&arena->err_lock)

And there's more :-(

Also, please just calm down already..

  reply	other threads:[~2023-09-12  9:06 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-07 17:47 [PATCH 0/5] Remove the XFS mrlock Matthew Wilcox (Oracle)
2023-09-07 17:47 ` [PATCH 1/5] locking: Add rwsem_is_write_locked() Matthew Wilcox (Oracle)
2023-09-07 18:05   ` Waiman Long
2023-09-07 19:33     ` Matthew Wilcox
2023-09-07 21:06       ` Waiman Long
2023-09-07 23:47         ` Waiman Long
2023-09-08  0:44           ` Dave Chinner
2023-09-07 19:08   ` Peter Zijlstra
2023-09-07 19:20     ` Matthew Wilcox
2023-09-07 19:38       ` Peter Zijlstra
2023-09-07 23:00         ` Dave Chinner
2023-09-08 10:44           ` Peter Zijlstra
2023-09-10 22:56             ` Dave Chinner
2023-09-10 23:17               ` Matthew Wilcox
2023-09-11  0:55                 ` Dave Chinner
2023-09-11  2:15                   ` Waiman Long
2023-09-11 22:29                     ` Dave Chinner
2023-09-12  9:03                       ` Peter Zijlstra [this message]
2023-09-12 12:28                         ` Matthew Wilcox
2023-09-12 13:52                           ` Peter Zijlstra
2023-09-12 13:58                             ` Matthew Wilcox
2023-09-12 14:23                               ` Peter Zijlstra
2023-09-12 15:27                                 ` Darrick J. Wong
2023-09-13  8:59                                   ` Peter Zijlstra
2023-09-12 14:02                             ` Peter Zijlstra
2023-09-12 23:16                         ` Dave Chinner
2023-09-08  0:01         ` Matthew Wilcox
2023-09-07 17:47 ` [PATCH 2/5] mm: Use rwsem_is_write_locked in mmap_assert_write_locked Matthew Wilcox (Oracle)
2023-09-07 17:47 ` [PATCH 3/5] xfs: Use rwsem_is_write_locked() Matthew Wilcox (Oracle)
2023-09-08  9:09   ` Christoph Hellwig
2023-09-08  9:10     ` Christoph Hellwig
2023-09-07 17:47 ` [PATCH 4/5] xfs: Remove mrlock wrapper Matthew Wilcox (Oracle)
2023-09-07 17:47 ` [PATCH 5/5] xfs: Stop using lockdep to assert that locks are held Matthew Wilcox (Oracle)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230912090342.GC35261@noisy.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=chandan.babu@oracle.com \
    --cc=david@fromorbit.com \
    --cc=djwong@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=longman@redhat.com \
    --cc=mingo@redhat.com \
    --cc=will@kernel.org \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.