All of lore.kernel.org
 help / color / mirror / Atom feed
From: Manivannan Sadhasivam <mani@kernel.org>
To: Bibek Kumar Patro <quic_bibekkum@quicinc.com>
Cc: Miquel Raynal <miquel.raynal@bootlin.com>,
	richard@nod.at, vigneshr@ti.com, linux-mtd@lists.infradead.org,
	linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
	kernel@quicinc.com, quic_charante@quicinc.com,
	quic_kaushalk@quicinc.com, quic_pkondeti@quicinc.com
Subject: Re: [PATCH v4] mtd: rawnand: qcom: Unmap the right resource upon probe failure
Date: Tue, 12 Sep 2023 20:07:26 +0530	[thread overview]
Message-ID: <20230912143726.GE6404@thinkpad> (raw)
In-Reply-To: <5e80e600-b523-476a-81bd-93d2c517b7b6@quicinc.com>

On Tue, Sep 12, 2023 at 08:02:07PM +0530, Bibek Kumar Patro wrote:
> 
> 
> On 9/12/2023 5:58 PM, Miquel Raynal wrote:
> > > We currently provide the physical address of the DMA region
> > > rather than the output of dma_map_resource() which is obviously wrong.
> > > 
> > > Fixes: 7330fc505af4 ("mtd: rawnand: qcom: stop using phys_to_dma()")
> > Cc: stable?
> Cc: stable@vger.kernel.org

You need to send another version adding the CC tag.

With the tag added,

Reviewed-by: Manivannan Sadhasivam <mani@kernel.org>

- Mani

-- 
மணிவண்ணன் சதாசிவம்

WARNING: multiple messages have this Message-ID (diff)
From: Manivannan Sadhasivam <mani@kernel.org>
To: Bibek Kumar Patro <quic_bibekkum@quicinc.com>
Cc: Miquel Raynal <miquel.raynal@bootlin.com>,
	richard@nod.at, vigneshr@ti.com, linux-mtd@lists.infradead.org,
	linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
	kernel@quicinc.com, quic_charante@quicinc.com,
	quic_kaushalk@quicinc.com, quic_pkondeti@quicinc.com
Subject: Re: [PATCH v4] mtd: rawnand: qcom: Unmap the right resource upon probe failure
Date: Tue, 12 Sep 2023 20:07:26 +0530	[thread overview]
Message-ID: <20230912143726.GE6404@thinkpad> (raw)
In-Reply-To: <5e80e600-b523-476a-81bd-93d2c517b7b6@quicinc.com>

On Tue, Sep 12, 2023 at 08:02:07PM +0530, Bibek Kumar Patro wrote:
> 
> 
> On 9/12/2023 5:58 PM, Miquel Raynal wrote:
> > > We currently provide the physical address of the DMA region
> > > rather than the output of dma_map_resource() which is obviously wrong.
> > > 
> > > Fixes: 7330fc505af4 ("mtd: rawnand: qcom: stop using phys_to_dma()")
> > Cc: stable?
> Cc: stable@vger.kernel.org

You need to send another version adding the CC tag.

With the tag added,

Reviewed-by: Manivannan Sadhasivam <mani@kernel.org>

- Mani

-- 
மணிவண்ணன் சதாசிவம்

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

  reply	other threads:[~2023-09-12 14:37 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-12 11:59 [PATCH v4] mtd: rawnand: qcom: Unmap the right resource upon probe failure Bibek Kumar Patro
2023-09-12 11:59 ` Bibek Kumar Patro
2023-09-12 12:28 ` Miquel Raynal
2023-09-12 12:28   ` Miquel Raynal
2023-09-12 14:32   ` Bibek Kumar Patro
2023-09-12 14:32     ` Bibek Kumar Patro
2023-09-12 14:37     ` Manivannan Sadhasivam [this message]
2023-09-12 14:37       ` Manivannan Sadhasivam
2023-09-13  7:08       ` Bibek Kumar Patro
2023-09-13  7:08         ` Bibek Kumar Patro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230912143726.GE6404@thinkpad \
    --to=mani@kernel.org \
    --cc=kernel@quicinc.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=miquel.raynal@bootlin.com \
    --cc=quic_bibekkum@quicinc.com \
    --cc=quic_charante@quicinc.com \
    --cc=quic_kaushalk@quicinc.com \
    --cc=quic_pkondeti@quicinc.com \
    --cc=richard@nod.at \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.