From: Rob Herring <robh@kernel.org>
To: Herve Codina <herve.codina@bootlin.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Andrew Lunn <andrew@lunn.ch>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>, Lee Jones <lee@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Qiang Zhao <qiang.zhao@nxp.com>, Li Yang <leoyang.li@nxp.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
Shengjiu Wang <shengjiu.wang@gmail.com>,
Xiubo Li <Xiubo.Lee@gmail.com>,
Fabio Estevam <festevam@gmail.com>,
Nicolin Chen <nicoleotsuka@gmail.com>,
Christophe Leroy <christophe.leroy@csgroup.eu>,
Randy Dunlap <rdunlap@infradead.org>,
netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
alsa-devel@alsa-project.org, Simon Horman <hor ms@kernel.org>,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [PATCH v5 06/31] dt-bindings: soc: fsl: cpm_qe: cpm1-scc-qmc: Fix example property name
Date: Tue, 12 Sep 2023 12:58:32 -0500 [thread overview]
Message-ID: <20230912175832.GA995540-robh@kernel.org> (raw)
In-Reply-To: <20230912081527.208499-7-herve.codina@bootlin.com>
On Tue, Sep 12, 2023 at 10:14:57AM +0200, Herve Codina wrote:
> The given example mentions the 'fsl,mode' property whereas the
> correct property name, the one described, is 'fsl,operational-mode'.
>
> Fix the example to use the correct property name.
>
> Fixes: a9b121327c93 ("dt-bindings: soc: fsl: cpm_qe: Add QMC controller")
> Signed-off-by: Herve Codina <herve.codina@bootlin.com>
> ---
> .../bindings/soc/fsl/cpm_qe/fsl,cpm1-scc-qmc.yaml | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
I have this same fix in my tree, but you missed something. Please add
additionalProperties or unevaluatedProperties to the child node schema
so that this error is flagged.
>
> diff --git a/Documentation/devicetree/bindings/soc/fsl/cpm_qe/fsl,cpm1-scc-qmc.yaml b/Documentation/devicetree/bindings/soc/fsl/cpm_qe/fsl,cpm1-scc-qmc.yaml
> index ec888f48cac8..450a0354cb1d 100644
> --- a/Documentation/devicetree/bindings/soc/fsl/cpm_qe/fsl,cpm1-scc-qmc.yaml
> +++ b/Documentation/devicetree/bindings/soc/fsl/cpm_qe/fsl,cpm1-scc-qmc.yaml
> @@ -137,7 +137,7 @@ examples:
> channel@16 {
> /* Ch16 : First 4 even TS from all routed from TSA */
> reg = <16>;
> - fsl,mode = "transparent";
> + fsl,operational-mode = "transparent";
> fsl,reverse-data;
> fsl,tx-ts-mask = <0x00000000 0x000000aa>;
> fsl,rx-ts-mask = <0x00000000 0x000000aa>;
> @@ -146,7 +146,7 @@ examples:
> channel@17 {
> /* Ch17 : First 4 odd TS from all routed from TSA */
> reg = <17>;
> - fsl,mode = "transparent";
> + fsl,operational-mode = "transparent";
> fsl,reverse-data;
> fsl,tx-ts-mask = <0x00000000 0x00000055>;
> fsl,rx-ts-mask = <0x00000000 0x00000055>;
> @@ -155,7 +155,7 @@ examples:
> channel@19 {
> /* Ch19 : 8 TS (TS 8..15) from all routed from TSA */
> reg = <19>;
> - fsl,mode = "hdlc";
> + fsl,operational-mode = "hdlc";
> fsl,tx-ts-mask = <0x00000000 0x0000ff00>;
> fsl,rx-ts-mask = <0x00000000 0x0000ff00>;
> };
> --
> 2.41.0
>
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Herve Codina <herve.codina@bootlin.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
alsa-devel@alsa-project.org,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Xiubo Li <Xiubo.Lee@gmail.com>,
Linus Walleij <linus.walleij@linaro.org>,
Jaroslav Kysela <perex@perex.cz>,
Eric Dumazet <edumazet@google.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Fabio Estevam <festevam@gmail.com>,
Qiang Zhao <qiang.zhao@nxp.com>,
Shengjiu Wang <shengjiu.wang@gmail.com>,
Lee Jones <lee@kernel.org>, Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>,
devicetree@vger.kernel.org, Conor Dooley <conor+dt@kernel.org>,
linux-kernel@vger.kernel.org,
Nicolin Chen <nicoleotsuka@gmail.com>,
linux-gpio@vger.kernel.org, Mark Brown <broonie@kernel.org>,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
Takashi Iwai <tiwai@suse.com>,
linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org,
Randy Dunlap <rdunlap@infradead.org>,
Liam Girdwood <lgirdwood@gmail.com>, Li Yang <leoyang.li@nxp.com>,
Simon Horman <horms@kernel.org>,
lin uxppc-dev@lists.ozlabs.org,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH v5 06/31] dt-bindings: soc: fsl: cpm_qe: cpm1-scc-qmc: Fix example property name
Date: Tue, 12 Sep 2023 12:58:32 -0500 [thread overview]
Message-ID: <20230912175832.GA995540-robh@kernel.org> (raw)
In-Reply-To: <20230912081527.208499-7-herve.codina@bootlin.com>
On Tue, Sep 12, 2023 at 10:14:57AM +0200, Herve Codina wrote:
> The given example mentions the 'fsl,mode' property whereas the
> correct property name, the one described, is 'fsl,operational-mode'.
>
> Fix the example to use the correct property name.
>
> Fixes: a9b121327c93 ("dt-bindings: soc: fsl: cpm_qe: Add QMC controller")
> Signed-off-by: Herve Codina <herve.codina@bootlin.com>
> ---
> .../bindings/soc/fsl/cpm_qe/fsl,cpm1-scc-qmc.yaml | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
I have this same fix in my tree, but you missed something. Please add
additionalProperties or unevaluatedProperties to the child node schema
so that this error is flagged.
>
> diff --git a/Documentation/devicetree/bindings/soc/fsl/cpm_qe/fsl,cpm1-scc-qmc.yaml b/Documentation/devicetree/bindings/soc/fsl/cpm_qe/fsl,cpm1-scc-qmc.yaml
> index ec888f48cac8..450a0354cb1d 100644
> --- a/Documentation/devicetree/bindings/soc/fsl/cpm_qe/fsl,cpm1-scc-qmc.yaml
> +++ b/Documentation/devicetree/bindings/soc/fsl/cpm_qe/fsl,cpm1-scc-qmc.yaml
> @@ -137,7 +137,7 @@ examples:
> channel@16 {
> /* Ch16 : First 4 even TS from all routed from TSA */
> reg = <16>;
> - fsl,mode = "transparent";
> + fsl,operational-mode = "transparent";
> fsl,reverse-data;
> fsl,tx-ts-mask = <0x00000000 0x000000aa>;
> fsl,rx-ts-mask = <0x00000000 0x000000aa>;
> @@ -146,7 +146,7 @@ examples:
> channel@17 {
> /* Ch17 : First 4 odd TS from all routed from TSA */
> reg = <17>;
> - fsl,mode = "transparent";
> + fsl,operational-mode = "transparent";
> fsl,reverse-data;
> fsl,tx-ts-mask = <0x00000000 0x00000055>;
> fsl,rx-ts-mask = <0x00000000 0x00000055>;
> @@ -155,7 +155,7 @@ examples:
> channel@19 {
> /* Ch19 : 8 TS (TS 8..15) from all routed from TSA */
> reg = <19>;
> - fsl,mode = "hdlc";
> + fsl,operational-mode = "hdlc";
> fsl,tx-ts-mask = <0x00000000 0x0000ff00>;
> fsl,rx-ts-mask = <0x00000000 0x0000ff00>;
> };
> --
> 2.41.0
>
next prev parent reply other threads:[~2023-09-12 18:00 UTC|newest]
Thread overview: 173+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-12 8:14 [PATCH v5 00/31] Add support for QMC HDLC, framer infrastructure and PEF2256 framer Herve Codina
2023-09-12 8:14 ` Herve Codina
2023-09-12 8:14 ` Herve Codina
2023-09-12 8:14 ` Herve Codina
2023-09-12 8:14 ` [PATCH v5 01/31] soc: fsl: cpm1: tsa: Fix __iomem addresses declaration Herve Codina
2023-09-12 8:14 ` Herve Codina
2023-09-12 8:14 ` Herve Codina
2023-09-12 8:14 ` [PATCH v5 02/31] soc: fsl: cpm1: qmc: " Herve Codina
2023-09-12 8:14 ` Herve Codina
2023-09-12 8:14 ` Herve Codina
2023-09-12 8:14 ` [PATCH v5 03/31] soc: fsl: cpm1: qmc: Fix rx channel reset Herve Codina
2023-09-12 8:14 ` Herve Codina
2023-09-12 8:14 ` Herve Codina
2023-09-12 8:14 ` [PATCH v5 04/31] soc: fsl: cpm1: qmc: Extend the API to provide Rx status Herve Codina
2023-09-12 8:14 ` Herve Codina
2023-09-12 8:14 ` Herve Codina
2023-09-12 8:14 ` [PATCH v5 05/31] soc: fsl: cpm1: qmc: Remove inline function specifiers Herve Codina
2023-09-12 8:14 ` Herve Codina
2023-09-12 8:14 ` Herve Codina
2023-09-12 8:14 ` [PATCH v5 06/31] dt-bindings: soc: fsl: cpm_qe: cpm1-scc-qmc: Fix example property name Herve Codina
2023-09-12 8:14 ` Herve Codina
2023-09-12 8:14 ` Herve Codina
2023-09-12 16:36 ` Conor Dooley
2023-09-12 16:36 ` Conor Dooley
2023-09-12 16:36 ` Conor Dooley
2023-09-12 17:58 ` Rob Herring [this message]
2023-09-12 17:58 ` Rob Herring
2023-09-12 18:16 ` Rob Herring
2023-09-12 18:16 ` Rob Herring
2023-09-12 8:14 ` [PATCH v5 07/31] dt-bindings: soc: fsl: cpm_qe: cpm1-scc-qmc: Add 'additionalProperties: false' in child nodes Herve Codina
2023-09-12 8:14 ` Herve Codina
2023-09-12 8:14 ` Herve Codina
2023-09-12 16:37 ` Conor Dooley
2023-09-12 16:37 ` Conor Dooley
2023-09-12 16:37 ` Conor Dooley
2023-09-12 18:23 ` Rob Herring
2023-09-12 18:23 ` Rob Herring
2023-09-12 18:23 ` Rob Herring
2023-09-12 10:10 ` [PATCH v5 08/31] dt-bindings: soc: fsl: cpm_qe: cpm1-scc-qmc: Add support for QMC HDLC Herve Codina
2023-09-12 10:10 ` Herve Codina
2023-09-12 10:10 ` Herve Codina
2023-09-12 17:21 ` Conor Dooley
2023-09-12 17:21 ` Conor Dooley
2023-09-12 17:21 ` Conor Dooley
2023-09-13 7:26 ` Herve Codina
2023-09-13 7:26 ` Herve Codina
2023-09-13 7:26 ` Herve Codina
2023-09-13 14:42 ` Conor Dooley
2023-09-13 14:42 ` Conor Dooley
2023-09-13 14:42 ` Conor Dooley
2023-09-13 14:52 ` Herve Codina
2023-09-13 14:52 ` Herve Codina
2023-09-13 14:52 ` Herve Codina
2023-09-13 14:56 ` Conor Dooley
2023-09-13 14:56 ` Conor Dooley
2023-09-13 14:56 ` Conor Dooley
2023-09-13 14:59 ` Conor Dooley
2023-09-13 14:59 ` Conor Dooley
2023-09-13 14:59 ` Conor Dooley
2023-09-18 7:42 ` Herve Codina
2023-09-18 7:42 ` Herve Codina
2023-09-18 7:42 ` Herve Codina
2023-09-12 10:11 ` [PATCH v5 09/31] soc: fsl: cpm1: qmc: Add support for child devices Herve Codina
2023-09-12 10:11 ` Herve Codina
2023-09-12 10:11 ` Herve Codina
2023-09-12 10:12 ` [PATCH v5 10/31] net: wan: Add support for QMC HDLC Herve Codina
2023-09-12 10:12 ` Herve Codina
2023-09-12 10:12 ` Herve Codina
2023-09-12 10:12 ` [PATCH v5 11/31] MAINTAINERS: Add the Freescale QMC HDLC driver entry Herve Codina
2023-09-12 10:12 ` Herve Codina
2023-09-12 10:12 ` Herve Codina
2023-09-12 10:13 ` [PATCH v5 12/31] soc: fsl: cpm1: qmc: Introduce available timeslots masks Herve Codina
2023-09-12 10:13 ` Herve Codina
2023-09-12 10:13 ` Herve Codina
2023-09-12 10:13 ` [PATCH v5 13/31] soc: fsl: cpm1: qmc: Rename qmc_setup_tsa* to qmc_init_tsa* Herve Codina
2023-09-12 10:13 ` Herve Codina
2023-09-12 10:13 ` Herve Codina
2023-09-12 10:13 ` [PATCH v5 14/31] soc: fsl: cpm1: qmc: Introduce qmc_chan_setup_tsa* Herve Codina
2023-09-12 10:13 ` Herve Codina
2023-09-12 10:13 ` Herve Codina
2023-09-12 10:13 ` [PATCH v5 15/31] soc: fsl: cpm1: qmc: Remove no more needed checks from qmc_check_chans() Herve Codina
2023-09-12 10:13 ` Herve Codina
2023-09-12 10:13 ` Herve Codina
2023-09-12 10:13 ` [PATCH v5 16/31] soc: fsl: cpm1: qmc: Check available timeslots in qmc_check_chans() Herve Codina
2023-09-12 10:13 ` Herve Codina
2023-09-12 10:13 ` Herve Codina
2023-09-12 10:13 ` [PATCH v5 17/31] soc: fsl: cpm1: qmc: Add support for disabling channel TSA entries Herve Codina
2023-09-12 10:13 ` Herve Codina
2023-09-12 10:13 ` Herve Codina
2023-09-12 10:13 ` [PATCH v5 18/31] soc: fsl: cpm1: qmc: Split Tx and Rx TSA entries setup Herve Codina
2023-09-12 10:13 ` Herve Codina
2023-09-12 10:13 ` Herve Codina
2023-09-12 10:14 ` [PATCH v5 19/31] soc: fsl: cpm1: qmc: Introduce is_tsa_64rxtx flag Herve Codina
2023-09-12 10:14 ` Herve Codina
2023-09-12 10:14 ` Herve Codina
2023-09-12 10:14 ` [PATCH v5 20/31] soc: fsl: cpm1: qmc: Handle timeslot entries at channel start() and stop() Herve Codina
2023-09-12 10:14 ` Herve Codina
2023-09-12 10:14 ` Herve Codina
2023-09-12 10:14 ` [PATCH v5 21/31] soc: fsl: cpm1: qmc: Remove timeslots handling from setup_chan() Herve Codina
2023-09-12 10:14 ` Herve Codina
2023-09-12 10:14 ` Herve Codina
2023-09-12 10:14 ` [PATCH v5 22/31] soc: fsl: cpm1: qmc: Introduce functions to change timeslots at runtime Herve Codina
2023-09-12 10:14 ` Herve Codina
2023-09-12 10:14 ` Herve Codina
2023-09-12 10:14 ` [PATCH v5 23/31] wan: qmc_hdlc: Add runtime timeslots changes support Herve Codina
2023-09-12 10:14 ` Herve Codina
2023-09-12 10:14 ` Herve Codina
2023-09-12 10:14 ` [PATCH v5 24/31] net: wan: Add framer framework support Herve Codina
2023-09-12 10:14 ` Herve Codina
2023-09-12 10:14 ` Herve Codina
2023-09-13 16:59 ` Mark Brown
2023-09-13 16:59 ` Mark Brown
2023-09-13 16:59 ` Mark Brown
2023-09-12 10:14 ` [PATCH v5 25/31] dt-bindings: net: Add the Lantiq PEF2256 E1/T1/J1 framer Herve Codina
2023-09-12 10:14 ` Herve Codina
2023-09-12 10:14 ` Herve Codina
2023-09-12 18:13 ` Conor Dooley
2023-09-12 18:13 ` Conor Dooley
2023-09-12 18:13 ` Conor Dooley
2023-09-12 18:49 ` Christophe Leroy
2023-09-12 18:49 ` Christophe Leroy
2023-09-12 18:49 ` Christophe Leroy
2023-09-18 7:49 ` Herve Codina
2023-09-18 7:49 ` Herve Codina
2023-09-18 7:49 ` Herve Codina
2023-09-18 8:02 ` Herve Codina
2023-09-18 8:02 ` Herve Codina
2023-09-18 8:02 ` Herve Codina
2023-09-21 8:45 ` Christophe Leroy
2023-09-21 8:45 ` Christophe Leroy
2023-09-21 8:45 ` Christophe Leroy
2023-09-12 18:54 ` Rob Herring
2023-09-12 18:54 ` Rob Herring
2023-09-12 18:54 ` Rob Herring
2023-09-13 14:39 ` Conor Dooley
2023-09-13 14:39 ` Conor Dooley
2023-09-13 14:39 ` Conor Dooley
2023-09-12 10:14 ` [PATCH v5 26/31] mfd: core: Ensure disabled devices are skipped without aborting Herve Codina
2023-09-12 10:14 ` Herve Codina
2023-09-12 10:14 ` Herve Codina
2023-09-12 10:14 ` [PATCH v5 27/31] net: wan: framer: Add support for the Lantiq PEF2256 framer Herve Codina
2023-09-12 10:14 ` Herve Codina
2023-09-12 10:14 ` Herve Codina
2023-09-12 10:50 ` Linus Walleij
2023-09-12 10:50 ` Linus Walleij
2023-09-12 10:50 ` Linus Walleij
2023-09-12 10:15 ` [PATCH v5 28/31] pinctrl: Add support for the Lantic PEF2256 pinmux Herve Codina
2023-09-12 10:15 ` Herve Codina
2023-09-12 10:15 ` Herve Codina
2023-09-12 11:04 ` Linus Walleij
2023-09-12 11:04 ` Linus Walleij
2023-09-12 11:04 ` Linus Walleij
2023-09-12 14:31 ` Mark Brown
2023-09-12 14:31 ` Mark Brown
2023-09-12 14:31 ` Mark Brown
2023-09-12 21:04 ` Linus Walleij
2023-09-12 21:04 ` Linus Walleij
2023-09-12 21:04 ` Linus Walleij
2023-09-18 8:35 ` Herve Codina
2023-09-18 8:35 ` Herve Codina
2023-09-18 8:35 ` Herve Codina
2023-09-12 10:15 ` [PATCH v5 29/31] MAINTAINERS: Add the Lantiq PEF2256 driver entry Herve Codina
2023-09-12 10:15 ` Herve Codina
2023-09-12 10:15 ` Herve Codina
2023-09-12 11:05 ` Linus Walleij
2023-09-12 11:05 ` Linus Walleij
2023-09-12 11:05 ` Linus Walleij
2023-09-12 10:15 ` [PATCH v5 30/31] ASoC: codecs: Add support for the framer codec Herve Codina
2023-09-12 10:15 ` Herve Codina
2023-09-12 10:15 ` Herve Codina
2023-09-12 10:15 ` [PATCH v5 31/31] net: wan: fsl_qmc_hdlc: Add framer support Herve Codina
2023-09-12 10:15 ` Herve Codina
2023-09-12 10:15 ` Herve Codina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230912175832.GA995540-robh@kernel.org \
--to=robh@kernel.org \
--cc=Xiubo.Lee@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=andrew@lunn.ch \
--cc=broonie@kernel.org \
--cc=christophe.leroy@csgroup.eu \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=festevam@gmail.com \
--cc=herve.codina@bootlin.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=lee@kernel.org \
--cc=leoyang.li@nxp.com \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=nicoleotsuka@gmail.com \
--cc=pabeni@redhat.com \
--cc=perex@perex.cz \
--cc=qiang.zhao@nxp.com \
--cc=rdunlap@infradead.org \
--cc=shengjiu.wang@gmail.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.