* b4 tag parsing too lax?
@ 2023-09-13 19:44 Kees Cook
2023-09-13 20:00 ` Konstantin Ryabitsev
0 siblings, 1 reply; 6+ messages in thread
From: Kees Cook @ 2023-09-13 19:44 UTC (permalink / raw)
To: tools
Hi,
I just saw this in commit ef6e1997da63 ("wifi: mac80211: fortify the
spinlock against deadlock by interrupt"):
Reviewed-by: tag, or it goes automatically?
I tracked it down to:
https://lore.kernel.org/all/074cf5ed-c39d-1c16-12e7-4b14bbe0cac4@alu.unizg.hr/
I can't tell if we should just deal with kind of unfortunate misparsing,
or if b4 should require at least a "@" in the tag? (Though plenty of
tags are just someone's name without an email in the cases where no
email was available...)
-Kees
--
Kees Cook
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: b4 tag parsing too lax?
2023-09-13 19:44 b4 tag parsing too lax? Kees Cook
@ 2023-09-13 20:00 ` Konstantin Ryabitsev
2023-09-13 23:04 ` Kees Cook
0 siblings, 1 reply; 6+ messages in thread
From: Konstantin Ryabitsev @ 2023-09-13 20:00 UTC (permalink / raw)
To: Kees Cook; +Cc: tools
On Wed, Sep 13, 2023 at 12:44:43PM -0700, Kees Cook wrote:
> Hi,
>
> I just saw this in commit ef6e1997da63 ("wifi: mac80211: fortify the
> spinlock against deadlock by interrupt"):
>
> Reviewed-by: tag, or it goes automatically?
>
> I tracked it down to:
>
> https://lore.kernel.org/all/074cf5ed-c39d-1c16-12e7-4b14bbe0cac4@alu.unizg.hr/
>
> I can't tell if we should just deal with kind of unfortunate misparsing,
> or if b4 should require at least a "@" in the tag? (Though plenty of
> tags are just someone's name without an email in the cases where no
> email was available...)
I don't think b4 did this, because we already have precautions against this in
place. E.g. if you retrieve that with b4, you will see that it doesn't get
confused by that line:
$ b4 am -o/tmp https://lore.kernel.org/netdev/074cf5ed-c39d-1c16-12e7-4b14bbe0cac4@alu.unizg.hr/
Analyzing 5 messages in the thread
...
---
✗ [PATCH v4 1/1] wifi: mac80211: fortify the spinlock against deadlock by interrupt
+ Reviewed-by: Leon Romanovsky <leonro@nvidia.com> (✓ DKIM/kernel.org)
---
...
---
...
While it's possible that b4 did this, it's not any current version.
-K
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: b4 tag parsing too lax?
2023-09-13 20:00 ` Konstantin Ryabitsev
@ 2023-09-13 23:04 ` Kees Cook
2023-09-14 6:55 ` Johannes Berg
0 siblings, 1 reply; 6+ messages in thread
From: Kees Cook @ 2023-09-13 23:04 UTC (permalink / raw)
To: Konstantin Ryabitsev, Johannes Berg; +Cc: tools
On Wed, Sep 13, 2023 at 04:00:27PM -0400, Konstantin Ryabitsev wrote:
> On Wed, Sep 13, 2023 at 12:44:43PM -0700, Kees Cook wrote:
> > Hi,
> >
> > I just saw this in commit ef6e1997da63 ("wifi: mac80211: fortify the
> > spinlock against deadlock by interrupt"):
> >
> > Reviewed-by: tag, or it goes automatically?
> >
> > I tracked it down to:
> >
> > https://lore.kernel.org/all/074cf5ed-c39d-1c16-12e7-4b14bbe0cac4@alu.unizg.hr/
> >
> > I can't tell if we should just deal with kind of unfortunate misparsing,
> > or if b4 should require at least a "@" in the tag? (Though plenty of
> > tags are just someone's name without an email in the cases where no
> > email was available...)
>
> I don't think b4 did this, because we already have precautions against this in
> place. E.g. if you retrieve that with b4, you will see that it doesn't get
> confused by that line:
>
> $ b4 am -o/tmp https://lore.kernel.org/netdev/074cf5ed-c39d-1c16-12e7-4b14bbe0cac4@alu.unizg.hr/
> Analyzing 5 messages in the thread
> ...
> ---
> ✗ [PATCH v4 1/1] wifi: mac80211: fortify the spinlock against deadlock by interrupt
> + Reviewed-by: Leon Romanovsky <leonro@nvidia.com> (✓ DKIM/kernel.org)
> ---
> ...
> ---
> ...
>
> While it's possible that b4 did this, it's not any current version.
Okay, weird! I have no idea how that got there then.
I should have CCed Johannes Berg to start with, but now I have. :) I'm
curious what the workflow for that patch was -- do you use b4? (Perhaps
this was a b4 behavior accidentally back in May?)
Anyway, no worries. I only found 1 instance like this in the last year.
--
Kees Cook
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: b4 tag parsing too lax?
2023-09-13 23:04 ` Kees Cook
@ 2023-09-14 6:55 ` Johannes Berg
2023-09-14 13:44 ` Konstantin Ryabitsev
2023-09-14 16:55 ` Kees Cook
0 siblings, 2 replies; 6+ messages in thread
From: Johannes Berg @ 2023-09-14 6:55 UTC (permalink / raw)
To: Kees Cook, Konstantin Ryabitsev; +Cc: tools@linux.kernel.org, Kalle Valo
On Wed, 2023-09-13 at 23:04 +0000, Kees Cook wrote:
> On Wed, Sep 13, 2023 at 04:00:27PM -0400, Konstantin Ryabitsev wrote:
> > On Wed, Sep 13, 2023 at 12:44:43PM -0700, Kees Cook wrote:
> > > Hi,
> > >
> > > I just saw this in commit ef6e1997da63 ("wifi: mac80211: fortify the
> > > spinlock against deadlock by interrupt"):
> > >
> > > Reviewed-by: tag, or it goes automatically?
Heh, that's kinda funny.
> > While it's possible that b4 did this, it's not any current version.
It didn't.
> Okay, weird! I have no idea how that got there then.
>
> I should have CCed Johannes Berg to start with, but now I have. :) I'm
> curious what the workflow for that patch was -- do you use b4? (Perhaps
> this was a b4 behavior accidentally back in May?)
>
We use patchwork in wireless to assign the work between Kalle and I. I
guess I could still apply patches using b4 though, but don't, at this
point.
So I guess it's more a bug to report to patchwork, but I'm not sure how
much good that will do unless we fix it ourselves :)
johannes
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: b4 tag parsing too lax?
2023-09-14 6:55 ` Johannes Berg
@ 2023-09-14 13:44 ` Konstantin Ryabitsev
2023-09-14 16:55 ` Kees Cook
1 sibling, 0 replies; 6+ messages in thread
From: Konstantin Ryabitsev @ 2023-09-14 13:44 UTC (permalink / raw)
To: Johannes Berg; +Cc: Kees Cook, tools@linux.kernel.org, Kalle Valo
On Thu, Sep 14, 2023 at 08:55:25AM +0200, Johannes Berg wrote:
> We use patchwork in wireless to assign the work between Kalle and I. I
> guess I could still apply patches using b4 though, but don't, at this
> point.
You can integrate b4 with patchwork, to a degree. At the very least, you can
pass patchwork URLs to `b4 am` and reasonably expect them to do the right
thing (as long as it's the version of patchwork that uses msgid URLs for
threads).
-K
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: b4 tag parsing too lax?
2023-09-14 6:55 ` Johannes Berg
2023-09-14 13:44 ` Konstantin Ryabitsev
@ 2023-09-14 16:55 ` Kees Cook
1 sibling, 0 replies; 6+ messages in thread
From: Kees Cook @ 2023-09-14 16:55 UTC (permalink / raw)
To: Johannes Berg; +Cc: Konstantin Ryabitsev, tools@linux.kernel.org, Kalle Valo
On Thu, Sep 14, 2023 at 08:55:25AM +0200, Johannes Berg wrote:
> On Wed, 2023-09-13 at 23:04 +0000, Kees Cook wrote:
> > On Wed, Sep 13, 2023 at 04:00:27PM -0400, Konstantin Ryabitsev wrote:
> > > On Wed, Sep 13, 2023 at 12:44:43PM -0700, Kees Cook wrote:
> > > > Hi,
> > > >
> > > > I just saw this in commit ef6e1997da63 ("wifi: mac80211: fortify the
> > > > spinlock against deadlock by interrupt"):
> > > >
> > > > Reviewed-by: tag, or it goes automatically?
>
> Heh, that's kinda funny.
>
> > > While it's possible that b4 did this, it's not any current version.
>
> It didn't.
>
> > Okay, weird! I have no idea how that got there then.
> >
> > I should have CCed Johannes Berg to start with, but now I have. :) I'm
> > curious what the workflow for that patch was -- do you use b4? (Perhaps
> > this was a b4 behavior accidentally back in May?)
> >
>
> We use patchwork in wireless to assign the work between Kalle and I. I
> guess I could still apply patches using b4 though, but don't, at this
> point.
>
> So I guess it's more a bug to report to patchwork, but I'm not sure how
> much good that will do unless we fix it ourselves :)
Ah-ha! Patchwork did the collecting. Thanks for taking a look. :)
-Kees
--
Kees Cook
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-09-14 16:55 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-13 19:44 b4 tag parsing too lax? Kees Cook
2023-09-13 20:00 ` Konstantin Ryabitsev
2023-09-13 23:04 ` Kees Cook
2023-09-14 6:55 ` Johannes Berg
2023-09-14 13:44 ` Konstantin Ryabitsev
2023-09-14 16:55 ` Kees Cook
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.