All of lore.kernel.org
 help / color / mirror / Atom feed
From: rohan.g.thomas@intel.com
To: robh@kernel.org
Cc: alexandre.torgue@foss.st.com, conor+dt@kernel.org,
	davem@davemloft.net, devicetree@vger.kernel.org,
	edumazet@google.com, fancer.lancer@gmail.com,
	joabreu@synopsys.com, krzysztof.kozlowski+dt@linaro.org,
	kuba@kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	linux-stm32@st-md-mailman.stormreply.com,
	mcoquelin.stm32@gmail.com, netdev@vger.kernel.org,
	pabeni@redhat.com, peppe.cavallaro@st.com,
	rohan.g.thomas@intel.com
Subject: Re: [linux-drivers-review] [PATCH net-next v2 1/3] net: stmmac: xgmac: EST interrupts handling
Date: Sat, 16 Sep 2023 14:17:18 +0800	[thread overview]
Message-ID: <20230916061718.336-1-rohan.g.thomas@intel.com> (raw)
In-Reply-To: <20230915154258.GA3769303-robh@kernel.org>

From: Rohan G Thomas <rohan.g.thomas@intel.com>

Thanks for the review comments.
Will address this in the next version.

On Fri, Sep 15, 2023 at 05:54:16PM +0800, Rohan G Thomas wrote:
>> Add dt-bindings for coe-unsupported property per tx queue.
>
>Why? (What every commit msg should answer)
>
>> 
>> Signed-off-by: Rohan G Thomas <rohan.g.thomas@intel.com>
>> ---
>>  Documentation/devicetree/bindings/net/snps,dwmac.yaml | 3 +++
>>  1 file changed, 3 insertions(+)
>> 
>> diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
>> index ddf9522a5dc2..365e6cb73484 100644
>> --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml
>> +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
>> @@ -394,6 +394,9 @@ properties:
>>                When a PFC frame is received with priorities matching the bitmask,
>>                the queue is blocked from transmitting for the pause time specified
>>                in the PFC frame.
>
>blank line needed
>
>> +          snps,coe-unsupported:
>> +            type: boolean
>> +            description: TX checksum offload is unsupported by the TX queue.
>
>And here.
>
>>          allOf:
>>            - if:
>>                required:
>> -- 
>> 2.25.1
>> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: rohan.g.thomas@intel.com
To: robh@kernel.org
Cc: alexandre.torgue@foss.st.com, conor+dt@kernel.org,
	davem@davemloft.net, devicetree@vger.kernel.org,
	edumazet@google.com, fancer.lancer@gmail.com,
	joabreu@synopsys.com, krzysztof.kozlowski+dt@linaro.org,
	kuba@kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	linux-stm32@st-md-mailman.stormreply.com,
	mcoquelin.stm32@gmail.com, netdev@vger.kernel.org,
	pabeni@redhat.com, peppe.cavallaro@st.com,
	rohan.g.thomas@intel.com
Subject: Re: [linux-drivers-review] [PATCH net-next v2 1/3] net: stmmac: xgmac: EST interrupts handling
Date: Sat, 16 Sep 2023 14:17:18 +0800	[thread overview]
Message-ID: <20230916061718.336-1-rohan.g.thomas@intel.com> (raw)
In-Reply-To: <20230915154258.GA3769303-robh@kernel.org>

From: Rohan G Thomas <rohan.g.thomas@intel.com>

Thanks for the review comments.
Will address this in the next version.

On Fri, Sep 15, 2023 at 05:54:16PM +0800, Rohan G Thomas wrote:
>> Add dt-bindings for coe-unsupported property per tx queue.
>
>Why? (What every commit msg should answer)
>
>> 
>> Signed-off-by: Rohan G Thomas <rohan.g.thomas@intel.com>
>> ---
>>  Documentation/devicetree/bindings/net/snps,dwmac.yaml | 3 +++
>>  1 file changed, 3 insertions(+)
>> 
>> diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
>> index ddf9522a5dc2..365e6cb73484 100644
>> --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml
>> +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
>> @@ -394,6 +394,9 @@ properties:
>>                When a PFC frame is received with priorities matching the bitmask,
>>                the queue is blocked from transmitting for the pause time specified
>>                in the PFC frame.
>
>blank line needed
>
>> +          snps,coe-unsupported:
>> +            type: boolean
>> +            description: TX checksum offload is unsupported by the TX queue.
>
>And here.
>
>>          allOf:
>>            - if:
>>                required:
>> -- 
>> 2.25.1
>> 

  reply	other threads:[~2023-09-16  6:18 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-15  9:54 [PATCH net-next v6 0/2] net: stmmac: Tx coe sw fallback Rohan G Thomas
2023-09-15  9:54 ` Rohan G Thomas
2023-09-15  9:54 ` [PATCH net-next v6 1/2] dt-bindings: net: snps,dwmac: Tx coe unsupported Rohan G Thomas
2023-09-15  9:54   ` Rohan G Thomas
2023-09-15 15:42   ` Rob Herring
2023-09-15 15:42     ` Rob Herring
2023-09-16  6:17     ` rohan.g.thomas [this message]
2023-09-16  6:17       ` [linux-drivers-review] [PATCH net-next v2 1/3] net: stmmac: xgmac: EST interrupts handling rohan.g.thomas
2023-09-15  9:54 ` [PATCH net-next v6 2/2] net: stmmac: Tx coe sw fallback Rohan G Thomas
2023-09-15  9:54   ` Rohan G Thomas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230916061718.336-1-rohan.g.thomas@intel.com \
    --to=rohan.g.thomas@intel.com \
    --cc=alexandre.torgue@foss.st.com \
    --cc=conor+dt@kernel.org \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=edumazet@google.com \
    --cc=fancer.lancer@gmail.com \
    --cc=joabreu@synopsys.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=kuba@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=peppe.cavallaro@st.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.