All of lore.kernel.org
 help / color / mirror / Atom feed
From: Conor Dooley <conor.dooley@microchip.com>
To: Yu Chien Peter Lin <peterlin@andestech.com>
Cc: <paul.walmsley@sifive.com>, <palmer@dabbelt.com>,
	<aou@eecs.berkeley.edu>, <david@redhat.com>,
	<akpm@linux-foundation.org>, <alexghiti@rivosinc.com>,
	<bjorn@rivosinc.com>, <linux-riscv@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>, <ycliang@andestech.com>
Subject: Re: [PATCH v2 1/3] riscv: Improve PTDUMP to show RSW with non-zero value
Date: Mon, 18 Sep 2023 13:53:13 +0100	[thread overview]
Message-ID: <20230918-cassette-exclusion-b2ce53745a5c@wendy> (raw)
In-Reply-To: <20230914014027.273002-1-peterlin@andestech.com>


[-- Attachment #1.1: Type: text/plain, Size: 468 bytes --]

On Thu, Sep 14, 2023 at 09:40:25AM +0800, Yu Chien Peter Lin wrote:

> +		val = st->current_prot & pte_bits[i].mask;
> +		if (val) {
> +			if (pte_bits[i].mask == _PAGE_SOFT)
> +				sprintf(s, pte_bits[i].set, val >> 8);
> +			else
> +				sprintf(s, "%s", pte_bits[i].set);
> +		} else
> +			sprintf(s, "%s", pte_bits[i].clear);
> +

just a nit, but checkpatch in the automation is whinging that you have
forgotten to add {} around both branches if this if statement.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 161 bytes --]

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

WARNING: multiple messages have this Message-ID (diff)
From: Conor Dooley <conor.dooley@microchip.com>
To: Yu Chien Peter Lin <peterlin@andestech.com>
Cc: <paul.walmsley@sifive.com>, <palmer@dabbelt.com>,
	<aou@eecs.berkeley.edu>, <david@redhat.com>,
	<akpm@linux-foundation.org>, <alexghiti@rivosinc.com>,
	<bjorn@rivosinc.com>, <linux-riscv@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>, <ycliang@andestech.com>
Subject: Re: [PATCH v2 1/3] riscv: Improve PTDUMP to show RSW with non-zero value
Date: Mon, 18 Sep 2023 13:53:13 +0100	[thread overview]
Message-ID: <20230918-cassette-exclusion-b2ce53745a5c@wendy> (raw)
In-Reply-To: <20230914014027.273002-1-peterlin@andestech.com>

[-- Attachment #1: Type: text/plain, Size: 468 bytes --]

On Thu, Sep 14, 2023 at 09:40:25AM +0800, Yu Chien Peter Lin wrote:

> +		val = st->current_prot & pte_bits[i].mask;
> +		if (val) {
> +			if (pte_bits[i].mask == _PAGE_SOFT)
> +				sprintf(s, pte_bits[i].set, val >> 8);
> +			else
> +				sprintf(s, "%s", pte_bits[i].set);
> +		} else
> +			sprintf(s, "%s", pte_bits[i].clear);
> +

just a nit, but checkpatch in the automation is whinging that you have
forgotten to add {} around both branches if this if statement.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

  parent reply	other threads:[~2023-09-18 12:53 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-14  1:40 [PATCH v2 1/3] riscv: Improve PTDUMP to show RSW with non-zero value Yu Chien Peter Lin
2023-09-14  1:40 ` Yu Chien Peter Lin
2023-09-14  1:40 ` [PATCH v2 2/3] riscv: Introduce PBMT field to PTDUMP Yu Chien Peter Lin
2023-09-14  1:40   ` Yu Chien Peter Lin
2023-09-14  1:40 ` [PATCH v2 3/3] riscv: Introduce NAPOT " Yu Chien Peter Lin
2023-09-14  1:40   ` Yu Chien Peter Lin
2023-09-15 11:07 ` [PATCH v2 1/3] riscv: Improve PTDUMP to show RSW with non-zero value Alexandre Ghiti
2023-09-15 11:07   ` Alexandre Ghiti
2023-09-16  7:22   ` Yu-Chien Peter Lin
2023-09-16  7:22     ` Yu-Chien Peter Lin
2023-09-18 13:03     ` Alexandre Ghiti
2023-09-18 13:03       ` Alexandre Ghiti
2023-09-18 12:53 ` Conor Dooley [this message]
2023-09-18 12:53   ` Conor Dooley
2023-09-20  3:17   ` Yu-Chien Peter Lin
2023-09-20  3:17     ` Yu-Chien Peter Lin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230918-cassette-exclusion-b2ce53745a5c@wendy \
    --to=conor.dooley@microchip.com \
    --cc=akpm@linux-foundation.org \
    --cc=alexghiti@rivosinc.com \
    --cc=aou@eecs.berkeley.edu \
    --cc=bjorn@rivosinc.com \
    --cc=david@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    --cc=peterlin@andestech.com \
    --cc=ycliang@andestech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.