From: Rob Herring <robh@kernel.org>
To: Lee Jones <lee@kernel.org>
Cc: linux-kernel@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>
Subject: Re: [PATCH] dt-bindings: mfd: armltd: Move Arm board syscon's to separate schema
Date: Mon, 18 Sep 2023 12:27:20 -0500 [thread overview]
Message-ID: <20230918172720.GA1411360-robh@kernel.org> (raw)
In-Reply-To: <20230918143639.GP13143@google.com>
On Mon, Sep 18, 2023 at 03:36:39PM +0100, Lee Jones wrote:
> On Fri, 15 Sep 2023, Rob Herring wrote:
>
> >
> > On Fri, 15 Sep 2023 15:15:05 -0500, Rob Herring wrote:
> > > The Arm Ltd board bindings are a bit unusual in that they define child
> > > nodes for various syscon's. The schemas are also incomplete as they lack
> > > constraints on having additional properties and some properties are
> > > missing. As the bindings for the different platforms only vary by
> > > compatibles, combine them into a single schema doc.
> > >
> > > Add the "arm,im-pd1-syscon" compatible which was not documented. Add
> > > "ranges", "#address-cells", and "#size-cells properties which were
> > > missing.
> > >
> > > Signed-off-by: Rob Herring <robh@kernel.org>
> > > ---
> > > .../bindings/arm/arm,integrator.yaml | 39 -----------
> > > .../devicetree/bindings/arm/arm,realview.yaml | 37 ----------
> > > .../bindings/arm/arm,versatile.yaml | 40 +++--------
> > > .../mfd/arm,dev-platforms-syscon.yaml | 67 +++++++++++++++++++
> > > 4 files changed, 75 insertions(+), 108 deletions(-)
> > > create mode 100644 Documentation/devicetree/bindings/mfd/arm,dev-platforms-syscon.yaml
> > >
> >
> > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> > on your patch (DT_CHECKER_FLAGS is new in v5.13):
>
> Errr ... I'm a little torn.
>
> Do I trust the maintainer or his bot? :)
New version fixing the example coming...
Rob
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Lee Jones <lee@kernel.org>
Cc: linux-kernel@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>
Subject: Re: [PATCH] dt-bindings: mfd: armltd: Move Arm board syscon's to separate schema
Date: Mon, 18 Sep 2023 12:27:20 -0500 [thread overview]
Message-ID: <20230918172720.GA1411360-robh@kernel.org> (raw)
In-Reply-To: <20230918143639.GP13143@google.com>
On Mon, Sep 18, 2023 at 03:36:39PM +0100, Lee Jones wrote:
> On Fri, 15 Sep 2023, Rob Herring wrote:
>
> >
> > On Fri, 15 Sep 2023 15:15:05 -0500, Rob Herring wrote:
> > > The Arm Ltd board bindings are a bit unusual in that they define child
> > > nodes for various syscon's. The schemas are also incomplete as they lack
> > > constraints on having additional properties and some properties are
> > > missing. As the bindings for the different platforms only vary by
> > > compatibles, combine them into a single schema doc.
> > >
> > > Add the "arm,im-pd1-syscon" compatible which was not documented. Add
> > > "ranges", "#address-cells", and "#size-cells properties which were
> > > missing.
> > >
> > > Signed-off-by: Rob Herring <robh@kernel.org>
> > > ---
> > > .../bindings/arm/arm,integrator.yaml | 39 -----------
> > > .../devicetree/bindings/arm/arm,realview.yaml | 37 ----------
> > > .../bindings/arm/arm,versatile.yaml | 40 +++--------
> > > .../mfd/arm,dev-platforms-syscon.yaml | 67 +++++++++++++++++++
> > > 4 files changed, 75 insertions(+), 108 deletions(-)
> > > create mode 100644 Documentation/devicetree/bindings/mfd/arm,dev-platforms-syscon.yaml
> > >
> >
> > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> > on your patch (DT_CHECKER_FLAGS is new in v5.13):
>
> Errr ... I'm a little torn.
>
> Do I trust the maintainer or his bot? :)
New version fixing the example coming...
Rob
next prev parent reply other threads:[~2023-09-18 17:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-15 20:15 [PATCH] dt-bindings: mfd: armltd: Move Arm board syscon's to separate schema Rob Herring
2023-09-15 20:15 ` Rob Herring
2023-09-15 21:36 ` Rob Herring
2023-09-15 21:36 ` Rob Herring
2023-09-18 14:36 ` Lee Jones
2023-09-18 14:36 ` Lee Jones
2023-09-18 17:27 ` Rob Herring [this message]
2023-09-18 17:27 ` Rob Herring
2023-09-18 6:06 ` Linus Walleij
2023-09-18 6:06 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230918172720.GA1411360-robh@kernel.org \
--to=robh@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.