From: "Michael S. Tsirkin" <mst@redhat.com>
To: Matias Ezequiel Vara Larsen <mvaralar@redhat.com>
Cc: virtualization@lists.linux-foundation.org,
virtio-comment@lists.oasis-open.org,
anton.yakovlev@opensynergy.com, stefanha@redhat.com,
jasowang@redhat.com
Subject: [virtio-comment] Re: virtio-sound linux driver conformance to spec
Date: Tue, 19 Sep 2023 05:43:56 -0400 [thread overview]
Message-ID: <20230919054054-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <ZQHPeD0fds9sYzHO@pc-79.home>
On Wed, Sep 13, 2023 at 05:04:24PM +0200, Matias Ezequiel Vara Larsen wrote:
> Hello,
>
> This email is to report a behavior of the Linux virtio-sound driver that
> looks like it is not conforming to the VirtIO specification. The kernel
> driver is moving buffers from the used ring to the available ring
> without knowing if the content has been updated from the user. If the
> device picks up buffers from the available ring just after it is
> notified, it happens that the content is old.
Then, what happens, exactly? Do things still work?
> This problem can be fixed
> by waiting a period of time after the device dequeues a buffer from the
> available ring. The driver should not be allowed to change the content
> of a buffer in the available ring. When buffers are enqueued in the
> available ring, the device can consume them immediately.
>
> 1. Is the actual driver implementation following the spec?
> 2. Shall the spec be extended to support such a use-case?
>
> Thanks, Matias
This publicly archived list offers a means to provide input to the
OASIS Virtual I/O Device (VIRTIO) TC.
In order to verify user consent to the Feedback License terms and
to minimize spam in the list archive, subscription is required
before posting.
Subscribe: virtio-comment-subscribe@lists.oasis-open.org
Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org
List help: virtio-comment-help@lists.oasis-open.org
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Matias Ezequiel Vara Larsen <mvaralar@redhat.com>
Cc: virtio-comment@lists.oasis-open.org, stefanha@redhat.com,
virtualization@lists.linux-foundation.org
Subject: Re: virtio-sound linux driver conformance to spec
Date: Tue, 19 Sep 2023 05:43:56 -0400 [thread overview]
Message-ID: <20230919054054-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <ZQHPeD0fds9sYzHO@pc-79.home>
On Wed, Sep 13, 2023 at 05:04:24PM +0200, Matias Ezequiel Vara Larsen wrote:
> Hello,
>
> This email is to report a behavior of the Linux virtio-sound driver that
> looks like it is not conforming to the VirtIO specification. The kernel
> driver is moving buffers from the used ring to the available ring
> without knowing if the content has been updated from the user. If the
> device picks up buffers from the available ring just after it is
> notified, it happens that the content is old.
Then, what happens, exactly? Do things still work?
> This problem can be fixed
> by waiting a period of time after the device dequeues a buffer from the
> available ring. The driver should not be allowed to change the content
> of a buffer in the available ring. When buffers are enqueued in the
> available ring, the device can consume them immediately.
>
> 1. Is the actual driver implementation following the spec?
> 2. Shall the spec be extended to support such a use-case?
>
> Thanks, Matias
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2023-09-19 9:44 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-13 15:04 [virtio-comment] virtio-sound linux driver conformance to spec Matias Ezequiel Vara Larsen
2023-09-13 15:04 ` Matias Ezequiel Vara Larsen
2023-09-13 15:50 ` [virtio-comment] " Paolo Bonzini
2023-09-13 15:50 ` Paolo Bonzini
2023-09-13 15:58 ` Manos Pitsidianakis
2023-09-18 12:50 ` Matias Ezequiel Vara Larsen
2023-09-18 12:50 ` Matias Ezequiel Vara Larsen
2023-09-18 18:20 ` Stefan Hajnoczi
2023-09-18 18:20 ` Stefan Hajnoczi
2023-09-18 11:13 ` Matias Ezequiel Vara Larsen
2023-09-18 11:13 ` Matias Ezequiel Vara Larsen
2023-09-18 11:26 ` Matias Ezequiel Vara Larsen
2023-09-18 11:26 ` Matias Ezequiel Vara Larsen
2023-09-19 0:35 ` [virtio-comment] " Anton Yakovlev
2023-09-19 0:35 ` Anton Yakovlev via Virtualization
2023-09-19 6:58 ` [virtio-comment] " Paolo Bonzini
2023-09-19 6:58 ` Paolo Bonzini
2023-09-19 15:10 ` Stefan Hajnoczi
2023-09-19 15:10 ` Stefan Hajnoczi
2023-09-25 0:37 ` Anton Yakovlev
2023-09-25 0:37 ` Anton Yakovlev via Virtualization
2023-09-25 0:24 ` Anton Yakovlev
2023-09-25 0:24 ` Anton Yakovlev via Virtualization
2023-09-19 9:43 ` Michael S. Tsirkin [this message]
2023-09-19 9:43 ` Michael S. Tsirkin
2023-09-19 14:18 ` [virtio-comment] " Matias Ezequiel Vara Larsen
2023-09-19 14:18 ` Matias Ezequiel Vara Larsen
2023-09-19 15:52 ` [virtio-comment] " Michael S. Tsirkin
2023-09-19 15:52 ` Michael S. Tsirkin
2023-09-20 13:18 ` [virtio-comment] " Matias Ezequiel Vara Larsen
2023-09-20 13:18 ` Matias Ezequiel Vara Larsen
2023-09-25 1:04 ` [virtio-comment] " Anton Yakovlev
2023-09-25 1:04 ` Anton Yakovlev via Virtualization
2023-09-25 14:33 ` [virtio-comment] " Matias Ezequiel Vara Larsen
2023-09-25 14:33 ` Matias Ezequiel Vara Larsen
2023-09-25 0:55 ` [virtio-comment] " Anton Yakovlev
2023-09-25 0:55 ` Anton Yakovlev via Virtualization
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230919054054-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=anton.yakovlev@opensynergy.com \
--cc=jasowang@redhat.com \
--cc=mvaralar@redhat.com \
--cc=stefanha@redhat.com \
--cc=virtio-comment@lists.oasis-open.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.