All of lore.kernel.org
 help / color / mirror / Atom feed
* [sre-power-supply:for-next 27/68] drivers/power/supply/mm8013.c:236 mm8013_probe() warn: passing zero to 'dev_err_probe'
@ 2023-09-19  0:14 kernel test robot
  0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2023-09-19  0:14 UTC (permalink / raw)
  To: oe-kbuild; +Cc: lkp, Dan Carpenter

BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
TO: Konrad Dybcio <konrad.dybcio@linaro.org>
CC: Sebastian Reichel <sebastian.reichel@collabora.com>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/sre/linux-power-supply.git for-next
head:   a6c6a5fe2a08172c2e045588531f0e05a6c296cf
commit: c75f4bf6800bde67df22ac95139279ec8764118a [27/68] power: supply: Introduce MM8013 fuel gauge driver
:::::: branch date: 87 minutes ago
:::::: commit date: 3 days ago
config: i386-randconfig-141-20230918 (https://download.01.org/0day-ci/archive/20230919/202309190838.eu8WS6sz-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce: (https://download.01.org/0day-ci/archive/20230919/202309190838.eu8WS6sz-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202309190838.eu8WS6sz-lkp@intel.com/

smatch warnings:
drivers/power/supply/mm8013.c:236 mm8013_probe() warn: passing zero to 'dev_err_probe'

vim +/dev_err_probe +236 drivers/power/supply/mm8013.c

c75f4bf6800bde Konrad Dybcio 2023-09-15  215  
c75f4bf6800bde Konrad Dybcio 2023-09-15  216  static int mm8013_probe(struct i2c_client *client)
c75f4bf6800bde Konrad Dybcio 2023-09-15  217  {
c75f4bf6800bde Konrad Dybcio 2023-09-15  218  	struct power_supply_config psy_cfg = {};
c75f4bf6800bde Konrad Dybcio 2023-09-15  219  	struct device *dev = &client->dev;
c75f4bf6800bde Konrad Dybcio 2023-09-15  220  	struct power_supply *psy;
c75f4bf6800bde Konrad Dybcio 2023-09-15  221  	struct mm8013_chip *chip;
c75f4bf6800bde Konrad Dybcio 2023-09-15  222  	int ret = 0;
c75f4bf6800bde Konrad Dybcio 2023-09-15  223  
c75f4bf6800bde Konrad Dybcio 2023-09-15  224  	if (!i2c_check_functionality(client->adapter, I2C_FUNC_SMBUS_WORD_DATA))
c75f4bf6800bde Konrad Dybcio 2023-09-15  225  		return dev_err_probe(dev, -EIO,
c75f4bf6800bde Konrad Dybcio 2023-09-15  226  				     "I2C_FUNC_SMBUS_WORD_DATA not supported\n");
c75f4bf6800bde Konrad Dybcio 2023-09-15  227  
c75f4bf6800bde Konrad Dybcio 2023-09-15  228  	chip = devm_kzalloc(dev, sizeof(struct mm8013_chip), GFP_KERNEL);
c75f4bf6800bde Konrad Dybcio 2023-09-15  229  	if (!chip)
c75f4bf6800bde Konrad Dybcio 2023-09-15  230  		return -ENOMEM;
c75f4bf6800bde Konrad Dybcio 2023-09-15  231  
c75f4bf6800bde Konrad Dybcio 2023-09-15  232  	chip->client = client;
c75f4bf6800bde Konrad Dybcio 2023-09-15  233  
c75f4bf6800bde Konrad Dybcio 2023-09-15  234  	chip->regmap = devm_regmap_init_i2c(client, &mm8013_regmap_config);
c75f4bf6800bde Konrad Dybcio 2023-09-15  235  	if (IS_ERR(chip->regmap))
c75f4bf6800bde Konrad Dybcio 2023-09-15 @236  		return dev_err_probe(dev, ret, "Couldn't initialize regmap\n");
c75f4bf6800bde Konrad Dybcio 2023-09-15  237  
c75f4bf6800bde Konrad Dybcio 2023-09-15  238  	ret = mm8013_checkdevice(chip);
c75f4bf6800bde Konrad Dybcio 2023-09-15  239  	if (ret)
c75f4bf6800bde Konrad Dybcio 2023-09-15  240  		return dev_err_probe(dev, ret, "MM8013 not found\n");
c75f4bf6800bde Konrad Dybcio 2023-09-15  241  
c75f4bf6800bde Konrad Dybcio 2023-09-15  242  	psy_cfg.drv_data = chip;
c75f4bf6800bde Konrad Dybcio 2023-09-15  243  	psy_cfg.of_node = dev->of_node;
c75f4bf6800bde Konrad Dybcio 2023-09-15  244  
c75f4bf6800bde Konrad Dybcio 2023-09-15  245  	psy = devm_power_supply_register(dev, &mm8013_desc, &psy_cfg);
c75f4bf6800bde Konrad Dybcio 2023-09-15  246  	if (IS_ERR(psy))
c75f4bf6800bde Konrad Dybcio 2023-09-15  247  		return PTR_ERR(psy);
c75f4bf6800bde Konrad Dybcio 2023-09-15  248  
c75f4bf6800bde Konrad Dybcio 2023-09-15  249  	return 0;
c75f4bf6800bde Konrad Dybcio 2023-09-15  250  }
c75f4bf6800bde Konrad Dybcio 2023-09-15  251  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2023-09-19  0:15 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-19  0:14 [sre-power-supply:for-next 27/68] drivers/power/supply/mm8013.c:236 mm8013_probe() warn: passing zero to 'dev_err_probe' kernel test robot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.