From: Rob Herring <robh@kernel.org>
To: Tomer Maimon <tmaimon77@gmail.com>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
peter.chen@kernel.org, gregkh@linuxfoundation.org,
krzysztof.kozlowski+dt@linaro.org, xu.yang_2@nxp.com,
peng.fan@nxp.com, avifishman70@gmail.com, tali.perry1@gmail.com,
joel@jms.id.au, venture@google.com, yuenn@google.com,
benjaminfair@google.com, j.neuschaefer@gmx.net,
openbmc@lists.ozlabs.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v1 1/2] dt-binding: usb: ci-hdrc-usb2: document Nuvoton NPCM supprt
Date: Tue, 19 Sep 2023 11:28:37 -0500 [thread overview]
Message-ID: <20230919162837.GA4051010-robh@kernel.org> (raw)
In-Reply-To: <CAP6Zq1g0=-h0PFg2a8bqao+XjdNHoxGMdYSRRPAnfY_6WdemAw@mail.gmail.com>
On Tue, Sep 19, 2023 at 04:31:56PM +0300, Tomer Maimon wrote:
> On Tue, 19 Sept 2023 at 15:39, Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org> wrote:
> >
> > On 19/09/2023 07:14, Tomer Maimon wrote:
> > >>> - nvidia,tegra20-ehci
> > >>> - nvidia,tegra20-udc
> > >>> - nvidia,tegra30-ehci
> > >>> @@ -325,6 +326,20 @@ properties:
> > >>> type: boolean
> > >>> deprecated: true
> > >>>
> > >>> + nuvoton,sysgcr:
> > >>> + $ref: /schemas/types.yaml#/definitions/phandle-array
> > >>> + items:
> > >>> + - items:
> > >>> + - description: phandle to syscon that configures usb phy mux.
> > >>> + - description: offset of usb phy mux selection.
> > >>> + - description: mask usb phy mux selection.
> > >>> + - description: value usb phy mux selection.
> > >>> + description:
> > >>> + A phandle to syscon with three arguments that configure usb phy mux.
> > >>> + The argument one is the offset of usb phy mux selection, the argument two
> > >>> + is the mask usb phy mux selection, the argument three is the mask usb phy
> > >>> + mux selection.
> > >>
> > >> Sorry, you miss phy driver. Don't use syscon instead of proper hardware
> > >> devices.
> > > Sorry the role of nuvoton,sysgcr property is to handle a mux between
> > > the different devices and not the handle the phy itself, handle the
> > > mux done in the GCR.
> > > Should we move the nuvoton,sysgcr description to another place in the
> > > ci-hdrc-usb2.yaml
> > > or
> > > Should we use a different driver to handle the mux and call it from
> > > the ci-hdrc-npcm driver, If yes which driver should we use?
> >
> > What is an "usb phy mux"?
> We have USB phy that could be connected to USB host (different driver)
> or it can be connected to the UDC driver(ChipIdea)
Isn't that just role switching? There is a driver framework for that in
drivers/usb/roles/. Though it doesn't seem widely used yet.
Rob
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Tomer Maimon <tmaimon77@gmail.com>
Cc: devicetree@vger.kernel.org, peng.fan@nxp.com,
linux-usb@vger.kernel.org, benjaminfair@google.com,
avifishman70@gmail.com, gregkh@linuxfoundation.org,
peter.chen@kernel.org, xu.yang_2@nxp.com, j.neuschaefer@gmx.net,
tali.perry1@gmail.com,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
joel@jms.id.au, krzysztof.kozlowski+dt@linaro.org,
venture@google.com, openbmc@lists.ozlabs.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/2] dt-binding: usb: ci-hdrc-usb2: document Nuvoton NPCM supprt
Date: Tue, 19 Sep 2023 11:28:37 -0500 [thread overview]
Message-ID: <20230919162837.GA4051010-robh@kernel.org> (raw)
In-Reply-To: <CAP6Zq1g0=-h0PFg2a8bqao+XjdNHoxGMdYSRRPAnfY_6WdemAw@mail.gmail.com>
On Tue, Sep 19, 2023 at 04:31:56PM +0300, Tomer Maimon wrote:
> On Tue, 19 Sept 2023 at 15:39, Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org> wrote:
> >
> > On 19/09/2023 07:14, Tomer Maimon wrote:
> > >>> - nvidia,tegra20-ehci
> > >>> - nvidia,tegra20-udc
> > >>> - nvidia,tegra30-ehci
> > >>> @@ -325,6 +326,20 @@ properties:
> > >>> type: boolean
> > >>> deprecated: true
> > >>>
> > >>> + nuvoton,sysgcr:
> > >>> + $ref: /schemas/types.yaml#/definitions/phandle-array
> > >>> + items:
> > >>> + - items:
> > >>> + - description: phandle to syscon that configures usb phy mux.
> > >>> + - description: offset of usb phy mux selection.
> > >>> + - description: mask usb phy mux selection.
> > >>> + - description: value usb phy mux selection.
> > >>> + description:
> > >>> + A phandle to syscon with three arguments that configure usb phy mux.
> > >>> + The argument one is the offset of usb phy mux selection, the argument two
> > >>> + is the mask usb phy mux selection, the argument three is the mask usb phy
> > >>> + mux selection.
> > >>
> > >> Sorry, you miss phy driver. Don't use syscon instead of proper hardware
> > >> devices.
> > > Sorry the role of nuvoton,sysgcr property is to handle a mux between
> > > the different devices and not the handle the phy itself, handle the
> > > mux done in the GCR.
> > > Should we move the nuvoton,sysgcr description to another place in the
> > > ci-hdrc-usb2.yaml
> > > or
> > > Should we use a different driver to handle the mux and call it from
> > > the ci-hdrc-npcm driver, If yes which driver should we use?
> >
> > What is an "usb phy mux"?
> We have USB phy that could be connected to USB host (different driver)
> or it can be connected to the UDC driver(ChipIdea)
Isn't that just role switching? There is a driver framework for that in
drivers/usb/roles/. Though it doesn't seem widely used yet.
Rob
next prev parent reply other threads:[~2023-09-19 16:28 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-18 16:59 [PATCH v1 0/2] usb: ChipIdea: add Nuvoton NPCM UDC support Tomer Maimon
2023-09-18 16:59 ` Tomer Maimon
2023-09-18 16:59 ` [PATCH v1 1/2] dt-binding: usb: ci-hdrc-usb2: document Nuvoton NPCM supprt Tomer Maimon
2023-09-18 16:59 ` Tomer Maimon
2023-09-18 20:18 ` Krzysztof Kozlowski
2023-09-19 5:14 ` Tomer Maimon
2023-09-19 5:14 ` Tomer Maimon
2023-09-19 12:39 ` Krzysztof Kozlowski
2023-09-19 13:31 ` Tomer Maimon
2023-09-19 13:31 ` Tomer Maimon
2023-09-19 16:28 ` Rob Herring [this message]
2023-09-19 16:28 ` Rob Herring
2023-09-20 9:11 ` Tomer Maimon
2023-09-20 9:11 ` Tomer Maimon
2023-09-21 13:17 ` Tomer Maimon
2023-09-21 13:17 ` Tomer Maimon
2023-09-23 11:46 ` Krzysztof Kozlowski
2023-09-18 16:59 ` [PATCH v1 2/2] usb: chipidea: Add support for NPCM Tomer Maimon
2023-09-18 16:59 ` Tomer Maimon
2023-09-19 7:45 ` kernel test robot
2023-09-19 7:45 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230919162837.GA4051010-robh@kernel.org \
--to=robh@kernel.org \
--cc=avifishman70@gmail.com \
--cc=benjaminfair@google.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=j.neuschaefer@gmx.net \
--cc=joel@jms.id.au \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=openbmc@lists.ozlabs.org \
--cc=peng.fan@nxp.com \
--cc=peter.chen@kernel.org \
--cc=tali.perry1@gmail.com \
--cc=tmaimon77@gmail.com \
--cc=venture@google.com \
--cc=xu.yang_2@nxp.com \
--cc=yuenn@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.