From: kernel test robot <lkp@intel.com>
To: Daniel Gomez <da.gomez@samsung.com>
Cc: oe-kbuild-all@lists.linux.dev
Subject: Re: [PATCH v2 5/6] shmem: add file length in shmem_get_folio path
Date: Thu, 21 Sep 2023 02:03:37 +0800 [thread overview]
Message-ID: <202309210143.LTEqtr2H-lkp@intel.com> (raw)
In-Reply-To: <20230919135536.2165715-6-da.gomez@samsung.com>
Hi Daniel,
kernel test robot noticed the following build errors:
[auto build test ERROR on akpm-mm/mm-everything]
[also build test ERROR on linus/master v6.6-rc2 next-20230920]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Daniel-Gomez/shmem-drop-BLOCKS_PER_PAGE-macro/20230920-005146
base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything
patch link: https://lore.kernel.org/r/20230919135536.2165715-6-da.gomez%40samsung.com
patch subject: [PATCH v2 5/6] shmem: add file length in shmem_get_folio path
config: sparc-randconfig-001-20230920 (https://download.01.org/0day-ci/archive/20230921/202309210143.LTEqtr2H-lkp@intel.com/config)
compiler: sparc64-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230921/202309210143.LTEqtr2H-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202309210143.LTEqtr2H-lkp@intel.com/
All errors (new ones prefixed by >>):
mm/userfaultfd.c: In function 'mfill_atomic_pte_continue':
>> mm/userfaultfd.c:259:15: error: too few arguments to function 'shmem_get_folio'
259 | ret = shmem_get_folio(inode, pgoff, &folio, SGP_NOALLOC);
| ^~~~~~~~~~~~~~~
In file included from mm/userfaultfd.c:17:
include/linux/shmem_fs.h:135:5: note: declared here
135 | int shmem_get_folio(struct inode *inode, pgoff_t index, struct folio **foliop,
| ^~~~~~~~~~~~~~~
vim +/shmem_get_folio +259 mm/userfaultfd.c
c1a4de99fada21 Andrea Arcangeli 2015-09-04 246
153132571f0204 Axel Rasmussen 2021-06-30 247 /* Handles UFFDIO_CONTINUE for all shmem VMAs (shared or private). */
61c5004022f56c Axel Rasmussen 2023-03-14 248 static int mfill_atomic_pte_continue(pmd_t *dst_pmd,
153132571f0204 Axel Rasmussen 2021-06-30 249 struct vm_area_struct *dst_vma,
153132571f0204 Axel Rasmussen 2021-06-30 250 unsigned long dst_addr,
d9712937037e0c Axel Rasmussen 2023-03-14 251 uffd_flags_t flags)
153132571f0204 Axel Rasmussen 2021-06-30 252 {
153132571f0204 Axel Rasmussen 2021-06-30 253 struct inode *inode = file_inode(dst_vma->vm_file);
153132571f0204 Axel Rasmussen 2021-06-30 254 pgoff_t pgoff = linear_page_index(dst_vma, dst_addr);
12acf4fbc4f78b Matthew Wilcox (Oracle 2022-09-02 255) struct folio *folio;
153132571f0204 Axel Rasmussen 2021-06-30 256 struct page *page;
153132571f0204 Axel Rasmussen 2021-06-30 257 int ret;
153132571f0204 Axel Rasmussen 2021-06-30 258
12acf4fbc4f78b Matthew Wilcox (Oracle 2022-09-02 @259) ret = shmem_get_folio(inode, pgoff, &folio, SGP_NOALLOC);
12acf4fbc4f78b Matthew Wilcox (Oracle 2022-09-02 260) /* Our caller expects us to return -EFAULT if we failed to find folio */
73f37dbcfe1763 Axel Rasmussen 2022-06-10 261 if (ret == -ENOENT)
73f37dbcfe1763 Axel Rasmussen 2022-06-10 262 ret = -EFAULT;
153132571f0204 Axel Rasmussen 2021-06-30 263 if (ret)
153132571f0204 Axel Rasmussen 2021-06-30 264 goto out;
12acf4fbc4f78b Matthew Wilcox (Oracle 2022-09-02 265) if (!folio) {
153132571f0204 Axel Rasmussen 2021-06-30 266 ret = -EFAULT;
153132571f0204 Axel Rasmussen 2021-06-30 267 goto out;
153132571f0204 Axel Rasmussen 2021-06-30 268 }
153132571f0204 Axel Rasmussen 2021-06-30 269
12acf4fbc4f78b Matthew Wilcox (Oracle 2022-09-02 270) page = folio_file_page(folio, pgoff);
a7605426666196 Yang Shi 2022-01-14 271 if (PageHWPoison(page)) {
a7605426666196 Yang Shi 2022-01-14 272 ret = -EIO;
a7605426666196 Yang Shi 2022-01-14 273 goto out_release;
a7605426666196 Yang Shi 2022-01-14 274 }
a7605426666196 Yang Shi 2022-01-14 275
61c5004022f56c Axel Rasmussen 2023-03-14 276 ret = mfill_atomic_install_pte(dst_pmd, dst_vma, dst_addr,
d9712937037e0c Axel Rasmussen 2023-03-14 277 page, false, flags);
153132571f0204 Axel Rasmussen 2021-06-30 278 if (ret)
153132571f0204 Axel Rasmussen 2021-06-30 279 goto out_release;
153132571f0204 Axel Rasmussen 2021-06-30 280
12acf4fbc4f78b Matthew Wilcox (Oracle 2022-09-02 281) folio_unlock(folio);
153132571f0204 Axel Rasmussen 2021-06-30 282 ret = 0;
153132571f0204 Axel Rasmussen 2021-06-30 283 out:
153132571f0204 Axel Rasmussen 2021-06-30 284 return ret;
153132571f0204 Axel Rasmussen 2021-06-30 285 out_release:
12acf4fbc4f78b Matthew Wilcox (Oracle 2022-09-02 286) folio_unlock(folio);
12acf4fbc4f78b Matthew Wilcox (Oracle 2022-09-02 287) folio_put(folio);
153132571f0204 Axel Rasmussen 2021-06-30 288 goto out;
153132571f0204 Axel Rasmussen 2021-06-30 289 }
153132571f0204 Axel Rasmussen 2021-06-30 290
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2023-09-20 18:04 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20230919135546eucas1p1181b8914fb5eceda5f08068802941358@eucas1p1.samsung.com>
2023-09-19 13:55 ` [PATCH v2 0/6] shmem: high order folios support in write path Daniel Gomez
2023-09-19 13:55 ` [PATCH v2 1/6] shmem: drop BLOCKS_PER_PAGE macro Daniel Gomez
2023-09-19 13:55 ` [PATCH v2 2/6] shmem: return freed pages in shmem_free_swap Daniel Gomez
2023-09-19 14:56 ` Matthew Wilcox
2023-09-19 13:55 ` [PATCH v2 3/6] shmem: account for large order folios Daniel Gomez
2023-09-19 13:55 ` [PATCH v2 4/6] shmem: add order parameter support to shmem_alloc_folio Daniel Gomez
2023-09-19 13:55 ` [PATCH v2 5/6] shmem: add file length in shmem_get_folio path Daniel Gomez
2023-09-20 18:03 ` kernel test robot [this message]
2023-09-19 13:55 ` [PATCH v2 6/6] shmem: add large folios support to the write path Daniel Gomez
2023-09-19 15:01 ` Matthew Wilcox
2023-09-19 16:28 ` Daniel Gomez
2023-09-20 17:41 ` kernel test robot
2023-09-25 20:39 ` kernel test robot
2023-10-28 21:15 ` [RFC PATCH 00/11] shmem: high order folios support in " Daniel Gomez
2023-10-28 21:15 ` [RFC PATCH 01/11] XArray: add cmpxchg order test Daniel Gomez
2023-10-29 20:11 ` Matthew Wilcox
2023-11-03 23:12 ` Daniel Gomez
2023-10-28 21:15 ` [RFC PATCH 02/11] test_xarray: add tests for advanced multi-index use Daniel Gomez
2023-10-28 21:15 ` [RFC PATCH 03/11] shmem: drop BLOCKS_PER_PAGE macro Daniel Gomez
2023-10-28 21:15 ` [RFC PATCH 04/11] shmem: return number of pages beeing freed in shmem_free_swap Daniel Gomez
2023-10-28 21:15 ` [RFC PATCH 05/11] shmem: account for large order folios Daniel Gomez
2023-10-29 20:40 ` Matthew Wilcox
2023-10-28 21:15 ` [RFC PATCH 06/11] shmem: trace shmem_add_to_page_cache folio order Daniel Gomez
2023-10-29 23:14 ` Matthew Wilcox
2023-10-28 21:15 ` [RFC PATCH 07/11] shmem: remove huge arg from shmem_alloc_and_add_folio() Daniel Gomez
2023-10-29 23:17 ` Matthew Wilcox
2023-10-28 21:15 ` [RFC PATCH 08/11] shmem: add file length arg in shmem_get_folio() path Daniel Gomez
2023-10-28 21:15 ` [RFC PATCH 09/11] shmem: add order arg to shmem_alloc_folio() Daniel Gomez
2023-10-31 7:04 ` Hannes Reinecke
2023-10-28 21:15 ` [RFC PATCH 10/11] shmem: add large folio support to the write path Daniel Gomez
2023-10-28 23:51 ` kernel test robot
2023-10-29 23:32 ` Matthew Wilcox
2023-10-28 21:15 ` [RFC PATCH 11/11] shmem: add per-block uptodate tracking Daniel Gomez
2023-10-28 23:51 ` kernel test robot
2023-10-29 4:46 ` kernel test robot
2023-10-29 20:43 ` [RFC PATCH 00/11] shmem: high order folios support in write path Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202309210143.LTEqtr2H-lkp@intel.com \
--to=lkp@intel.com \
--cc=da.gomez@samsung.com \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.