Re: [RFC PATCH 10/11] shmem: add large folio support to the write path

[kernel test robot <lkp@intel.com>]

Hi Daniel,

[This is a private test report for your RFC patch.]
kernel test robot noticed the following build warnings:

[auto build test WARNING on akpm-mm/mm-everything]
[also build test WARNING on next-20231027]
[cannot apply to linus/master v6.6-rc7]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Daniel-Gomez/XArray-add-cmpxchg-order-test/20231029-051730
base:   https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything
patch link:    https://lore.kernel.org/r/20231028211518.3424020-11-da.gomez%40samsung.com
patch subject: [RFC PATCH 10/11] shmem: add large folio support to the write path
config: loongarch-allyesconfig (https://download.01.org/0day-ci/archive/20231029/202310290726.C5ndh95F-lkp@intel.com/config)
compiler: loongarch64-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231029/202310290726.C5ndh95F-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202310290726.C5ndh95F-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> mm/shmem.c:1652: warning: Function parameter or member 'sbinfo' not described in 'shmem_mapping_size_order'


vim +1652 mm/shmem.c

  1633	
  1634	/**
  1635	 * shmem_mapping_size_order - Get maximum folio order for the given file size.
  1636	 * @mapping: Target address_space.
  1637	 * @index: The page index.
  1638	 * @size: The suggested size of the folio to create.
  1639	 *
  1640	 * This returns a high order for folios (when supported) based on the file size
  1641	 * which the mapping currently allows at the given index. The index is relevant
  1642	 * due to alignment considerations the mapping might have. The returned order
  1643	 * may be less than the size passed.
  1644	 *
  1645	 * Like __filemap_get_folio order calculation.
  1646	 *
  1647	 * Return: The order.
  1648	 */
  1649	static inline unsigned int
  1650	shmem_mapping_size_order(struct address_space *mapping, pgoff_t index,
  1651				 size_t size, struct shmem_sb_info *sbinfo)
> 1652	{
  1653		unsigned int order = ilog2(size);
  1654	
  1655		if ((order <= PAGE_SHIFT) ||
  1656		    (!mapping_large_folio_support(mapping) || !sbinfo->noswap))
  1657			return 0;
  1658	
  1659		order -= PAGE_SHIFT;
  1660	
  1661		/* If we're not aligned, allocate a smaller folio */
  1662		if (index & ((1UL << order) - 1))
  1663			order = __ffs(index);
  1664	
  1665		order = min_t(size_t, order, MAX_PAGECACHE_ORDER);
  1666	
  1667		/* Order-1 not supported due to THP dependency */
  1668		return (order == 1) ? 0 : order;
  1669	}
  1670	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki