All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@redhat.com>
To: Akihiko Odaki <akihiko.odaki@daynix.com>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org,
	virtio-fs@redhat.com, Yuval Shaia <yuval.shaia.ml@gmail.com>,
	Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
	Konstantin Kostiuk <kkostiuk@redhat.com>,
	Michael Roth <michael.roth@amd.com>,
	Paolo Bonzini <pbonzini@redhat.com>, Fam Zheng <fam@euphon.net>,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
	Gerd Hoffmann <kraxel@redhat.com>, Stefan Weil <sw@weilnetz.de>,
	Yan Vugenfirer <yan@daynix.com>
Subject: Re: [Virtio-fs] [PATCH v2 07/10] virtiofsd: Use qemu_get_runtime_dir()
Date: Thu, 21 Sep 2023 08:58:28 -0400	[thread overview]
Message-ID: <20230921125828.GA3860191@fedora> (raw)
In-Reply-To: <20221110100629.61496-8-akihiko.odaki@daynix.com>

[-- Attachment #1: Type: text/plain, Size: 1435 bytes --]

On Thu, Nov 10, 2022 at 07:06:26PM +0900, Akihiko Odaki wrote:
> qemu_get_runtime_dir() is used to construct the path to a lock file.
> 
> Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
> ---
>  tools/virtiofsd/fuse_virtio.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/tools/virtiofsd/fuse_virtio.c b/tools/virtiofsd/fuse_virtio.c
> index 9368e292e4..b9eeed85e6 100644
> --- a/tools/virtiofsd/fuse_virtio.c
> +++ b/tools/virtiofsd/fuse_virtio.c
> @@ -901,12 +901,12 @@ static bool fv_socket_lock(struct fuse_session *se)
>  {
>      g_autofree gchar *sk_name = NULL;
>      g_autofree gchar *pidfile = NULL;
> -    g_autofree gchar *state = NULL;
> +    g_autofree gchar *run = NULL;
>      g_autofree gchar *dir = NULL;
>      Error *local_err = NULL;
>  
> -    state = qemu_get_local_state_dir();
> -    dir = g_build_filename(state, "run", "virtiofsd", NULL);
> +    run = qemu_get_runtime_dir();
> +    dir = g_build_filename(run, "virtiofsd", NULL);
>  
>      if (g_mkdir_with_parents(dir, S_IRWXU) < 0) {
>          fuse_log(FUSE_LOG_ERR, "%s: Failed to create directory %s: %s\n",

tools/virtiofsd/ no longer exists. Which version of QEMU did you develop against?

commit e0dc2631ec4ac718ebe22ddea0ab25524eb37b0e
Author: Dr. David Alan Gilbert <dgilbert@redhat.com>
Date:   Wed Jan 18 12:11:51 2023 +0000

    virtiofsd: Remove source

Stefan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Stefan Hajnoczi <stefanha@redhat.com>
To: Akihiko Odaki <akihiko.odaki@daynix.com>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org,
	virtio-fs@redhat.com, Yuval Shaia <yuval.shaia.ml@gmail.com>,
	Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
	Konstantin Kostiuk <kkostiuk@redhat.com>,
	Michael Roth <michael.roth@amd.com>,
	Paolo Bonzini <pbonzini@redhat.com>, Fam Zheng <fam@euphon.net>,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
	Gerd Hoffmann <kraxel@redhat.com>, Stefan Weil <sw@weilnetz.de>,
	Yan Vugenfirer <yan@daynix.com>
Subject: Re: [PATCH v2 07/10] virtiofsd: Use qemu_get_runtime_dir()
Date: Thu, 21 Sep 2023 08:58:28 -0400	[thread overview]
Message-ID: <20230921125828.GA3860191@fedora> (raw)
In-Reply-To: <20221110100629.61496-8-akihiko.odaki@daynix.com>

[-- Attachment #1: Type: text/plain, Size: 1435 bytes --]

On Thu, Nov 10, 2022 at 07:06:26PM +0900, Akihiko Odaki wrote:
> qemu_get_runtime_dir() is used to construct the path to a lock file.
> 
> Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
> ---
>  tools/virtiofsd/fuse_virtio.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/tools/virtiofsd/fuse_virtio.c b/tools/virtiofsd/fuse_virtio.c
> index 9368e292e4..b9eeed85e6 100644
> --- a/tools/virtiofsd/fuse_virtio.c
> +++ b/tools/virtiofsd/fuse_virtio.c
> @@ -901,12 +901,12 @@ static bool fv_socket_lock(struct fuse_session *se)
>  {
>      g_autofree gchar *sk_name = NULL;
>      g_autofree gchar *pidfile = NULL;
> -    g_autofree gchar *state = NULL;
> +    g_autofree gchar *run = NULL;
>      g_autofree gchar *dir = NULL;
>      Error *local_err = NULL;
>  
> -    state = qemu_get_local_state_dir();
> -    dir = g_build_filename(state, "run", "virtiofsd", NULL);
> +    run = qemu_get_runtime_dir();
> +    dir = g_build_filename(run, "virtiofsd", NULL);
>  
>      if (g_mkdir_with_parents(dir, S_IRWXU) < 0) {
>          fuse_log(FUSE_LOG_ERR, "%s: Failed to create directory %s: %s\n",

tools/virtiofsd/ no longer exists. Which version of QEMU did you develop against?

commit e0dc2631ec4ac718ebe22ddea0ab25524eb37b0e
Author: Dr. David Alan Gilbert <dgilbert@redhat.com>
Date:   Wed Jan 18 12:11:51 2023 +0000

    virtiofsd: Remove source

Stefan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2023-09-21 12:58 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-10 10:06 [Virtio-fs] [PATCH v2 00/10] util: Introduce qemu_get_runtime_dir() Akihiko Odaki
2022-11-10 10:06 ` Akihiko Odaki
2022-11-10 10:06 ` [Virtio-fs] [PATCH v2 01/10] qga: Remove platform GUID definitions Akihiko Odaki
2022-11-10 10:06   ` Akihiko Odaki
2022-11-17  9:45   ` [Virtio-fs] " Konstantin Kostiuk
2022-11-17  9:45     ` Konstantin Kostiuk
2023-09-21  7:58     ` [Virtio-fs] " Akihiko Odaki
2023-09-21  7:58       ` Akihiko Odaki
2023-09-21  9:52       ` [Virtio-fs] " Konstantin Kostiuk
2023-09-21  9:52         ` Konstantin Kostiuk
2022-11-10 10:06 ` [Virtio-fs] [PATCH v2 02/10] util: Introduce qemu_get_runtime_dir() Akihiko Odaki
2022-11-10 10:06   ` Akihiko Odaki
2022-11-10 10:06 ` [Virtio-fs] [PATCH v2 03/10] ivshmem-server: Use qemu_get_runtime_dir() Akihiko Odaki
2022-11-10 10:06   ` Akihiko Odaki
2022-11-10 10:06 ` [Virtio-fs] [PATCH v2 04/10] contrib/rdmacm-mux: " Akihiko Odaki
2022-11-10 10:06   ` Akihiko Odaki
2022-11-10 10:06 ` [Virtio-fs] [PATCH v2 05/10] qga: " Akihiko Odaki
2022-11-10 10:06   ` Akihiko Odaki
2022-11-10 10:06 ` [Virtio-fs] [PATCH v2 06/10] scsi: " Akihiko Odaki
2022-11-10 10:06   ` Akihiko Odaki
2022-11-10 10:06 ` [Virtio-fs] [PATCH v2 07/10] virtiofsd: " Akihiko Odaki
2022-11-10 10:06   ` Akihiko Odaki
2023-09-21 12:58   ` Stefan Hajnoczi [this message]
2023-09-21 12:58     ` Stefan Hajnoczi
2023-09-21 13:56     ` [Virtio-fs] " Akihiko Odaki
2023-09-21 13:56       ` Akihiko Odaki
2022-11-10 10:06 ` [Virtio-fs] [PATCH v2 08/10] module: " Akihiko Odaki
2022-11-10 10:06   ` Akihiko Odaki
2022-11-10 10:06 ` [Virtio-fs] [PATCH v2 09/10] util: Remove qemu_get_local_state_dir() Akihiko Odaki
2022-11-10 10:06   ` Akihiko Odaki
2022-11-10 10:06 ` [Virtio-fs] [PATCH v2 10/10] spice-app: Use qemu_get_runtime_dir() Akihiko Odaki
2022-11-10 10:06   ` Akihiko Odaki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230921125828.GA3860191@fedora \
    --to=stefanha@redhat.com \
    --cc=akihiko.odaki@daynix.com \
    --cc=dgilbert@redhat.com \
    --cc=fam@euphon.net \
    --cc=kkostiuk@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=marcel.apfelbaum@gmail.com \
    --cc=michael.roth@amd.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=sw@weilnetz.de \
    --cc=virtio-fs@redhat.com \
    --cc=yan@daynix.com \
    --cc=yuval.shaia.ml@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.