Re: [PATCH v2 5/7] platform: cznic: turris-omnia-mcu: Add support for MCU watchdog

["Marek Behún" <kabel@kernel.org>]

> > +static int omnia_wdt_start(struct watchdog_device *wdt)
> > +{
> > +	struct omnia_mcu *mcu = watchdog_get_drvdata(wdt);
> > +
> > +	/*
> > +	 * The MCU also implements LED controller, and the LED driver may in
> > +	 * some cases require more I2C bandwidth. In order to prevent stealing
> > +	 * that bandwidth from the LED driver, configure minimum time between
> > +	 * pings to 10% of the configured timeout (for 120 second timeout we
> > +	 * will be pinging at most every 12 seconds).
> > +	 */
> > +	mcu->wdt.min_hw_heartbeat_ms = 100 * mcu->wdt.timeout;  
> 
> This is not what min_hw_heartbeat_ms is supposed to be used for, and it is
> an abuse of the API which is not guaranteed to work. The value is exopected
> to be set at registration time, and it is not supposed to change dynamically.
> It is also competely unnecessary since no sane watchdog daemon will ping
> at such a high rate. Please drop.

Hello Guenter, thanks for the review.

Sorry about this, I thought this was correct cause rti_wdt driver and
feared that watchdog daemons would actually ping at such rate.

I will drop it in the next version of the series.

Marek