* drivers/fsi/i2cr-scom.c:50 i2cr_scom_read() warn: maybe return -EFAULT instead of the bytes remaining?
@ 2023-09-23 20:08 kernel test robot
0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2023-09-23 20:08 UTC (permalink / raw)
To: oe-kbuild; +Cc: lkp, Dan Carpenter
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
CC: linux-kernel@vger.kernel.org
TO: Eddie James <eajames@linux.ibm.com>
CC: Joel Stanley <joel@jms.id.au>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 5a4de7dc9e77ca914bb050e6d661624a43db794c
commit: c0b34bed0bbf7a058dab52d45e9aeb92bbe4c637 fsi: Add I2C Responder SCOM driver
date: 6 weeks ago
:::::: branch date: 2 hours ago
:::::: commit date: 6 weeks ago
config: csky-randconfig-r071-20230917 (https://download.01.org/0day-ci/archive/20230924/202309240413.DL08aSAL-lkp@intel.com/config)
compiler: csky-linux-gcc (GCC) 13.2.0
reproduce: (https://download.01.org/0day-ci/archive/20230924/202309240413.DL08aSAL-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202309240413.DL08aSAL-lkp@intel.com/
smatch warnings:
drivers/fsi/i2cr-scom.c:50 i2cr_scom_read() warn: maybe return -EFAULT instead of the bytes remaining?
drivers/fsi/i2cr-scom.c:67 i2cr_scom_write() warn: maybe return -EFAULT instead of the bytes remaining?
vim +50 drivers/fsi/i2cr-scom.c
c0b34bed0bbf7a Eddie James 2023-06-12 34
c0b34bed0bbf7a Eddie James 2023-06-12 35 static ssize_t i2cr_scom_read(struct file *filep, char __user *buf, size_t len, loff_t *offset)
c0b34bed0bbf7a Eddie James 2023-06-12 36 {
c0b34bed0bbf7a Eddie James 2023-06-12 37 struct i2cr_scom *scom = filep->private_data;
c0b34bed0bbf7a Eddie James 2023-06-12 38 u64 data;
c0b34bed0bbf7a Eddie James 2023-06-12 39 int ret;
c0b34bed0bbf7a Eddie James 2023-06-12 40
c0b34bed0bbf7a Eddie James 2023-06-12 41 if (len != sizeof(data))
c0b34bed0bbf7a Eddie James 2023-06-12 42 return -EINVAL;
c0b34bed0bbf7a Eddie James 2023-06-12 43
c0b34bed0bbf7a Eddie James 2023-06-12 44 ret = fsi_master_i2cr_read(scom->i2cr, (u32)*offset, &data);
c0b34bed0bbf7a Eddie James 2023-06-12 45 if (ret)
c0b34bed0bbf7a Eddie James 2023-06-12 46 return ret;
c0b34bed0bbf7a Eddie James 2023-06-12 47
c0b34bed0bbf7a Eddie James 2023-06-12 48 ret = copy_to_user(buf, &data, len);
c0b34bed0bbf7a Eddie James 2023-06-12 49 if (ret)
c0b34bed0bbf7a Eddie James 2023-06-12 @50 return ret;
c0b34bed0bbf7a Eddie James 2023-06-12 51
c0b34bed0bbf7a Eddie James 2023-06-12 52 return len;
c0b34bed0bbf7a Eddie James 2023-06-12 53 }
c0b34bed0bbf7a Eddie James 2023-06-12 54
c0b34bed0bbf7a Eddie James 2023-06-12 55 static ssize_t i2cr_scom_write(struct file *filep, const char __user *buf, size_t len,
c0b34bed0bbf7a Eddie James 2023-06-12 56 loff_t *offset)
c0b34bed0bbf7a Eddie James 2023-06-12 57 {
c0b34bed0bbf7a Eddie James 2023-06-12 58 struct i2cr_scom *scom = filep->private_data;
c0b34bed0bbf7a Eddie James 2023-06-12 59 u64 data;
c0b34bed0bbf7a Eddie James 2023-06-12 60 int ret;
c0b34bed0bbf7a Eddie James 2023-06-12 61
c0b34bed0bbf7a Eddie James 2023-06-12 62 if (len != sizeof(data))
c0b34bed0bbf7a Eddie James 2023-06-12 63 return -EINVAL;
c0b34bed0bbf7a Eddie James 2023-06-12 64
c0b34bed0bbf7a Eddie James 2023-06-12 65 ret = copy_from_user(&data, buf, len);
c0b34bed0bbf7a Eddie James 2023-06-12 66 if (ret)
c0b34bed0bbf7a Eddie James 2023-06-12 @67 return ret;
c0b34bed0bbf7a Eddie James 2023-06-12 68
c0b34bed0bbf7a Eddie James 2023-06-12 69 ret = fsi_master_i2cr_write(scom->i2cr, (u32)*offset, data);
c0b34bed0bbf7a Eddie James 2023-06-12 70 if (ret)
c0b34bed0bbf7a Eddie James 2023-06-12 71 return ret;
c0b34bed0bbf7a Eddie James 2023-06-12 72
c0b34bed0bbf7a Eddie James 2023-06-12 73 return len;
c0b34bed0bbf7a Eddie James 2023-06-12 74 }
c0b34bed0bbf7a Eddie James 2023-06-12 75
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 2+ messages in thread* drivers/fsi/i2cr-scom.c:50 i2cr_scom_read() warn: maybe return -EFAULT instead of the bytes remaining?
@ 2023-09-18 10:18 kernel test robot
0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2023-09-18 10:18 UTC (permalink / raw)
To: oe-kbuild; +Cc: lkp, Dan Carpenter
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
CC: linux-kernel@vger.kernel.org
TO: Eddie James <eajames@linux.ibm.com>
CC: Joel Stanley <joel@jms.id.au>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: ce9ecca0238b140b88f43859b211c9fdfd8e5b70
commit: c0b34bed0bbf7a058dab52d45e9aeb92bbe4c637 fsi: Add I2C Responder SCOM driver
date: 5 weeks ago
:::::: branch date: 12 hours ago
:::::: commit date: 5 weeks ago
config: csky-randconfig-r071-20230917 (https://download.01.org/0day-ci/archive/20230918/202309181824.bTzfxPjm-lkp@intel.com/config)
compiler: csky-linux-gcc (GCC) 13.2.0
reproduce: (https://download.01.org/0day-ci/archive/20230918/202309181824.bTzfxPjm-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202309181824.bTzfxPjm-lkp@intel.com/
smatch warnings:
drivers/fsi/i2cr-scom.c:50 i2cr_scom_read() warn: maybe return -EFAULT instead of the bytes remaining?
drivers/fsi/i2cr-scom.c:67 i2cr_scom_write() warn: maybe return -EFAULT instead of the bytes remaining?
vim +50 drivers/fsi/i2cr-scom.c
c0b34bed0bbf7a Eddie James 2023-06-12 34
c0b34bed0bbf7a Eddie James 2023-06-12 35 static ssize_t i2cr_scom_read(struct file *filep, char __user *buf, size_t len, loff_t *offset)
c0b34bed0bbf7a Eddie James 2023-06-12 36 {
c0b34bed0bbf7a Eddie James 2023-06-12 37 struct i2cr_scom *scom = filep->private_data;
c0b34bed0bbf7a Eddie James 2023-06-12 38 u64 data;
c0b34bed0bbf7a Eddie James 2023-06-12 39 int ret;
c0b34bed0bbf7a Eddie James 2023-06-12 40
c0b34bed0bbf7a Eddie James 2023-06-12 41 if (len != sizeof(data))
c0b34bed0bbf7a Eddie James 2023-06-12 42 return -EINVAL;
c0b34bed0bbf7a Eddie James 2023-06-12 43
c0b34bed0bbf7a Eddie James 2023-06-12 44 ret = fsi_master_i2cr_read(scom->i2cr, (u32)*offset, &data);
c0b34bed0bbf7a Eddie James 2023-06-12 45 if (ret)
c0b34bed0bbf7a Eddie James 2023-06-12 46 return ret;
c0b34bed0bbf7a Eddie James 2023-06-12 47
c0b34bed0bbf7a Eddie James 2023-06-12 48 ret = copy_to_user(buf, &data, len);
c0b34bed0bbf7a Eddie James 2023-06-12 49 if (ret)
c0b34bed0bbf7a Eddie James 2023-06-12 @50 return ret;
c0b34bed0bbf7a Eddie James 2023-06-12 51
c0b34bed0bbf7a Eddie James 2023-06-12 52 return len;
c0b34bed0bbf7a Eddie James 2023-06-12 53 }
c0b34bed0bbf7a Eddie James 2023-06-12 54
c0b34bed0bbf7a Eddie James 2023-06-12 55 static ssize_t i2cr_scom_write(struct file *filep, const char __user *buf, size_t len,
c0b34bed0bbf7a Eddie James 2023-06-12 56 loff_t *offset)
c0b34bed0bbf7a Eddie James 2023-06-12 57 {
c0b34bed0bbf7a Eddie James 2023-06-12 58 struct i2cr_scom *scom = filep->private_data;
c0b34bed0bbf7a Eddie James 2023-06-12 59 u64 data;
c0b34bed0bbf7a Eddie James 2023-06-12 60 int ret;
c0b34bed0bbf7a Eddie James 2023-06-12 61
c0b34bed0bbf7a Eddie James 2023-06-12 62 if (len != sizeof(data))
c0b34bed0bbf7a Eddie James 2023-06-12 63 return -EINVAL;
c0b34bed0bbf7a Eddie James 2023-06-12 64
c0b34bed0bbf7a Eddie James 2023-06-12 65 ret = copy_from_user(&data, buf, len);
c0b34bed0bbf7a Eddie James 2023-06-12 66 if (ret)
c0b34bed0bbf7a Eddie James 2023-06-12 @67 return ret;
c0b34bed0bbf7a Eddie James 2023-06-12 68
c0b34bed0bbf7a Eddie James 2023-06-12 69 ret = fsi_master_i2cr_write(scom->i2cr, (u32)*offset, data);
c0b34bed0bbf7a Eddie James 2023-06-12 70 if (ret)
c0b34bed0bbf7a Eddie James 2023-06-12 71 return ret;
c0b34bed0bbf7a Eddie James 2023-06-12 72
c0b34bed0bbf7a Eddie James 2023-06-12 73 return len;
c0b34bed0bbf7a Eddie James 2023-06-12 74 }
c0b34bed0bbf7a Eddie James 2023-06-12 75
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-09-23 20:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-23 20:08 drivers/fsi/i2cr-scom.c:50 i2cr_scom_read() warn: maybe return -EFAULT instead of the bytes remaining? kernel test robot
-- strict thread matches above, loose matches on Subject: below --
2023-09-18 10:18 kernel test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.