From: Shawn Guo <shawnguo@kernel.org>
To: Ying Liu <victor.liu@nxp.com>
Cc: Fabio Estevam <festevam@gmail.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"krzysztof.kozlowski+dt@linaro.org"
<krzysztof.kozlowski+dt@linaro.org>,
"conor+dt@kernel.org" <conor+dt@kernel.org>,
"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
dl-linux-imx <linux-imx@nxp.com>
Subject: Re: [PATCH 1/2] arm64: dts: imx8mm-evk: Add VDDEXT_3V3 fixed regulator
Date: Sun, 24 Sep 2023 21:13:02 +0800 [thread overview]
Message-ID: <20230924131302.GF7231@dragon> (raw)
In-Reply-To: <DB8PR04MB705143050E09106FFA17DF97981EA@DB8PR04MB7051.eurprd04.prod.outlook.com>
On Mon, Aug 21, 2023 at 02:33:17AM +0000, Ying Liu wrote:
> On Friday, August 18, 2023 10:06 PM Fabio Estevam <festevam@gmail.com> wrote:
> > On Mon, Aug 14, 2023 at 5:07 AM Liu Ying <victor.liu@nxp.com> wrote:
> >
> > > + reg_vddext_3v3: regulator-vddext-3v3 {
> > > + compatible = "regulator-fixed";
> > > + regulator-name = "VDDEXT_3V3";
> > > + regulator-min-microvolt = <3300000>;
> > > + regulator-max-microvolt = <300000>;
> > > + };
> >
> > Booting the dtb with this change will cause this regulator to be
> > disabled as there is no consumer for it.
>
> Software cannot control this regulator by any means. It's on once
> the board is powered on. Do you mean it will be disabled in software
> level if no consumer? If that's the case, is the disablement harmful?
>
> >
> > I suggest squashing both patches:
>
> The patch looks self-contained to me. Can we keep it as-is?
While I agree the patch is self-contained, squashing them will make it
easier to apply the change as a fix and cherry-pick the fix to stable
kernel.
Applied with squashing, thanks!
Shawn
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo@kernel.org>
To: Ying Liu <victor.liu@nxp.com>
Cc: Fabio Estevam <festevam@gmail.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"krzysztof.kozlowski+dt@linaro.org"
<krzysztof.kozlowski+dt@linaro.org>,
"conor+dt@kernel.org" <conor+dt@kernel.org>,
"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
dl-linux-imx <linux-imx@nxp.com>
Subject: Re: [PATCH 1/2] arm64: dts: imx8mm-evk: Add VDDEXT_3V3 fixed regulator
Date: Sun, 24 Sep 2023 21:13:02 +0800 [thread overview]
Message-ID: <20230924131302.GF7231@dragon> (raw)
In-Reply-To: <DB8PR04MB705143050E09106FFA17DF97981EA@DB8PR04MB7051.eurprd04.prod.outlook.com>
On Mon, Aug 21, 2023 at 02:33:17AM +0000, Ying Liu wrote:
> On Friday, August 18, 2023 10:06 PM Fabio Estevam <festevam@gmail.com> wrote:
> > On Mon, Aug 14, 2023 at 5:07 AM Liu Ying <victor.liu@nxp.com> wrote:
> >
> > > + reg_vddext_3v3: regulator-vddext-3v3 {
> > > + compatible = "regulator-fixed";
> > > + regulator-name = "VDDEXT_3V3";
> > > + regulator-min-microvolt = <3300000>;
> > > + regulator-max-microvolt = <300000>;
> > > + };
> >
> > Booting the dtb with this change will cause this regulator to be
> > disabled as there is no consumer for it.
>
> Software cannot control this regulator by any means. It's on once
> the board is powered on. Do you mean it will be disabled in software
> level if no consumer? If that's the case, is the disablement harmful?
>
> >
> > I suggest squashing both patches:
>
> The patch looks self-contained to me. Can we keep it as-is?
While I agree the patch is self-contained, squashing them will make it
easier to apply the change as a fix and cherry-pick the fix to stable
kernel.
Applied with squashing, thanks!
Shawn
next prev parent reply other threads:[~2023-09-24 13:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-14 8:11 [PATCH 0/2] arm64: dts: imx8mm-evk: Fix hdmi@3d node Liu Ying
2023-08-14 8:11 ` Liu Ying
2023-08-14 8:11 ` [PATCH 1/2] arm64: dts: imx8mm-evk: Add VDDEXT_3V3 fixed regulator Liu Ying
2023-08-14 8:11 ` Liu Ying
2023-08-18 14:05 ` Fabio Estevam
2023-08-18 14:05 ` Fabio Estevam
2023-08-21 2:33 ` Ying Liu
2023-08-21 2:33 ` Ying Liu
2023-09-24 13:13 ` Shawn Guo [this message]
2023-09-24 13:13 ` Shawn Guo
2023-08-14 8:11 ` [PATCH 2/2] arm64: dts: imx8mm-evk: Fix hdmi@3d node Liu Ying
2023-08-14 8:11 ` Liu Ying
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230924131302.GF7231@dragon \
--to=shawnguo@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=victor.liu@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.