All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgg@nvidia.com>
To: Baolu Lu <baolu.lu@linux.intel.com>
Cc: Alyssa Rosenzweig <alyssa@rosenzweig.io>,
	asahi@lists.linux.dev,
	Christophe Leroy <christophe.leroy@csgroup.eu>,
	David Woodhouse <dwmw2@infradead.org>,
	iommu@lists.linux.dev, Joerg Roedel <joro@8bytes.org>,
	Kevin Tian <kevin.tian@intel.com>,
	linux-arm-kernel@lists.infradead.org,
	linuxppc-dev@lists.ozlabs.org, Hector Martin <marcan@marcan.st>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Nicholas Piggin <npiggin@gmail.com>,
	Robin Murphy <robin.murphy@arm.com>,
	Sven Peter <sven@svenpeter.dev>, Will Deacon <will@kernel.org>
Subject: Re: [PATCH 3/8] iommu/vt-d: Use ops->blocked_domain
Date: Mon, 25 Sep 2023 08:41:42 -0300	[thread overview]
Message-ID: <20230925114142.GU13733@nvidia.com> (raw)
In-Reply-To: <ad9644a2-e8a6-d0fa-ad55-f4e0564c39a0@linux.intel.com>

On Mon, Sep 25, 2023 at 10:29:52AM +0800, Baolu Lu wrote:
> On 9/23/23 1:07 AM, Jason Gunthorpe wrote:
> > Trivially migrate to the ops->blocked_domain for the existing global
> > static.
> > 
> > Signed-off-by: Jason Gunthorpe<jgg@nvidia.com>
> > ---
> >   drivers/iommu/intel/iommu.c | 3 +--
> >   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> Reviewed-by: Lu Baolu <baolu.lu@linux.intel.com>
> 
> P.S. We can further do the same thing to the identity domain. I will
> clean it up after all patches are landed.

I looked at that, and it is not trivial..

Both the Intel and virtio-iommu drivers create an "identity" domain
out of a paging domain and pass that off as a true "identity"
domain. So neither can set the global static since the determination
is at runtime..

What I was thinking about doing is consolidating that code so that the
core logic is the thing turning a paging domain into an identity
domain.

Jason

WARNING: multiple messages have this Message-ID (diff)
From: Jason Gunthorpe <jgg@nvidia.com>
To: Baolu Lu <baolu.lu@linux.intel.com>
Cc: linux-arm-kernel@lists.infradead.org,
	Kevin Tian <kevin.tian@intel.com>, Will Deacon <will@kernel.org>,
	Sven Peter <sven@svenpeter.dev>,
	linuxppc-dev@lists.ozlabs.org, Joerg Roedel <joro@8bytes.org>,
	Hector Martin <marcan@marcan.st>,
	Nicholas Piggin <npiggin@gmail.com>,
	Robin Murphy <robin.murphy@arm.com>,
	iommu@lists.linux.dev, asahi@lists.linux.dev,
	David Woodhouse <dwmw2@infradead.org>,
	Alyssa Rosenzweig <alyssa@rosenzweig.io>
Subject: Re: [PATCH 3/8] iommu/vt-d: Use ops->blocked_domain
Date: Mon, 25 Sep 2023 08:41:42 -0300	[thread overview]
Message-ID: <20230925114142.GU13733@nvidia.com> (raw)
In-Reply-To: <ad9644a2-e8a6-d0fa-ad55-f4e0564c39a0@linux.intel.com>

On Mon, Sep 25, 2023 at 10:29:52AM +0800, Baolu Lu wrote:
> On 9/23/23 1:07 AM, Jason Gunthorpe wrote:
> > Trivially migrate to the ops->blocked_domain for the existing global
> > static.
> > 
> > Signed-off-by: Jason Gunthorpe<jgg@nvidia.com>
> > ---
> >   drivers/iommu/intel/iommu.c | 3 +--
> >   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> Reviewed-by: Lu Baolu <baolu.lu@linux.intel.com>
> 
> P.S. We can further do the same thing to the identity domain. I will
> clean it up after all patches are landed.

I looked at that, and it is not trivial..

Both the Intel and virtio-iommu drivers create an "identity" domain
out of a paging domain and pass that off as a true "identity"
domain. So neither can set the global static since the determination
is at runtime..

What I was thinking about doing is consolidating that code so that the
core logic is the thing turning a paging domain into an identity
domain.

Jason

WARNING: multiple messages have this Message-ID (diff)
From: Jason Gunthorpe <jgg@nvidia.com>
To: Baolu Lu <baolu.lu@linux.intel.com>
Cc: Alyssa Rosenzweig <alyssa@rosenzweig.io>,
	asahi@lists.linux.dev,
	Christophe Leroy <christophe.leroy@csgroup.eu>,
	David Woodhouse <dwmw2@infradead.org>,
	iommu@lists.linux.dev, Joerg Roedel <joro@8bytes.org>,
	Kevin Tian <kevin.tian@intel.com>,
	linux-arm-kernel@lists.infradead.org,
	linuxppc-dev@lists.ozlabs.org, Hector Martin <marcan@marcan.st>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Nicholas Piggin <npiggin@gmail.com>,
	Robin Murphy <robin.murphy@arm.com>,
	Sven Peter <sven@svenpeter.dev>, Will Deacon <will@kernel.org>
Subject: Re: [PATCH 3/8] iommu/vt-d: Use ops->blocked_domain
Date: Mon, 25 Sep 2023 08:41:42 -0300	[thread overview]
Message-ID: <20230925114142.GU13733@nvidia.com> (raw)
In-Reply-To: <ad9644a2-e8a6-d0fa-ad55-f4e0564c39a0@linux.intel.com>

On Mon, Sep 25, 2023 at 10:29:52AM +0800, Baolu Lu wrote:
> On 9/23/23 1:07 AM, Jason Gunthorpe wrote:
> > Trivially migrate to the ops->blocked_domain for the existing global
> > static.
> > 
> > Signed-off-by: Jason Gunthorpe<jgg@nvidia.com>
> > ---
> >   drivers/iommu/intel/iommu.c | 3 +--
> >   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> Reviewed-by: Lu Baolu <baolu.lu@linux.intel.com>
> 
> P.S. We can further do the same thing to the identity domain. I will
> clean it up after all patches are landed.

I looked at that, and it is not trivial..

Both the Intel and virtio-iommu drivers create an "identity" domain
out of a paging domain and pass that off as a true "identity"
domain. So neither can set the global static since the determination
is at runtime..

What I was thinking about doing is consolidating that code so that the
core logic is the thing turning a paging domain into an identity
domain.

Jason

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2023-09-25 11:41 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-22 17:07 [PATCH 0/8] iommu: Convert dart & iommufd to the new domain_alloc_paging() Jason Gunthorpe
2023-09-22 17:07 ` Jason Gunthorpe
2023-09-22 17:07 ` [PATCH 1/8] iommu: Move IOMMU_DOMAIN_BLOCKED global statics to ops->blocked_domain Jason Gunthorpe
2023-09-22 17:07   ` Jason Gunthorpe
2023-09-25  2:26   ` Baolu Lu
2023-09-25  2:26     ` Baolu Lu
2023-09-22 17:07 ` [PATCH 2/8] iommu/vt-d: Update the definition of the blocking domain Jason Gunthorpe
2023-09-22 17:07   ` Jason Gunthorpe
2023-09-25  2:27   ` Baolu Lu
2023-09-25  2:27     ` Baolu Lu
2023-09-22 17:07 ` [PATCH 3/8] iommu/vt-d: Use ops->blocked_domain Jason Gunthorpe
2023-09-22 17:07   ` Jason Gunthorpe
2023-09-25  2:29   ` Baolu Lu
2023-09-25  2:29     ` Baolu Lu
2023-09-25 11:41     ` Jason Gunthorpe [this message]
2023-09-25 11:41       ` Jason Gunthorpe
2023-09-25 11:41       ` Jason Gunthorpe
2023-09-26  3:28       ` Baolu Lu
2023-09-26  3:28         ` Baolu Lu
2023-09-26  3:28         ` Baolu Lu
2023-09-22 17:07 ` [PATCH 4/8] iommufd: Convert to alloc_domain_paging() Jason Gunthorpe
2023-09-22 17:07   ` Jason Gunthorpe
2023-09-22 17:07 ` [PATCH 5/8] iommu/dart: Use static global identity domains Jason Gunthorpe
2023-09-22 17:07   ` Jason Gunthorpe
2023-09-26 18:49   ` Janne Grunau
2023-09-26 18:49     ` Janne Grunau
2023-09-22 17:07 ` [PATCH 6/8] iommu/dart: Move the blocked domain support to a global static Jason Gunthorpe
2023-09-22 17:07   ` Jason Gunthorpe
2023-09-26 19:05   ` Janne Grunau
2023-09-26 19:05     ` Janne Grunau
2023-09-26 19:05     ` Janne Grunau
2023-09-26 19:34     ` Robin Murphy
2023-09-26 19:34       ` Robin Murphy
2023-09-26 19:34       ` Robin Murphy
2023-09-26 19:41       ` Robin Murphy
2023-09-26 19:41         ` Robin Murphy
2023-09-26 19:41         ` Robin Murphy
2023-09-27 12:59     ` Jason Gunthorpe
2023-09-27 12:59       ` Jason Gunthorpe
2023-09-27 12:59       ` Jason Gunthorpe
2023-09-22 17:07 ` [PATCH 7/8] iommu/dart: Convert to domain_alloc_paging() Jason Gunthorpe
2023-09-22 17:07   ` Jason Gunthorpe
2023-09-26 19:06   ` Janne Grunau
2023-09-26 19:06     ` Janne Grunau
2023-09-26 19:06     ` Janne Grunau
2023-09-22 17:07 ` [PATCH 8/8] iommu/dart: Call apple_dart_finalize_domain() as part of alloc_paging() Jason Gunthorpe
2023-09-22 17:07   ` Jason Gunthorpe
2023-09-26 19:07   ` Janne Grunau
2023-09-26 19:07     ` Janne Grunau
2023-09-26 19:07     ` Janne Grunau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230925114142.GU13733@nvidia.com \
    --to=jgg@nvidia.com \
    --cc=alyssa@rosenzweig.io \
    --cc=asahi@lists.linux.dev \
    --cc=baolu.lu@linux.intel.com \
    --cc=christophe.leroy@csgroup.eu \
    --cc=dwmw2@infradead.org \
    --cc=iommu@lists.linux.dev \
    --cc=joro@8bytes.org \
    --cc=kevin.tian@intel.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=marcan@marcan.st \
    --cc=mpe@ellerman.id.au \
    --cc=npiggin@gmail.com \
    --cc=robin.murphy@arm.com \
    --cc=sven@svenpeter.dev \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.