Re: [RFC bpf-next v3 07/11] bpf, net: switch to storing struct_ops in btf

[kernel test robot <lkp@intel.com>]

Hi,

[This is a private test report for your RFC patch.]
kernel test robot noticed the following build warnings:

[auto build test WARNING on bpf-next/master]

url:    https://github.com/intel-lab-lkp/linux/commits/thinker-li-gmail-com/bpf-refactory-struct_ops-type-initialization-to-a-function/20230921-000546
base:   https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master
patch link:    https://lore.kernel.org/r/20230920155923.151136-8-thinker.li%40gmail.com
patch subject: [RFC bpf-next v3 07/11] bpf, net: switch to storing struct_ops in btf
config: x86_64-randconfig-016-20230925 (https://download.01.org/0day-ci/archive/20230925/202309251600.fzViZTWK-lkp@intel.com/config)
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230925/202309251600.fzViZTWK-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202309251600.fzViZTWK-lkp@intel.com/

All warnings (new ones prefixed by >>):

   kernel/bpf/bpf_struct_ops.c: In function 'bpf_struct_ops_init':
   kernel/bpf/bpf_struct_ops.c:252:8: error: implicit declaration of function 'register_bpf_struct_ops'; did you mean 'register_net_sysctl_sz'? [-Werror=implicit-function-declaration]
     ret = register_bpf_struct_ops(&bpf_testmod_struct_ops);
           ^~~~~~~~~~~~~~~~~~~~~~~
           register_net_sysctl_sz
   kernel/bpf/bpf_struct_ops.c: At top level:
>> kernel/bpf/bpf_struct_ops.c:258:5: warning: no previous declaration for 'register_bpf_struct_ops' [-Wmissing-declarations]
    int register_bpf_struct_ops(struct bpf_struct_ops_mod *mod)
        ^~~~~~~~~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors


vim +/register_bpf_struct_ops +258 kernel/bpf/bpf_struct_ops.c

   257	
 > 258	int register_bpf_struct_ops(struct bpf_struct_ops_mod *mod)
   259	{
   260		struct bpf_struct_ops *st_ops = mod->st_ops;
   261		struct bpf_verifier_log *log;
   262		struct btf *btf;
   263		int err;
   264	
   265		if (mod->st_ops == NULL ||
   266		    mod->owner == NULL)
   267			return -EINVAL;
   268	
   269		log = kzalloc(sizeof(*log), GFP_KERNEL | __GFP_NOWARN);
   270		if (!log) {
   271			err = -ENOMEM;
   272			goto errout;
   273		}
   274	
   275		log->level = BPF_LOG_KERNEL;
   276	
   277		btf = btf_get_module_btf(mod->owner);
   278		if (!btf) {
   279			err = -EINVAL;
   280			goto errout;
   281		}
   282	
   283		bpf_struct_ops_init_one(st_ops, btf, log);
   284	
   285		btf_put(btf);
   286	
   287		st_ops->owner = mod->owner;
   288		err = btf_add_struct_ops(st_ops, st_ops->owner);
   289	
   290	errout:
   291		kfree(log);
   292	
   293		return err;
   294	}
   295	EXPORT_SYMBOL_GPL(register_bpf_struct_ops);
   296	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki