From: "Michael S. Tsirkin" <mst@redhat.com>
To: Parav Pandit <parav@nvidia.com>
Cc: "Chen, Jiqian" <Jiqian.Chen@amd.com>,
"Jason Wang" <jasowang@redhat.com>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Xuan Zhuo" <xuanzhuo@linux.alibaba.com>,
"David Airlie" <airlied@redhat.com>,
"Gurchetan Singh" <gurchetansingh@chromium.org>,
"Chia-I Wu" <olvaffe@gmail.com>,
"Marc-André Lureau" <marcandre.lureau@gmail.com>,
"Robert Beckett" <bob.beckett@collabora.com>,
"Mikhail Golubev-Ciuchea"
<Mikhail.Golubev-Ciuchea@opensynergy.com>,
"virtio-comment@lists.oasis-open.org"
<virtio-comment@lists.oasis-open.org>,
"virtio-dev@lists.oasis-open.org"
<virtio-dev@lists.oasis-open.org>,
"Stefano Stabellini" <sstabellini@kernel.org>,
"Roger Pau Monné" <roger.pau@citrix.com>,
"Deucher, Alexander" <Alexander.Deucher@amd.com>,
"Koenig, Christian" <Christian.Koenig@amd.com>,
"Hildebrand, Stewart" <Stewart.Hildebrand@amd.com>,
"Xenia Ragiadakou" <burzalodowa@gmail.com>,
"Huang, Honglei1" <Honglei1.Huang@amd.com>,
"Zhang, Julia" <Julia.Zhang@amd.com>,
"Huang, Ray" <Ray.Huang@amd.com>
Subject: [virtio-comment] Re: [virtio-dev] Re: [VIRTIO PCI PATCH v5 1/1] transport-pci: Add freeze_mode to virtio_pci_common_cfg
Date: Tue, 26 Sep 2023 07:57:51 -0400 [thread overview]
Message-ID: <20230926075503-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <PH0PR12MB5481E765DA98E7AD3D1BED15DCC3A@PH0PR12MB5481.namprd12.prod.outlook.com>
On Tue, Sep 26, 2023 at 11:37:37AM +0000, Parav Pandit wrote:
> Hi Jiqian,
>
> > From: Chen, Jiqian <Jiqian.Chen@amd.com>
> > Sent: Tuesday, September 26, 2023 4:30 PM
>
> > It is not to trigger resume behavior to device by setting unfreeze in my scenario.
> > You may misunderstand my intention.
> > In current kernel and qemu code, it will trigger reset device behavior by setting
> > device_status to 0 during resuming, and I found some operations of reset is not
> > reasonable during resuming, like virtio_gpu_reset, it will destroy render
> > resources and then caused the display gone after guest finishing reusming.
>
> When suspend is done, resume must not be done.
> I don’t see a need to mix these operations from guest specially when suspend is done.
>
> Did I miss your response for my suggestion few days ago in [1] for not mixing reset with suspend?
>
> When new feature bit of suspend is offered, guest will _not_ do reset, hence no need to mix reset with suspend.
>
> [1] https://lists.oasis-open.org/archives/virtio-comment/202309/msg00260.html
I frankly don't understand what you proposed there.
reset is a simple operation, it just erases all virtio
state from the device. It is very commonly is performed at
OS/driver startup. Making it not reset some virtio state
is a bad idea since suddenly you kexec a guest
that attempts a reset and device is stuck in some weird state.
--
MST
This publicly archived list offers a means to provide input to the
OASIS Virtual I/O Device (VIRTIO) TC.
In order to verify user consent to the Feedback License terms and
to minimize spam in the list archive, subscription is required
before posting.
Subscribe: virtio-comment-subscribe@lists.oasis-open.org
Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org
List help: virtio-comment-help@lists.oasis-open.org
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Parav Pandit <parav@nvidia.com>
Cc: "Chen, Jiqian" <Jiqian.Chen@amd.com>,
"Jason Wang" <jasowang@redhat.com>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Xuan Zhuo" <xuanzhuo@linux.alibaba.com>,
"David Airlie" <airlied@redhat.com>,
"Gurchetan Singh" <gurchetansingh@chromium.org>,
"Chia-I Wu" <olvaffe@gmail.com>,
"Marc-André Lureau" <marcandre.lureau@gmail.com>,
"Robert Beckett" <bob.beckett@collabora.com>,
"Mikhail Golubev-Ciuchea"
<Mikhail.Golubev-Ciuchea@opensynergy.com>,
"virtio-comment@lists.oasis-open.org"
<virtio-comment@lists.oasis-open.org>,
"virtio-dev@lists.oasis-open.org"
<virtio-dev@lists.oasis-open.org>,
"Stefano Stabellini" <sstabellini@kernel.org>,
"Roger Pau Monné" <roger.pau@citrix.com>,
"Deucher, Alexander" <Alexander.Deucher@amd.com>,
"Koenig, Christian" <Christian.Koenig@amd.com>,
"Hildebrand, Stewart" <Stewart.Hildebrand@amd.com>,
"Xenia Ragiadakou" <burzalodowa@gmail.com>,
"Huang, Honglei1" <Honglei1.Huang@amd.com>,
"Zhang, Julia" <Julia.Zhang@amd.com>,
"Huang, Ray" <Ray.Huang@amd.com>
Subject: Re: [virtio-dev] Re: [VIRTIO PCI PATCH v5 1/1] transport-pci: Add freeze_mode to virtio_pci_common_cfg
Date: Tue, 26 Sep 2023 07:57:51 -0400 [thread overview]
Message-ID: <20230926075503-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <PH0PR12MB5481E765DA98E7AD3D1BED15DCC3A@PH0PR12MB5481.namprd12.prod.outlook.com>
On Tue, Sep 26, 2023 at 11:37:37AM +0000, Parav Pandit wrote:
> Hi Jiqian,
>
> > From: Chen, Jiqian <Jiqian.Chen@amd.com>
> > Sent: Tuesday, September 26, 2023 4:30 PM
>
> > It is not to trigger resume behavior to device by setting unfreeze in my scenario.
> > You may misunderstand my intention.
> > In current kernel and qemu code, it will trigger reset device behavior by setting
> > device_status to 0 during resuming, and I found some operations of reset is not
> > reasonable during resuming, like virtio_gpu_reset, it will destroy render
> > resources and then caused the display gone after guest finishing reusming.
>
> When suspend is done, resume must not be done.
> I don’t see a need to mix these operations from guest specially when suspend is done.
>
> Did I miss your response for my suggestion few days ago in [1] for not mixing reset with suspend?
>
> When new feature bit of suspend is offered, guest will _not_ do reset, hence no need to mix reset with suspend.
>
> [1] https://lists.oasis-open.org/archives/virtio-comment/202309/msg00260.html
I frankly don't understand what you proposed there.
reset is a simple operation, it just erases all virtio
state from the device. It is very commonly is performed at
OS/driver startup. Making it not reset some virtio state
is a bad idea since suddenly you kexec a guest
that attempts a reset and device is stuck in some weird state.
--
MST
---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
next prev parent reply other threads:[~2023-09-26 11:58 UTC|newest]
Thread overview: 103+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-19 11:42 [virtio-comment] [VIRTIO PCI PATCH v5 0/1] Add freeze_mode to virtio_pci_common_cfg Jiqian Chen
2023-09-19 11:42 ` Jiqian Chen
2023-09-19 11:42 ` [virtio-dev] " Jiqian Chen
2023-09-19 11:42 ` [virtio-comment] [VIRTIO PCI PATCH v5 1/1] transport-pci: " Jiqian Chen
2023-09-19 11:42 ` Jiqian Chen
2023-09-19 11:42 ` [virtio-dev] " Jiqian Chen
2023-09-19 12:10 ` [virtio-comment] " Parav Pandit
2023-09-19 12:10 ` Parav Pandit
2023-09-19 12:10 ` [virtio-dev] " Parav Pandit
2023-09-19 14:09 ` [virtio-comment] " Michael S. Tsirkin
2023-09-19 14:09 ` Michael S. Tsirkin
2023-09-19 14:09 ` [virtio-dev] " Michael S. Tsirkin
2023-09-20 3:57 ` [virtio-comment] Re: [virtio-dev] " Chen, Jiqian
2023-09-20 3:57 ` Chen, Jiqian
2023-09-20 4:10 ` [virtio-comment] " Parav Pandit
2023-09-20 4:10 ` Parav Pandit
2023-09-19 12:31 ` [virtio-comment] " Michael S. Tsirkin
2023-09-19 12:31 ` Michael S. Tsirkin
2023-09-19 12:31 ` [virtio-dev] " Michael S. Tsirkin
2023-09-20 4:56 ` [virtio-comment] " Chen, Jiqian
2023-09-20 4:56 ` Chen, Jiqian
2023-09-20 4:56 ` [virtio-dev] " Chen, Jiqian
2023-09-20 5:59 ` [virtio-comment] " Zhu, Lingshan
2023-09-20 5:59 ` Zhu, Lingshan
2023-09-20 5:59 ` [virtio-dev] " Zhu, Lingshan
2023-09-20 6:33 ` [virtio-comment] " Chen, Jiqian
2023-09-20 6:33 ` Chen, Jiqian
2023-09-20 6:58 ` [virtio-comment] " Parav Pandit
2023-09-20 6:58 ` Parav Pandit
2023-09-20 7:06 ` [virtio-comment] " Zhu, Lingshan
2023-09-20 7:06 ` Zhu, Lingshan
2023-09-20 7:06 ` Zhu, Lingshan
2023-09-20 7:10 ` [virtio-comment] " Parav Pandit
2023-09-20 7:10 ` Parav Pandit
2023-09-20 7:27 ` [virtio-comment] " Zhu, Lingshan
2023-09-20 7:27 ` Zhu, Lingshan
2023-09-20 7:27 ` Zhu, Lingshan
2023-09-20 7:32 ` [virtio-comment] " Parav Pandit
2023-09-20 7:32 ` Parav Pandit
2023-09-20 7:45 ` [virtio-comment] " Zhu, Lingshan
2023-09-20 7:45 ` Zhu, Lingshan
2023-09-20 7:45 ` Zhu, Lingshan
2023-09-20 7:47 ` [virtio-comment] " Parav Pandit
2023-09-20 7:47 ` Parav Pandit
2023-09-20 7:24 ` [virtio-comment] " Chen, Jiqian
2023-09-20 7:24 ` Chen, Jiqian
2023-09-20 7:30 ` [virtio-comment] " Zhu, Lingshan
2023-09-20 7:30 ` Zhu, Lingshan
2023-09-20 7:30 ` Zhu, Lingshan
2023-09-20 7:35 ` [virtio-comment] " Parav Pandit
2023-09-20 7:35 ` Parav Pandit
2023-09-20 7:47 ` [virtio-comment] " Zhu, Lingshan
2023-09-20 7:47 ` Zhu, Lingshan
2023-09-20 7:47 ` Zhu, Lingshan
2023-09-20 7:51 ` [virtio-comment] " Parav Pandit
2023-09-20 7:51 ` Parav Pandit
2023-09-20 7:55 ` [virtio-comment] " Zhu, Lingshan
2023-09-20 7:55 ` Zhu, Lingshan
2023-09-20 7:55 ` Zhu, Lingshan
2023-09-20 7:53 ` [virtio-comment] " Chen, Jiqian
2023-09-20 7:53 ` Chen, Jiqian
2023-09-20 7:56 ` [virtio-comment] " Parav Pandit
2023-09-20 7:56 ` Parav Pandit
2023-09-20 8:18 ` [virtio-comment] " Chen, Jiqian
2023-09-20 8:18 ` [virtio-dev] " Chen, Jiqian
2023-09-20 6:58 ` [virtio-comment] " Zhu, Lingshan
2023-09-20 6:58 ` Zhu, Lingshan
2023-09-20 6:58 ` Zhu, Lingshan
2023-09-20 7:17 ` [virtio-comment] " Chen, Jiqian
2023-09-20 7:17 ` [virtio-dev] " Chen, Jiqian
2023-09-20 7:42 ` Zhu, Lingshan
2023-09-20 7:42 ` Zhu, Lingshan
2023-09-20 7:42 ` [virtio-dev] " Zhu, Lingshan
2023-09-21 4:22 ` Jason Wang
2023-09-21 4:22 ` Jason Wang
2023-09-21 4:22 ` [virtio-dev] " Jason Wang
2023-09-21 6:28 ` [virtio-comment] " Chen, Jiqian
2023-09-21 6:28 ` Chen, Jiqian
2023-09-22 3:17 ` [virtio-comment] " Jason Wang
2023-09-22 3:17 ` Jason Wang
2023-09-22 3:17 ` Jason Wang
2023-09-22 8:07 ` [virtio-comment] " Chen, Jiqian
2023-09-22 8:07 ` Chen, Jiqian
2023-09-25 2:52 ` [virtio-comment] " Jason Wang
2023-09-25 2:52 ` Jason Wang
2023-09-26 2:23 ` [virtio-comment] " Chen, Jiqian
2023-09-26 2:23 ` Chen, Jiqian
2023-09-26 2:51 ` [virtio-comment] " Jason Wang
2023-09-26 2:51 ` Jason Wang
2023-09-26 11:00 ` [virtio-comment] " Chen, Jiqian
2023-09-26 11:00 ` Chen, Jiqian
2023-09-26 11:09 ` [virtio-comment] " Michael S. Tsirkin
2023-09-26 11:09 ` Michael S. Tsirkin
2023-09-27 9:00 ` [virtio-comment] " Chen, Jiqian
2023-09-27 9:00 ` Chen, Jiqian
2023-09-26 11:37 ` [virtio-comment] " Parav Pandit
2023-09-26 11:37 ` Parav Pandit
2023-09-26 11:57 ` Michael S. Tsirkin [this message]
2023-09-26 11:57 ` Michael S. Tsirkin
2023-09-27 10:18 ` [virtio-comment] " Parav Pandit
2023-09-27 10:18 ` Parav Pandit
2023-09-27 9:19 ` [virtio-comment] " Chen, Jiqian
2023-09-27 9:19 ` Chen, Jiqian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230926075503-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=Alexander.Deucher@amd.com \
--cc=Christian.Koenig@amd.com \
--cc=Honglei1.Huang@amd.com \
--cc=Jiqian.Chen@amd.com \
--cc=Julia.Zhang@amd.com \
--cc=Mikhail.Golubev-Ciuchea@opensynergy.com \
--cc=Ray.Huang@amd.com \
--cc=Stewart.Hildebrand@amd.com \
--cc=airlied@redhat.com \
--cc=bob.beckett@collabora.com \
--cc=burzalodowa@gmail.com \
--cc=gurchetansingh@chromium.org \
--cc=jasowang@redhat.com \
--cc=kraxel@redhat.com \
--cc=marcandre.lureau@gmail.com \
--cc=olvaffe@gmail.com \
--cc=parav@nvidia.com \
--cc=roger.pau@citrix.com \
--cc=sstabellini@kernel.org \
--cc=virtio-comment@lists.oasis-open.org \
--cc=virtio-dev@lists.oasis-open.org \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.