All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Conor Dooley <conor@kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>
Cc: Peter Denison <openwrt@marshadder.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Linus Walleij <linusw@kernel.org>,
	Krzysztof Halasa <khalasa@piap.pl>,
	Imre Kaloz <kaloz@openwrt.org>, Ted Hess <thess@kitschensync.net>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 2/2] dt-bindings: arm: List more IXP4xx devices
Date: Tue, 26 Sep 2023 08:13:02 -0500	[thread overview]
Message-ID: <20230926131302.GA3753440-robh@kernel.org> (raw)
In-Reply-To: <20230926-hunger-naturist-634fe7727c3c@spud>

On Tue, Sep 26, 2023 at 11:20:01AM +0100, Conor Dooley wrote:
> On Tue, Sep 26, 2023 at 11:04:26AM +0200, Linus Walleij wrote:
> > On Tue, Sep 26, 2023 at 10:26 AM Conor Dooley <conor@kernel.org> wrote:
> > 
> > > > +      - items:
> > > > +          - const: linksys,wrv54g
> > > > +          - const: gemtek,gtwx5715
> > > > +          - const: intel,ixp42x
> > >
> > > One question, not so much about this particular case, but is there no
> > > "standalone" version of the gtwx5715 sold by gemtek? Asking as I don't
> > > see it in the enum above. The description sounds like it is both a
> > > product in its own right & sold rebadged.
> > 
> > Yeah this one is a special headache. It's two different brandings
> > of the same router. The Linksys version can still be bought new
> > from Amazon:
> > https://www.amazon.com/Cisco-Linksys-WRV54G-Wireless-G-VPN-Router/dp/B0000AR8Z1
> > 
> > I'm leaning toward listing them as two different devices instead
> > of what we have now, which is
> > 
> >   compatible = "linksys,wrv54g", "gemtek,gtwx5715", "intel,ixp42x";
> > 
> > We can just decide that one of them is the canon device, I guess
> > Linksys, and the other we can just use that device tree, or we
> > create a device tree that includes the former and just override
> > the compatible.
> > 
> > I don't really know what to do here.
> 
> Ahh, you were intentionally doing this so that for both devices you
> would list all 3 compatibles? I had it in my head that the OEM device
> would have 2 compatibles & the rebadged one would have 3.
> I'd probably be slightly in favour of your second option, since you'd
> likely want to set the model too. I suppose it's the decision of the
> maintainer for the platforms, which IIRC is you, as given the devices
> differ only by the badge...

I would do a combination. Use the same compatible, but different "model" 
if you want to override it.

Rob

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Conor Dooley <conor@kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>
Cc: Peter Denison <openwrt@marshadder.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Linus Walleij <linusw@kernel.org>,
	Krzysztof Halasa <khalasa@piap.pl>,
	Imre Kaloz <kaloz@openwrt.org>, Ted Hess <thess@kitschensync.net>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 2/2] dt-bindings: arm: List more IXP4xx devices
Date: Tue, 26 Sep 2023 08:13:02 -0500	[thread overview]
Message-ID: <20230926131302.GA3753440-robh@kernel.org> (raw)
In-Reply-To: <20230926-hunger-naturist-634fe7727c3c@spud>

On Tue, Sep 26, 2023 at 11:20:01AM +0100, Conor Dooley wrote:
> On Tue, Sep 26, 2023 at 11:04:26AM +0200, Linus Walleij wrote:
> > On Tue, Sep 26, 2023 at 10:26 AM Conor Dooley <conor@kernel.org> wrote:
> > 
> > > > +      - items:
> > > > +          - const: linksys,wrv54g
> > > > +          - const: gemtek,gtwx5715
> > > > +          - const: intel,ixp42x
> > >
> > > One question, not so much about this particular case, but is there no
> > > "standalone" version of the gtwx5715 sold by gemtek? Asking as I don't
> > > see it in the enum above. The description sounds like it is both a
> > > product in its own right & sold rebadged.
> > 
> > Yeah this one is a special headache. It's two different brandings
> > of the same router. The Linksys version can still be bought new
> > from Amazon:
> > https://www.amazon.com/Cisco-Linksys-WRV54G-Wireless-G-VPN-Router/dp/B0000AR8Z1
> > 
> > I'm leaning toward listing them as two different devices instead
> > of what we have now, which is
> > 
> >   compatible = "linksys,wrv54g", "gemtek,gtwx5715", "intel,ixp42x";
> > 
> > We can just decide that one of them is the canon device, I guess
> > Linksys, and the other we can just use that device tree, or we
> > create a device tree that includes the former and just override
> > the compatible.
> > 
> > I don't really know what to do here.
> 
> Ahh, you were intentionally doing this so that for both devices you
> would list all 3 compatibles? I had it in my head that the OEM device
> would have 2 compatibles & the rebadged one would have 3.
> I'd probably be slightly in favour of your second option, since you'd
> likely want to set the model too. I suppose it's the decision of the
> maintainer for the platforms, which IIRC is you, as given the devices
> differ only by the badge...

I would do a combination. Use the same compatible, but different "model" 
if you want to override it.

Rob

  reply	other threads:[~2023-09-26 13:13 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-25  9:03 [PATCH v2 0/2] Device tree updates for IXP4xx Linus Walleij
2023-09-25  9:03 ` Linus Walleij
2023-09-25  9:03 ` [PATCH v2 1/2] dt-bindings: Add vendor prefixes Linus Walleij
2023-09-25  9:03   ` Linus Walleij
2023-09-26  8:23   ` Conor Dooley
2023-09-26  8:23     ` Conor Dooley
2023-09-25  9:03 ` [PATCH v2 2/2] dt-bindings: arm: List more IXP4xx devices Linus Walleij
2023-09-25  9:03   ` Linus Walleij
2023-09-26  8:25   ` Conor Dooley
2023-09-26  8:25     ` Conor Dooley
2023-09-26  9:04     ` Linus Walleij
2023-09-26  9:04       ` Linus Walleij
2023-09-26 10:20       ` Conor Dooley
2023-09-26 10:20         ` Conor Dooley
2023-09-26 13:13         ` Rob Herring [this message]
2023-09-26 13:13           ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230926131302.GA3753440-robh@kernel.org \
    --to=robh@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=conor@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=kaloz@openwrt.org \
    --cc=khalasa@piap.pl \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linusw@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=openwrt@marshadder.org \
    --cc=thess@kitschensync.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.