All of lore.kernel.org
 help / color / mirror / Atom feed
From: Halil Pasic <pasic@linux.ibm.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: "Gonglei (Arei)" <arei.gonglei@huawei.com>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
	Marc Hartmayer <mhartmay@linux.ibm.com>,
	Jason Wang <jasowang@redhat.com>,
	"virtualization@lists.linux-foundation.org" 
	<virtualization@lists.linux-foundation.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"pizhenwei@bytedance.com" <pizhenwei@bytedance.com>,
	Cornelia Huck <cohuck@redhat.com>,
	Halil Pasic <pasic@linux.ibm.com>
Subject: Re: [PATCH] crypto: virtio-crypto: call finalize with bh disabled
Date: Wed, 27 Sep 2023 11:36:12 +0200	[thread overview]
Message-ID: <20230927113612.3c46c20c.pasic@linux.ibm.com> (raw)
In-Reply-To: <20230926130521-mutt-send-email-mst@kernel.org>

On Tue, 26 Sep 2023 13:13:51 -0400
"Michael S. Tsirkin" <mst@redhat.com> wrote:

> > On the other hand virtio_airq_handler() calls vring_interrupt() with
> > interrupts enabled. (While vring_interrupt() is called in a (read)
> > critical section in virtio_airq_handler() we use read_lock() and
> > not read_lock_irqsave() to grab the lock. Whether that is correct in
> > it self (i.e. disregarding the crypto problem) or not I'm not sure right
> > now. Will think some more about it tomorrow.) If the way to go forward
> > is disabling interrupts in virtio-ccw before vring_interrupt() is
> > called, I would be glad to spin a patch for that.
> > 
> > Copying Conny, as she may have an opinion on this (if I'm not wrong she
> > authored that code).
> > 
> > Regards,
> > Halil  
> 
> On a related note, config change callback is also handled incorrectly
> in this driver, it takes a mutex from interrupt context.

Thanks Michael! I intend to give Connie a little more time to chime in.
Assumed no controversies emerge I intend  to cook up two patches for
the two issues later during the day.

Regards,
Halil

WARNING: multiple messages have this Message-ID (diff)
From: Halil Pasic <pasic@linux.ibm.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
	Cornelia Huck <cohuck@redhat.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"pizhenwei@bytedance.com" <pizhenwei@bytedance.com>,
	"virtualization@lists.linux-foundation.org"
	<virtualization@lists.linux-foundation.org>,
	Halil Pasic <pasic@linux.ibm.com>,
	Marc Hartmayer <mhartmay@linux.ibm.com>,
	"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>
Subject: Re: [PATCH] crypto: virtio-crypto: call finalize with bh disabled
Date: Wed, 27 Sep 2023 11:36:12 +0200	[thread overview]
Message-ID: <20230927113612.3c46c20c.pasic@linux.ibm.com> (raw)
In-Reply-To: <20230926130521-mutt-send-email-mst@kernel.org>

On Tue, 26 Sep 2023 13:13:51 -0400
"Michael S. Tsirkin" <mst@redhat.com> wrote:

> > On the other hand virtio_airq_handler() calls vring_interrupt() with
> > interrupts enabled. (While vring_interrupt() is called in a (read)
> > critical section in virtio_airq_handler() we use read_lock() and
> > not read_lock_irqsave() to grab the lock. Whether that is correct in
> > it self (i.e. disregarding the crypto problem) or not I'm not sure right
> > now. Will think some more about it tomorrow.) If the way to go forward
> > is disabling interrupts in virtio-ccw before vring_interrupt() is
> > called, I would be glad to spin a patch for that.
> > 
> > Copying Conny, as she may have an opinion on this (if I'm not wrong she
> > authored that code).
> > 
> > Regards,
> > Halil  
> 
> On a related note, config change callback is also handled incorrectly
> in this driver, it takes a mutex from interrupt context.

Thanks Michael! I intend to give Connie a little more time to chime in.
Assumed no controversies emerge I intend  to cook up two patches for
the two issues later during the day.

Regards,
Halil
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

  parent reply	other threads:[~2023-09-27  9:38 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-25 15:07 [PATCH] crypto: virtio-crypto: call finalize with bh disabled Gonglei (Arei)
2023-09-25 15:07 ` Gonglei (Arei) via Virtualization
2023-09-26 16:41 ` Halil Pasic
2023-09-26 16:41   ` Halil Pasic
2023-09-26 17:13   ` Michael S. Tsirkin
2023-09-26 17:13     ` Michael S. Tsirkin
2023-09-27  9:24     ` Gonglei (Arei)
2023-09-27  9:24       ` Gonglei (Arei) via Virtualization
2023-09-27 13:25       ` Halil Pasic
2023-09-27 13:25         ` Halil Pasic
2023-09-28  1:24         ` zhenwei pi
2023-09-28  1:24           ` zhenwei pi via Virtualization
2023-09-28  2:03           ` Gonglei (Arei)
2023-09-28  2:03             ` Gonglei (Arei) via Virtualization
2023-09-27  9:36     ` Halil Pasic [this message]
2023-09-27  9:36       ` Halil Pasic
2023-09-27  9:17   ` Gonglei (Arei)
2023-09-27  9:17     ` Gonglei (Arei) via Virtualization
2023-09-27 10:08   ` Cornelia Huck
2023-09-27 10:08     ` Cornelia Huck
2023-09-27 11:25     ` Halil Pasic
2023-09-27 11:25       ` Halil Pasic
2023-09-27 12:12       ` Cornelia Huck
2023-09-27 12:12         ` Cornelia Huck
2023-09-27 13:11         ` Halil Pasic
2023-09-27 13:11           ` Halil Pasic
2023-09-27 17:11   ` Halil Pasic
2023-09-27 17:11     ` Halil Pasic
2023-11-02 13:01   ` Gonglei (Arei)
2023-11-02 13:01     ` Gonglei (Arei) via Virtualization
2023-11-06 10:08     ` Herbert Xu
2023-11-06 10:08       ` Herbert Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230927113612.3c46c20c.pasic@linux.ibm.com \
    --to=pasic@linux.ibm.com \
    --cc=arei.gonglei@huawei.com \
    --cc=cohuck@redhat.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=jasowang@redhat.com \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mhartmay@linux.ibm.com \
    --cc=mst@redhat.com \
    --cc=pizhenwei@bytedance.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.