All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mariusz Tkaczyk <mariusz.tkaczyk@linux.intel.com>
To: Xiao Ni <xni@redhat.com>
Cc: jes@trained-monkey.org, linux-raid@vger.kernel.org
Subject: Re: [PATCH 1/4 v2] mdadm/tests: Fix regular expression failure
Date: Thu, 28 Sep 2023 11:24:48 +0200	[thread overview]
Message-ID: <20230928112448.000010f6@linux.intel.com> (raw)
In-Reply-To: <20230927025219.49915-2-xni@redhat.com>

On Wed, 27 Sep 2023 10:52:16 +0800
Xiao Ni <xni@redhat.com> wrote:

> The test fails because of the regular expression.
> 
> Signed-off-by: Xiao Ni <xni@redhat.com>
> ---
>  tests/06name | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/06name b/tests/06name
> index 4d5e824d3e0e..86eaab69e3a1 100644
> --- a/tests/06name
> +++ b/tests/06name
> @@ -3,8 +3,8 @@ set -x
>  # create an array with a name
>  
>  mdadm -CR $md0 -l0 -n2 --metadata=1 --name="Fred" $dev0 $dev1
> -mdadm -E $dev0 | grep 'Name : [^:]*:Fred ' > /dev/null || exit 1
> -mdadm -D $md0 | grep 'Name : [^:]*:Fred ' > /dev/null || exit 1
> +mdadm -E $dev0 | grep 'Name : Fred' > /dev/null || exit 1
> +mdadm -D $md0 | grep 'Name : Fred' > /dev/null || exit 1
>  mdadm -S $md0
>  
>  mdadm -A $md0 --name="Fred" $devlist

Hello Xiao,
I can see that it is not sent first time. Previous version was moved by me to
the "awaiting_upstream" state on patchwork but I forgot to answer.
You don't need to send it again. I'm ignoring this one. Anyway, here my
approval:

Reviewed-by: Mariusz Tkaczyk <mariusz.tkaczyk@linux.intel.com>

https://patchwork.kernel.org/project/linux-raid/patch/20230907085744.18967-1-xni@redhat.com/

Thanks,
Mariusz

  reply	other threads:[~2023-09-28  9:25 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-27  2:52 [PATCH 0/4] mdadm: Fix some errors for regression tests and building Xiao Ni
2023-09-27  2:52 ` [PATCH 1/4 v2] mdadm/tests: Fix regular expression failure Xiao Ni
2023-09-28  9:24   ` Mariusz Tkaczyk [this message]
2023-10-07 13:35     ` Xiao Ni
2023-10-26 21:39       ` Jes Sorensen
2023-09-27  2:52 ` [PATCH 2/4 v2] mdadm/tests: Don't run mknod before losetup Xiao Ni
2023-09-28  9:27   ` Mariusz Tkaczyk
2023-10-26 21:44     ` Jes Sorensen
2023-09-27  2:52 ` [PATCH 3/4] mdadm: Avoid array bounds check of gcc Xiao Ni
2023-09-27  4:29   ` Paul Menzel
2023-09-27  5:06     ` Xiao Ni
2023-09-28  9:41   ` Mariusz Tkaczyk
2023-10-07 13:26     ` Xiao Ni
2023-10-09  7:59       ` Mariusz Tkaczyk
2023-09-27  2:52 ` [PATCH 4/4] mdadm: Print version to stdout Xiao Ni
2023-09-28  9:53   ` Mariusz Tkaczyk
2023-10-07 12:58     ` Xiao Ni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230928112448.000010f6@linux.intel.com \
    --to=mariusz.tkaczyk@linux.intel.com \
    --cc=jes@trained-monkey.org \
    --cc=linux-raid@vger.kernel.org \
    --cc=xni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.