Re: [PATCH 2/4 v2] mdadm/tests: Don't run mknod before losetup

[Mariusz Tkaczyk <mariusz.tkaczyk@linux.intel.com>]

On Wed, 27 Sep 2023 10:52:17 +0800
Xiao Ni <xni@redhat.com> wrote:

> Sometimes it can fail:
> losetup: /var/tmp/mdtest0: failed to set up loop device: No such device or
> address /dev/loop0 and /var/tmp/mdtest0 are already created before losetup.
> 
> Because losetup can create device node by itself. So remove mknod.
> 
> Signed-off-by: Xiao Ni <xni@redhat.com>
> ---
>  tests/func.sh | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/tests/func.sh b/tests/func.sh
> index 9710a53b8a73..5053b0121f1d 100644
> --- a/tests/func.sh
> +++ b/tests/func.sh
> @@ -170,7 +170,6 @@ do_setup() {
>  				dd if=/dev/zero of=$targetdir/mdtest$d
> count=$sz bs=1K > /dev/null 2>&1 # make sure udev doesn't touch
>  			mdadm --zero $targetdir/mdtest$d 2> /dev/null
> -			[ -b /dev/loop$d ] || mknod /dev/loop$d b 7 $d
>  			if [ $d -eq 7 ]
>  			then
>  				losetup /dev/loop$d $targetdir/mdtest6 # for
> multipath use

Hello,
Same as in previous case, it is waiting for Jes:
https://patchwork.kernel.org/project/linux-raid/patch/20230908084435.30674-1-xni@redhat.com/

I'm ignoring this one.
Reviewed-by: Mariusz Tkaczyk <mariusz.tkaczyk@linux.intel.com>

Thanks,
Mariusz