From: Florian Eckert <fe@dev.tdt.de>
To: Eckert.Florian@googlemail.com, gregkh@linuxfoundation.org,
jirislaby@kernel.org, pavel@ucw.cz, lee@kernel.org,
kabel@kernel.org, u.kleine-koenig@pengutronix.de
Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
linux-leds@vger.kernel.org
Subject: [PATCH v2 0/4] ledtrig-tty: add new state evaluation
Date: Thu, 28 Sep 2023 15:26:28 +0200 [thread overview]
Message-ID: <20230928132632.200263-1-fe@dev.tdt.de> (raw)
Changes in v2:
- rename new function from tty_get_mget() to tty_get_tiocm() as
requested by 'Jiri Slaby'.
- As suggested by 'Jiri Slaby', fixed tabs in function documentation
throughout the file '/drivers/tty/tty_io.c' in a separate commit.
- Move the variable definition to the top in function 'ledtrig_tty_work()'.
This was reported by the 'kernel test robot' after my change in v1.
- Also set the 'max_brightness' to 'blink_brightness' if no
'blink_brightness' was set. This fixes a problem at startup when the
brightness is still set to 0 and only 'line_*' is evaluated. I looked in
the netdev trigger and that's exactly how it's done there.
v1:
This is a follow-up patchset, based on the mailing list discussion from
March 2023 based on the old patchset v7 [1]. I have changed, the LED trigger
handling via the sysfs interfaces as suggested by Uwe Kleine-König.
[1]
https://lore.kernel.org/linux-leds/20230306093524.amm7o4ppa7gon4ew@pengutronix.de/
Florian Eckert (4):
tty: whitespaces in descriptions corrected by replacing tabs with
spaces.
tty: add new helper function tty_get_tiocm
trigger: ledtrig-tty: move variable definition to the top
trigger: ledtrig-tty: add new line mode to triggers
.../ABI/testing/sysfs-class-led-trigger-tty | 53 ++++
drivers/leds/trigger/ledtrig-tty.c | 280 +++++++++++++++++-
drivers/tty/tty_io.c | 130 ++++----
include/linux/tty.h | 1 +
4 files changed, 396 insertions(+), 68 deletions(-)
--
2.30.2
next reply other threads:[~2023-09-28 13:26 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-28 13:26 Florian Eckert [this message]
2023-09-28 13:26 ` [PATCH v2 1/4] tty: whitespaces in descriptions corrected by replacing tabs with spaces Florian Eckert
2023-10-02 9:21 ` Jiri Slaby
2023-09-28 13:26 ` [PATCH v2 2/4] tty: add new helper function tty_get_tiocm Florian Eckert
2023-09-28 13:26 ` [PATCH v2 3/4] trigger: ledtrig-tty: move variable definition to the top Florian Eckert
2023-10-02 10:26 ` Jiri Slaby
2023-10-02 14:05 ` Lee Jones
2023-10-03 5:00 ` Jiri Slaby
2023-10-04 6:37 ` Florian Eckert
2023-10-04 8:23 ` Jiri Slaby
2023-10-04 8:36 ` Florian Eckert
2023-10-04 8:43 ` Jiri Slaby
2023-10-05 7:38 ` Greg KH
2023-10-05 10:13 ` Lee Jones
2023-10-05 10:40 ` Greg KH
2023-10-05 10:41 ` Lee Jones
2023-10-11 6:58 ` Florian Eckert
2023-10-12 9:21 ` Lee Jones
2023-09-28 13:26 ` [PATCH v2 4/4] trigger: ledtrig-tty: add new line mode to triggers Florian Eckert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230928132632.200263-1-fe@dev.tdt.de \
--to=fe@dev.tdt.de \
--cc=Eckert.Florian@googlemail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=kabel@kernel.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.