From: Lee Jones <lee@kernel.org>
To: Florian Eckert <fe@dev.tdt.de>
Cc: Eckert.Florian@googlemail.com, gregkh@linuxfoundation.org,
jirislaby@kernel.org, pavel@ucw.cz, kabel@kernel.org,
u.kleine-koenig@pengutronix.de, linux-kernel@vger.kernel.org,
linux-serial@vger.kernel.org, linux-leds@vger.kernel.org,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH v2 3/4] trigger: ledtrig-tty: move variable definition to the top
Date: Thu, 12 Oct 2023 10:21:07 +0100 [thread overview]
Message-ID: <20231012092107.GE8314@google.com> (raw)
In-Reply-To: <66ca9e2231629a72e098e1b17736ca34@dev.tdt.de>
On Wed, 11 Oct 2023, Florian Eckert wrote:
> Hello Lee,
>
> I only got reviews for the fixes and preparations for commits that change
> the
> tty subsystem, but no reaction from the maintainer of the feature I want to
> add to ledtrig-tty for v1 and v2 patchset.
>
> How should I proceed? Send a v3 with the the requested changes.
>
> [Patch v2 1/4]: https://lore.kernel.org/linux-leds/20230928132632.200263-1-fe@dev.tdt.de/T/#m913d3822465f35b54dfa24b1dfe4d50e61352980
> Change got a 'Reviewed-by: Jiri Slaby <jirislaby@kernel.org>'.
> Will add this to an upcoming v3 again.
>
> [Patch v2 2/4] : https://lore.kernel.org/linux-leds/20230928132632.200263-1-fe@dev.tdt.de/T/#m7ee7618894a66fd3c89bed488a2394265a3f8df1
> I missed to add the robot error message to the commit message and also
> missed
> to add the the following 'Reported-by: kernel test robot <lkp@intel.com>'
> and
> 'Closes:
> https://lore.kernel.org/oe-kbuild-all/202309270440.IJB24Xap-lkp@intel.com/'
> to the commit message. Will add this to an upcoming v3.
>
> And do not wait for the review of the following patches.
> https://lore.kernel.org/linux-leds/20230928132632.200263-1-fe@dev.tdt.de/T/#mc0ecb912fa0e59015ad0a9b4cb491ae9f18c1ea9
> https://lore.kernel.org/linux-leds/20230928132632.200263-1-fe@dev.tdt.de/T/#mba36217323c386ecd900e188bbdf6276c3c96c91
Yes. I've removed this from my queue.
Better to resend it with the fixes.
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2023-10-12 9:21 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-28 13:26 [PATCH v2 0/4] ledtrig-tty: add new state evaluation Florian Eckert
2023-09-28 13:26 ` [PATCH v2 1/4] tty: whitespaces in descriptions corrected by replacing tabs with spaces Florian Eckert
2023-10-02 9:21 ` Jiri Slaby
2023-09-28 13:26 ` [PATCH v2 2/4] tty: add new helper function tty_get_tiocm Florian Eckert
2023-09-28 13:26 ` [PATCH v2 3/4] trigger: ledtrig-tty: move variable definition to the top Florian Eckert
2023-10-02 10:26 ` Jiri Slaby
2023-10-02 14:05 ` Lee Jones
2023-10-03 5:00 ` Jiri Slaby
2023-10-04 6:37 ` Florian Eckert
2023-10-04 8:23 ` Jiri Slaby
2023-10-04 8:36 ` Florian Eckert
2023-10-04 8:43 ` Jiri Slaby
2023-10-05 7:38 ` Greg KH
2023-10-05 10:13 ` Lee Jones
2023-10-05 10:40 ` Greg KH
2023-10-05 10:41 ` Lee Jones
2023-10-11 6:58 ` Florian Eckert
2023-10-12 9:21 ` Lee Jones [this message]
2023-09-28 13:26 ` [PATCH v2 4/4] trigger: ledtrig-tty: add new line mode to triggers Florian Eckert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231012092107.GE8314@google.com \
--to=lee@kernel.org \
--cc=Eckert.Florian@googlemail.com \
--cc=fe@dev.tdt.de \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=kabel@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=lkp@intel.com \
--cc=pavel@ucw.cz \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.