Re: [RFC PATCH v2 2/9] ACPI: APEI: Use common ERST struct to read/write serialized MCE record

[kernel test robot <lkp@intel.com>]

Hi Shuai,

[This is a private test report for your RFC patch.]
kernel test robot noticed the following build warnings:

[auto build test WARNING on kees/for-next/pstore]
[also build test WARNING on kees/for-next/kspp rafael-pm/linux-next tip/x86/core efi/next linus/master v6.6-rc3 next-20230928]
[cannot apply to aegl/next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Shuai-Xue/pstore-move-pstore-creator-id-section-type-and-record-struct-to-common-header/20230925-154609
base:   https://git.kernel.org/pub/scm/linux/kernel/git/kees/linux.git for-next/pstore
patch link:    https://lore.kernel.org/r/20230925074426.97856-3-xueshuai%40linux.alibaba.com
patch subject: [RFC PATCH v2 2/9] ACPI: APEI: Use common ERST struct to read/write serialized MCE record
config: x86_64-buildonly-randconfig-004-20230929 (https://download.01.org/0day-ci/archive/20230929/202309291243.U75V4UPI-lkp@intel.com/config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230929/202309291243.U75V4UPI-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202309291243.U75V4UPI-lkp@intel.com/

All warnings (new ones prefixed by >>):

   arch/x86/kernel/cpu/mce/apei.c: In function 'apei_read_mce':
>> arch/x86/kernel/cpu/mce/apei.c:187:2: warning: 'memcpy' forming offset [201, 328] is out of the bounds [0, 200] of object 'rcd' with type 'struct cper_pstore_record' [-Warray-bounds]
     187 |  memcpy(m, &rcd.data, sizeof(*m));
         |  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   arch/x86/kernel/cpu/mce/apei.c:166:28: note: 'rcd' declared here
     166 |  struct cper_pstore_record rcd;
         |                            ^~~


vim +187 arch/x86/kernel/cpu/mce/apei.c

   163	
   164	ssize_t apei_read_mce(struct mce *m, u64 *record_id)
   165	{
   166		struct cper_pstore_record rcd;
   167		int rc, pos;
   168	
   169		rc = erst_get_record_id_begin(&pos);
   170		if (rc)
   171			return rc;
   172	retry:
   173		rc = erst_get_record_id_next(&pos, record_id);
   174		if (rc)
   175			goto out;
   176		/* no more record */
   177		if (*record_id == APEI_ERST_INVALID_RECORD_ID)
   178			goto out;
   179		rc = erst_read_record(*record_id, &rcd.hdr, sizeof(rcd), sizeof(rcd),
   180				&CPER_CREATOR_PSTORE);
   181		/* someone else has cleared the record, try next one */
   182		if (rc == -ENOENT)
   183			goto retry;
   184		else if (rc < 0)
   185			goto out;
   186	
 > 187		memcpy(m, &rcd.data, sizeof(*m));
   188		rc = sizeof(*m);
   189	out:
   190		erst_get_record_id_end();
   191	
   192		return rc;
   193	}
   194	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki