From: Kees Cook <keescook@chromium.org>
To: Shuai Xue <xueshuai@linux.alibaba.com>
Cc: tony.luck@intel.com, linux-acpi@vger.kernel.org,
linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org,
dave.hansen@linux.intel.com, x86@kernel.org,
robert.moore@intel.com, acpica-devel@lists.linuxfoundation.org,
gpiccoli@igalia.com, mingo@redhat.com, bp@alien8.de,
linux-hardening@vger.kernel.org, baolin.wang@linux.alibaba.com,
hpa@zytor.com, james.morse@arm.com, tglx@linutronix.de,
linux-edac@vger.kernel.org, ardb@kernel.org, lenb@kernel.org
Subject: Re: [Acpica-devel] [RFC PATCH v2 1/9] pstore: move pstore creator id, section type and record struct to common header
Date: Mon, 25 Sep 2023 17:13:24 -0000 [thread overview]
Message-ID: <202309251012.AD87704BB@keescook> (raw)
In-Reply-To: <20230925074426.97856-2-xueshuai@linux.alibaba.com>
On Mon, Sep 25, 2023 at 03:44:18PM +0800, Shuai Xue wrote:
> Move pstore creator id, section type and record struct to the common
> header, so that it can be use by MCE and GHES driver.
I would prefer this was not in the pstore header -- this is a backend
detail that should stay in backend headers.
-Kees
--
Kees Cook
WARNING: multiple messages have this Message-ID (diff)
From: Kees Cook <keescook@chromium.org>
To: Shuai Xue <xueshuai@linux.alibaba.com>
Cc: tony.luck@intel.com, gpiccoli@igalia.com, rafael@kernel.org,
lenb@kernel.org, james.morse@arm.com, bp@alien8.de,
tglx@linutronix.de, mingo@redhat.com,
dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com,
ardb@kernel.org, robert.moore@intel.com,
linux-hardening@vger.kernel.org, linux-acpi@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org,
linux-efi@vger.kernel.org,
acpica-devel@lists.linuxfoundation.org,
baolin.wang@linux.alibaba.com
Subject: Re: [RFC PATCH v2 1/9] pstore: move pstore creator id, section type and record struct to common header
Date: Mon, 25 Sep 2023 10:13:20 -0700 [thread overview]
Message-ID: <202309251012.AD87704BB@keescook> (raw)
In-Reply-To: <20230925074426.97856-2-xueshuai@linux.alibaba.com>
On Mon, Sep 25, 2023 at 03:44:18PM +0800, Shuai Xue wrote:
> Move pstore creator id, section type and record struct to the common
> header, so that it can be use by MCE and GHES driver.
I would prefer this was not in the pstore header -- this is a backend
detail that should stay in backend headers.
-Kees
--
Kees Cook
next prev parent reply other threads:[~2023-09-25 17:13 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-25 7:44 [RFC PATCH v2 0/9] Use ERST for persistent storage of MCE and APEI errors Shuai Xue
2023-09-25 7:44 ` [Acpica-devel] " Shuai Xue
2023-09-25 7:44 ` [RFC PATCH v2 1/9] pstore: move pstore creator id, section type and record struct to common header Shuai Xue
2023-09-25 7:44 ` [Acpica-devel] " Shuai Xue
2023-09-25 17:13 ` Kees Cook [this message]
2023-09-25 17:13 ` Kees Cook
2023-09-26 6:47 ` Shuai Xue
2023-09-26 6:47 ` [Acpica-devel] " Shuai Xue
2023-09-25 7:44 ` [RFC PATCH v2 2/9] ACPI: APEI: Use common ERST struct to read/write serialized MCE record Shuai Xue
2023-09-25 7:44 ` [Acpica-devel] " Shuai Xue
2023-09-29 4:42 ` kernel test robot
2023-09-25 7:44 ` [RFC PATCH v2 3/9] ACPI: APEI: ERST: Emit the mce_record tracepoint Shuai Xue
2023-09-25 7:44 ` [Acpica-devel] " Shuai Xue
2023-09-25 7:44 ` [RFC PATCH v2 4/9] ACPI: tables: change section_type of generic error data as guid_t Shuai Xue
2023-09-25 7:44 ` [Acpica-devel] " Shuai Xue
2023-10-02 7:58 ` kernel test robot
2023-09-25 7:44 ` [RFC PATCH v2 5/9] ACPI: APEI: GHES: Use ERST to serialize APEI generic error before panic Shuai Xue
2023-09-25 7:44 ` [Acpica-devel] " Shuai Xue
2023-09-25 7:44 ` [RFC PATCH v2 6/9] ACPI: APEI: GHES: export ghes_report_chain Shuai Xue
2023-09-25 7:44 ` [Acpica-devel] " Shuai Xue
2023-09-25 7:44 ` [RFC PATCH v2 7/9] ACPI: APEI: ESRT: kick ghes_report_chain notifier to report serialized memory errors Shuai Xue
2023-09-25 7:44 ` [Acpica-devel] " Shuai Xue
2023-09-25 7:44 ` [RFC PATCH v2 8/9] ACPI: APEI: ESRT: print AER to report serialized PCIe errors Shuai Xue
2023-09-25 7:44 ` [Acpica-devel] " Shuai Xue
2023-09-25 7:44 ` [RFC PATCH v2 9/9] ACPI: APEI: ESRT: log ARM processor error Shuai Xue
2023-09-25 7:44 ` [Acpica-devel] " Shuai Xue
2023-09-28 14:43 ` [RFC PATCH v2 0/9] Use ERST for persistent storage of MCE and APEI errors Borislav Petkov
2023-09-28 14:50 ` [Acpica-devel] " Borislav Petkov
2023-10-07 7:15 ` Shuai Xue
2023-10-07 7:15 ` [Acpica-devel] " Shuai Xue
2023-10-26 10:21 ` Shuai Xue
2023-10-26 10:21 ` Shuai Xue
2023-10-26 13:32 ` [Acpica-devel] " Borislav Petkov
2023-10-26 13:32 ` Borislav Petkov
2024-11-26 7:04 ` Shuai Xue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202309251012.AD87704BB@keescook \
--to=keescook@chromium.org \
--cc=acpica-devel@lists.linuxfoundation.org \
--cc=ardb@kernel.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=gpiccoli@igalia.com \
--cc=hpa@zytor.com \
--cc=james.morse@arm.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=robert.moore@intel.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
--cc=xueshuai@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.