From: Simon Horman <horms@kernel.org>
To: Prasad Koya <prasad@arista.com>
Cc: dumazet@google.com, sasha.neftin@intel.com,
netdev@vger.kernel.org, jesse.brandeburg@intel.com,
anthony.l.nguyen@intel.com, intel-wired-lan@lists.osuosl.org,
kuba@kernel.org, pabeni@redhat.com, davem@davemloft.net
Subject: Re: [Intel-wired-lan] [PATCH] [iwl-net] Revert "igc: set TP bit in 'supported' and 'advertising' fields of ethtool_link_ksettings"
Date: Sat, 30 Sep 2023 18:17:48 +0200 [thread overview]
Message-ID: <20230930161748.GD92317@kernel.org> (raw)
In-Reply-To: <20230922163804.7DDBA2440449@us122.sjc.aristanetworks.com>
On Fri, Sep 22, 2023 at 09:38:04AM -0700, Prasad Koya wrote:
> This reverts commit 9ac3fc2f42e5ffa1e927dcbffb71b15fa81459e2.
>
> After the command "ethtool -s enps0 speed 100 duplex full autoneg on",
> i.e., advertise only 100Mbps speed to the peer, "ethtool enps0" shows
> advertised speeds as 100Mbps and 2500Mbps. Same behavior is seen
> when changing the speed to 10Mbps or 1000Mbps.
>
> This applies to I225/226 parts, which only supports copper mode.
> Reverting to original till the ambiguity is resolved.
>
> Fixes: 9ac3fc2f42e5 ("igc: set TP bit in 'supported' and
> 'advertising' fields of ethtool_link_ksettings")
nit: I don't think it is correct to linewrap Fixes tags.
> Signed-off-by: Prasad Koya <prasad@arista.com>
...
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
WARNING: multiple messages have this Message-ID (diff)
From: Simon Horman <horms@kernel.org>
To: Prasad Koya <prasad@arista.com>
Cc: intel-wired-lan@lists.osuosl.org, kuba@kernel.org,
davem@davemloft.net, pabeni@redhat.com, dumazet@google.com,
jesse.brandeburg@intel.com, anthony.l.nguyen@intel.com,
netdev@vger.kernel.org, sasha.neftin@intel.com
Subject: Re: [PATCH] [iwl-net] Revert "igc: set TP bit in 'supported' and 'advertising' fields of ethtool_link_ksettings"
Date: Sat, 30 Sep 2023 18:17:48 +0200 [thread overview]
Message-ID: <20230930161748.GD92317@kernel.org> (raw)
In-Reply-To: <20230922163804.7DDBA2440449@us122.sjc.aristanetworks.com>
On Fri, Sep 22, 2023 at 09:38:04AM -0700, Prasad Koya wrote:
> This reverts commit 9ac3fc2f42e5ffa1e927dcbffb71b15fa81459e2.
>
> After the command "ethtool -s enps0 speed 100 duplex full autoneg on",
> i.e., advertise only 100Mbps speed to the peer, "ethtool enps0" shows
> advertised speeds as 100Mbps and 2500Mbps. Same behavior is seen
> when changing the speed to 10Mbps or 1000Mbps.
>
> This applies to I225/226 parts, which only supports copper mode.
> Reverting to original till the ambiguity is resolved.
>
> Fixes: 9ac3fc2f42e5 ("igc: set TP bit in 'supported' and
> 'advertising' fields of ethtool_link_ksettings")
nit: I don't think it is correct to linewrap Fixes tags.
> Signed-off-by: Prasad Koya <prasad@arista.com>
...
next prev parent reply other threads:[~2023-09-30 16:18 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-22 16:38 [Intel-wired-lan] [PATCH] [iwl-net] Revert "igc: set TP bit in 'supported' and 'advertising' fields of ethtool_link_ksettings" Prasad Koya
2023-09-22 16:38 ` Prasad Koya
2023-09-24 7:09 ` [Intel-wired-lan] " Neftin, Sasha
2023-09-24 7:09 ` Neftin, Sasha
2023-09-24 14:51 ` [Intel-wired-lan] " Andrew Lunn
2023-09-24 14:51 ` Andrew Lunn
2023-09-25 19:40 ` [Intel-wired-lan] " Prasad Koya
2023-09-25 19:49 ` Andrew Lunn
2023-09-25 19:49 ` Andrew Lunn
2023-09-26 5:23 ` [Intel-wired-lan] " Neftin, Sasha
2023-09-26 5:23 ` Neftin, Sasha
2023-09-26 11:00 ` [Intel-wired-lan] " Neftin, Sasha
2023-09-26 11:00 ` Neftin, Sasha
2023-09-30 16:17 ` Simon Horman [this message]
2023-09-30 16:17 ` Simon Horman
2023-10-01 5:50 ` [Intel-wired-lan] " Neftin, Sasha
2023-10-01 5:50 ` Neftin, Sasha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230930161748.GD92317@kernel.org \
--to=horms@kernel.org \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=dumazet@google.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jesse.brandeburg@intel.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=prasad@arista.com \
--cc=sasha.neftin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.