* [PATCH 1/2] ARM: dts: mxs: Use dma-controller as node name
@ 2023-10-02 0:32 Fabio Estevam
2023-10-02 0:32 ` [PATCH 2/2] ARM: dts: imx23: Remove dma interrupt-names Fabio Estevam
2023-10-02 8:57 ` [PATCH 1/2] ARM: dts: mxs: Use dma-controller as node name Stefan Wahren
0 siblings, 2 replies; 4+ messages in thread
From: Fabio Estevam @ 2023-10-02 0:32 UTC (permalink / raw)
To: shawnguo; +Cc: linux-arm-kernel, Fabio Estevam
From: Fabio Estevam <festevam@denx.de>
Devicetree nodes should be generic.
Use 'dma-controller' as node names to fix the following schema
warnings:
dma-apbx@80024000: $nodename:0: 'dma-apbx@80024000' does not match '^dma-controller(@.*)?$'
from schema $id: http://devicetree.org/schemas/dma/fsl,mxs-dma.yaml#
Signed-off-by: Fabio Estevam <festevam@denx.de>
---
arch/arm/boot/dts/nxp/mxs/imx23.dtsi | 2 +-
arch/arm/boot/dts/nxp/mxs/imx28.dtsi | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/nxp/mxs/imx23.dtsi b/arch/arm/boot/dts/nxp/mxs/imx23.dtsi
index fdf18b7cb2f6..9cba1d0224f4 100644
--- a/arch/arm/boot/dts/nxp/mxs/imx23.dtsi
+++ b/arch/arm/boot/dts/nxp/mxs/imx23.dtsi
@@ -412,7 +412,7 @@ emi@80020000 {
status = "disabled";
};
- dma_apbx: dma-apbx@80024000 {
+ dma_apbx: dma-controller@80024000 {
compatible = "fsl,imx23-dma-apbx";
reg = <0x80024000 0x2000>;
interrupts = <7>, <5>, <9>, <26>,
diff --git a/arch/arm/boot/dts/nxp/mxs/imx28.dtsi b/arch/arm/boot/dts/nxp/mxs/imx28.dtsi
index d5d9dd319432..1cd87dc46bd1 100644
--- a/arch/arm/boot/dts/nxp/mxs/imx28.dtsi
+++ b/arch/arm/boot/dts/nxp/mxs/imx28.dtsi
@@ -990,7 +990,7 @@ etm: etm@80022000 {
status = "disabled";
};
- dma_apbx: dma-apbx@80024000 {
+ dma_apbx: dma-controller@80024000 {
compatible = "fsl,imx28-dma-apbx";
reg = <0x80024000 0x2000>;
interrupts = <78>, <79>, <66>, <0>,
--
2.34.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/2] ARM: dts: imx23: Remove dma interrupt-names
2023-10-02 0:32 [PATCH 1/2] ARM: dts: mxs: Use dma-controller as node name Fabio Estevam
@ 2023-10-02 0:32 ` Fabio Estevam
2023-10-02 9:05 ` Stefan Wahren
2023-10-02 8:57 ` [PATCH 1/2] ARM: dts: mxs: Use dma-controller as node name Stefan Wahren
1 sibling, 1 reply; 4+ messages in thread
From: Fabio Estevam @ 2023-10-02 0:32 UTC (permalink / raw)
To: shawnguo; +Cc: linux-arm-kernel, Fabio Estevam
From: Fabio Estevam <festevam@denx.de>
Per fsl,mxs-dma.yaml, 'interrupt-names' is not a valid property.
Remove it to fix the following schema warning:
dma-apbx@80024000: 'interrupt-names' does not match any of the regexes: 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/dma/fsl,mxs-dma.yaml#
Signed-off-by: Fabio Estevam <festevam@denx.de>
---
arch/arm/boot/dts/nxp/mxs/imx23.dtsi | 4 ----
1 file changed, 4 deletions(-)
diff --git a/arch/arm/boot/dts/nxp/mxs/imx23.dtsi b/arch/arm/boot/dts/nxp/mxs/imx23.dtsi
index 9cba1d0224f4..f98ee2e42431 100644
--- a/arch/arm/boot/dts/nxp/mxs/imx23.dtsi
+++ b/arch/arm/boot/dts/nxp/mxs/imx23.dtsi
@@ -419,10 +419,6 @@ dma_apbx: dma-controller@80024000 {
<19>, <0>, <25>, <23>,
<60>, <58>, <9>, <0>,
<0>, <0>, <0>, <0>;
- interrupt-names = "audio-adc", "audio-dac", "spdif-tx", "i2c",
- "saif0", "empty", "auart0-rx", "auart0-tx",
- "auart1-rx", "auart1-tx", "saif1", "empty",
- "empty", "empty", "empty", "empty";
#dma-cells = <1>;
dma-channels = <16>;
clocks = <&clks 16>;
--
2.34.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] ARM: dts: mxs: Use dma-controller as node name
2023-10-02 0:32 [PATCH 1/2] ARM: dts: mxs: Use dma-controller as node name Fabio Estevam
2023-10-02 0:32 ` [PATCH 2/2] ARM: dts: imx23: Remove dma interrupt-names Fabio Estevam
@ 2023-10-02 8:57 ` Stefan Wahren
1 sibling, 0 replies; 4+ messages in thread
From: Stefan Wahren @ 2023-10-02 8:57 UTC (permalink / raw)
To: Fabio Estevam, shawnguo; +Cc: linux-arm-kernel, Fabio Estevam
Am 02.10.23 um 02:32 schrieb Fabio Estevam:
> From: Fabio Estevam <festevam@denx.de>
>
> Devicetree nodes should be generic.
>
> Use 'dma-controller' as node names to fix the following schema
> warnings:
>
> dma-apbx@80024000: $nodename:0: 'dma-apbx@80024000' does not match '^dma-controller(@.*)?$'
> from schema $id: http://devicetree.org/schemas/dma/fsl,mxs-dma.yaml#
>
> Signed-off-by: Fabio Estevam <festevam@denx.de>
Reviewed-by: Stefan Wahren <wahrenst@gmx.net>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 2/2] ARM: dts: imx23: Remove dma interrupt-names
2023-10-02 0:32 ` [PATCH 2/2] ARM: dts: imx23: Remove dma interrupt-names Fabio Estevam
@ 2023-10-02 9:05 ` Stefan Wahren
0 siblings, 0 replies; 4+ messages in thread
From: Stefan Wahren @ 2023-10-02 9:05 UTC (permalink / raw)
To: Fabio Estevam, shawnguo; +Cc: linux-arm-kernel, Fabio Estevam
Hi Fabio,
Am 02.10.23 um 02:32 schrieb Fabio Estevam:
> From: Fabio Estevam <festevam@denx.de>
>
> Per fsl,mxs-dma.yaml, 'interrupt-names' is not a valid property.
>
> Remove it to fix the following schema warning:
>
> dma-apbx@80024000: 'interrupt-names' does not match any of the regexes: 'pinctrl-[0-9]+'
> from schema $id: http://devicetree.org/schemas/dma/fsl,mxs-dma.yaml#
>
> Signed-off-by: Fabio Estevam <festevam@denx.de>
> ---
> arch/arm/boot/dts/nxp/mxs/imx23.dtsi | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/arch/arm/boot/dts/nxp/mxs/imx23.dtsi b/arch/arm/boot/dts/nxp/mxs/imx23.dtsi
> index 9cba1d0224f4..f98ee2e42431 100644
> --- a/arch/arm/boot/dts/nxp/mxs/imx23.dtsi
> +++ b/arch/arm/boot/dts/nxp/mxs/imx23.dtsi
> @@ -419,10 +419,6 @@ dma_apbx: dma-controller@80024000 {
> <19>, <0>, <25>, <23>,
> <60>, <58>, <9>, <0>,
> <0>, <0>, <0>, <0>;
> - interrupt-names = "audio-adc", "audio-dac", "spdif-tx", "i2c",
> - "saif0", "empty", "auart0-rx", "auart0-tx",
> - "auart1-rx", "auart1-tx", "saif1", "empty",
> - "empty", "empty", "empty", "empty";
dropping these useful information looks wrong to me and also there is a
chance to break possible users beside Mainline Linux. I would prefer to
fix the schema by making interrupt-names optional.
Best regards
> #dma-cells = <1>;
> dma-channels = <16>;
> clocks = <&clks 16>;
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-10-02 9:06 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-02 0:32 [PATCH 1/2] ARM: dts: mxs: Use dma-controller as node name Fabio Estevam
2023-10-02 0:32 ` [PATCH 2/2] ARM: dts: imx23: Remove dma interrupt-names Fabio Estevam
2023-10-02 9:05 ` Stefan Wahren
2023-10-02 8:57 ` [PATCH 1/2] ARM: dts: mxs: Use dma-controller as node name Stefan Wahren
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.