All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Martin Kurbanov <mmkurbanov@salutedevices.com>
Cc: Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Mario Kicherer <dev@kicherer.org>,
	Chuanhong Guo <gch981213@gmail.com>, Dhruva Gole <d-gole@ti.com>,
	<linux-kernel@vger.kernel.org>, <linux-mtd@lists.infradead.org>,
	<kernel@sberdevices.ru>
Subject: Re: [PATCH v1] mtd: spinand: add support for FORESEE F35SQA002G
Date: Mon, 2 Oct 2023 14:09:53 +0200	[thread overview]
Message-ID: <20231002140953.170c0055@xps-13> (raw)
In-Reply-To: <54227489-519b-3268-885f-cf7a9687822b@salutedevices.com>

Hi Martin,

mmkurbanov@salutedevices.com wrote on Mon, 2 Oct 2023 13:18:18 +0300:

> Hi Miquel,
> Thanks for your review.
> 
> On 02.10.2023 12:44, Miquel Raynal wrote:
> > Hi Martin,  
> >> +static int f35sqa002g_ooblayout_free(struct mtd_info *mtd, int section,
> >> +				     struct mtd_oob_region *region)
> >> +{
> >> +	/* XXX: It is not possible to partially write to this OOB area, as both
> >> +	 * the main and OOB areas are protected by ECC. The user needs to
> >> +	 * program both the main area and OOB area at one programming time,
> >> +	 * so that the ECC parity code can be calculated properly.
> >> +	 */  
> > 
> > Is this comment really needed? I believe it could be dropped, unless
> > you are really experiencing strange subpage write attempts?  
> 
> If you write separately to the main area and the OOB area. This is the
> case with many SPI NAND chips, I agree that this comment can be dropped.
> 

All NAND chips have this limitation actually. I guess you can just get
rid of the comment. The rest looks ok.

Thanks, Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Martin Kurbanov <mmkurbanov@salutedevices.com>
Cc: Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Mario Kicherer <dev@kicherer.org>,
	Chuanhong Guo <gch981213@gmail.com>, Dhruva Gole <d-gole@ti.com>,
	<linux-kernel@vger.kernel.org>, <linux-mtd@lists.infradead.org>,
	<kernel@sberdevices.ru>
Subject: Re: [PATCH v1] mtd: spinand: add support for FORESEE F35SQA002G
Date: Mon, 2 Oct 2023 14:09:53 +0200	[thread overview]
Message-ID: <20231002140953.170c0055@xps-13> (raw)
In-Reply-To: <54227489-519b-3268-885f-cf7a9687822b@salutedevices.com>

Hi Martin,

mmkurbanov@salutedevices.com wrote on Mon, 2 Oct 2023 13:18:18 +0300:

> Hi Miquel,
> Thanks for your review.
> 
> On 02.10.2023 12:44, Miquel Raynal wrote:
> > Hi Martin,  
> >> +static int f35sqa002g_ooblayout_free(struct mtd_info *mtd, int section,
> >> +				     struct mtd_oob_region *region)
> >> +{
> >> +	/* XXX: It is not possible to partially write to this OOB area, as both
> >> +	 * the main and OOB areas are protected by ECC. The user needs to
> >> +	 * program both the main area and OOB area at one programming time,
> >> +	 * so that the ECC parity code can be calculated properly.
> >> +	 */  
> > 
> > Is this comment really needed? I believe it could be dropped, unless
> > you are really experiencing strange subpage write attempts?  
> 
> If you write separately to the main area and the OOB area. This is the
> case with many SPI NAND chips, I agree that this comment can be dropped.
> 

All NAND chips have this limitation actually. I guess you can just get
rid of the comment. The rest looks ok.

Thanks, Miquèl

  reply	other threads:[~2023-10-02 12:10 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-29 14:49 [PATCH v1] mtd: spinand: add support for FORESEE F35SQA002G Martin Kurbanov
2023-09-29 14:49 ` Martin Kurbanov
2023-10-02  9:44 ` Miquel Raynal
2023-10-02  9:44   ` Miquel Raynal
2023-10-02 10:18   ` Martin Kurbanov
2023-10-02 10:18     ` Martin Kurbanov
2023-10-02 12:09     ` Miquel Raynal [this message]
2023-10-02 12:09       ` Miquel Raynal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231002140953.170c0055@xps-13 \
    --to=miquel.raynal@bootlin.com \
    --cc=d-gole@ti.com \
    --cc=dev@kicherer.org \
    --cc=gch981213@gmail.com \
    --cc=kernel@sberdevices.ru \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=mmkurbanov@salutedevices.com \
    --cc=richard@nod.at \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.