From: Rob Herring <robh@kernel.org>
To: Claudiu <claudiu.beznea@tuxon.dev>
Cc: geert+renesas@glider.be, mturquette@baylibre.com,
sboyd@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, linus.walleij@linaro.org,
gregkh@linuxfoundation.org, jirislaby@kernel.org,
magnus.damm@gmail.com, catalin.marinas@arm.com, will@kernel.org,
quic_bjorande@quicinc.com, konrad.dybcio@linaro.org,
arnd@arndb.de, neil.armstrong@linaro.org,
prabhakar.mahadev-lad.rj@bp.renesas.com,
biju.das.jz@bp.renesas.com, linux-renesas-soc@vger.kernel.org,
linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-serial@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 19/28] dt-bindings: pinctrl: renesas: set additionalProperties: false
Date: Mon, 2 Oct 2023 09:50:52 -0500 [thread overview]
Message-ID: <20231002145052.GA1690001-robh@kernel.org> (raw)
In-Reply-To: <20230929053915.1530607-20-claudiu.beznea@bp.renesas.com>
On Fri, Sep 29, 2023 at 08:39:06AM +0300, Claudiu wrote:
> From: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
>
> Set additionalProperties: false.
>
> Suggested-by: Rob Herring <robh@kernel.org>
I did?
> Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
> ---
>
> Changes in v2:
> - this patch is new in v2 and added as suggested by Rob
>
> .../devicetree/bindings/pinctrl/renesas,rzg2l-pinctrl.yaml | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/pinctrl/renesas,rzg2l-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/renesas,rzg2l-pinctrl.yaml
> index 4782f96feb7e..eb726770f571 100644
> --- a/Documentation/devicetree/bindings/pinctrl/renesas,rzg2l-pinctrl.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/renesas,rzg2l-pinctrl.yaml
> @@ -106,8 +106,7 @@ additionalProperties:
> line-name: true
>
> - type: object
> - additionalProperties:
> - $ref: "#/additionalProperties/anyOf/0"
> + additionalProperties: false
With no properties defined, this only allows an empty node which is
probably not what you want. It's the other anyOf entry that needed it,
but I already sent a fix which Linus applied.
Rob
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Claudiu <claudiu.beznea@tuxon.dev>
Cc: geert+renesas@glider.be, mturquette@baylibre.com,
sboyd@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, linus.walleij@linaro.org,
gregkh@linuxfoundation.org, jirislaby@kernel.org,
magnus.damm@gmail.com, catalin.marinas@arm.com, will@kernel.org,
quic_bjorande@quicinc.com, konrad.dybcio@linaro.org,
arnd@arndb.de, neil.armstrong@linaro.org,
prabhakar.mahadev-lad.rj@bp.renesas.com,
biju.das.jz@bp.renesas.com, linux-renesas-soc@vger.kernel.org,
linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-serial@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 19/28] dt-bindings: pinctrl: renesas: set additionalProperties: false
Date: Mon, 2 Oct 2023 09:50:52 -0500 [thread overview]
Message-ID: <20231002145052.GA1690001-robh@kernel.org> (raw)
In-Reply-To: <20230929053915.1530607-20-claudiu.beznea@bp.renesas.com>
On Fri, Sep 29, 2023 at 08:39:06AM +0300, Claudiu wrote:
> From: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
>
> Set additionalProperties: false.
>
> Suggested-by: Rob Herring <robh@kernel.org>
I did?
> Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
> ---
>
> Changes in v2:
> - this patch is new in v2 and added as suggested by Rob
>
> .../devicetree/bindings/pinctrl/renesas,rzg2l-pinctrl.yaml | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/pinctrl/renesas,rzg2l-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/renesas,rzg2l-pinctrl.yaml
> index 4782f96feb7e..eb726770f571 100644
> --- a/Documentation/devicetree/bindings/pinctrl/renesas,rzg2l-pinctrl.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/renesas,rzg2l-pinctrl.yaml
> @@ -106,8 +106,7 @@ additionalProperties:
> line-name: true
>
> - type: object
> - additionalProperties:
> - $ref: "#/additionalProperties/anyOf/0"
> + additionalProperties: false
With no properties defined, this only allows an empty node which is
probably not what you want. It's the other anyOf entry that needed it,
but I already sent a fix which Linus applied.
Rob
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-10-02 14:51 UTC|newest]
Thread overview: 134+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-29 5:38 [PATCH v2 00/28] Add new Renesas RZ/G3S SoC and RZ/G3S SMARC EVK Claudiu
2023-09-29 5:38 ` Claudiu
2023-09-29 5:38 ` [PATCH v2 01/28] dt-bindings: serial: renesas,scif: document r9a08g045 support Claudiu
2023-09-29 5:38 ` Claudiu
2023-09-29 5:38 ` [PATCH v2 02/28] clk: renesas: rzg2l: wait for status bit of SD mux before continuing Claudiu
2023-09-29 5:38 ` Claudiu
2023-10-03 15:14 ` Geert Uytterhoeven
2023-10-03 15:14 ` Geert Uytterhoeven
2023-09-29 5:38 ` [PATCH v2 03/28] clk: renesas: rzg2l: lock around writes to mux register Claudiu
2023-09-29 5:38 ` Claudiu
2023-10-03 15:18 ` Geert Uytterhoeven
2023-10-03 15:18 ` Geert Uytterhoeven
2023-09-29 5:38 ` [PATCH v2 04/28] clk: renesas: rzg2l: trust value returned by hardware Claudiu
2023-09-29 5:38 ` Claudiu
2023-10-03 15:19 ` Geert Uytterhoeven
2023-10-03 15:19 ` Geert Uytterhoeven
2023-09-29 5:38 ` [PATCH v2 05/28] clk: renesas: rzg2l: fix computation formula Claudiu
2023-09-29 5:38 ` Claudiu
2023-10-04 8:08 ` Geert Uytterhoeven
2023-10-04 8:08 ` Geert Uytterhoeven
2023-09-29 5:38 ` [PATCH v2 06/28] clk: renesas: rzg2l: remove critical area Claudiu
2023-09-29 5:38 ` Claudiu
2023-10-04 8:11 ` Geert Uytterhoeven
2023-10-04 8:11 ` Geert Uytterhoeven
2023-09-29 5:38 ` [PATCH v2 07/28] clk: renesas: rzg2l: add support for RZ/G3S PLL Claudiu
2023-09-29 5:38 ` Claudiu
2023-10-04 8:45 ` Geert Uytterhoeven
2023-10-04 8:45 ` Geert Uytterhoeven
2023-09-29 5:38 ` [PATCH v2 08/28] clk: renesas: rzg2l: add struct clk_hw_data Claudiu
2023-09-29 5:38 ` Claudiu
2023-10-04 8:47 ` Geert Uytterhoeven
2023-10-04 8:47 ` Geert Uytterhoeven
2023-09-29 5:38 ` [PATCH v2 09/28] clk: renesas: rzg2l: remove CPG_SDHI_DSEL from generic header Claudiu
2023-09-29 5:38 ` Claudiu
2023-10-04 8:50 ` Geert Uytterhoeven
2023-10-04 8:50 ` Geert Uytterhoeven
2023-09-29 5:38 ` [PATCH v2 10/28] clk: renesas: rzg2l: refactor sd mux driver Claudiu
2023-09-29 5:38 ` Claudiu
2023-10-04 11:30 ` Geert Uytterhoeven
2023-10-04 11:30 ` Geert Uytterhoeven
2023-10-05 4:24 ` claudiu beznea
2023-10-05 4:24 ` claudiu beznea
2023-09-29 5:38 ` [PATCH v2 11/28] clk: renesas: rzg2l: add a divider clock for RZ/G3S Claudiu
2023-09-29 5:38 ` Claudiu
2023-10-04 12:30 ` Geert Uytterhoeven
2023-10-04 12:30 ` Geert Uytterhoeven
2023-10-05 5:04 ` claudiu beznea
2023-10-05 5:04 ` claudiu beznea
2023-10-09 11:57 ` Geert Uytterhoeven
2023-10-09 11:57 ` Geert Uytterhoeven
2023-09-29 5:38 ` [PATCH v2 12/28] dt-bindings: clock: renesas,rzg2l-cpg: document RZ/G3S SoC Claudiu
2023-09-29 5:38 ` Claudiu
2023-10-04 12:37 ` Geert Uytterhoeven
2023-10-04 12:37 ` Geert Uytterhoeven
2023-09-29 5:39 ` [PATCH v2 13/28] clk: renesas: add minimal boot support for " Claudiu
2023-09-29 5:39 ` Claudiu
2023-10-04 12:41 ` Geert Uytterhoeven
2023-10-04 12:41 ` Geert Uytterhoeven
2023-09-29 5:39 ` [PATCH v2 14/28] pinctrl: renesas: rzg2l: index all registers based on port offset Claudiu
2023-09-29 5:39 ` Claudiu
2023-10-04 12:52 ` Geert Uytterhoeven
2023-10-04 12:52 ` Geert Uytterhoeven
2023-09-29 5:39 ` [PATCH v2 15/28] pinctrl: renesas: rzg2l: adapt for different SD/PWPR register offsets Claudiu
2023-09-29 5:39 ` Claudiu
2023-10-04 12:57 ` Geert Uytterhoeven
2023-10-04 12:57 ` Geert Uytterhoeven
2023-09-29 5:39 ` [PATCH v2 16/28] pinctrl: renesas: rzg2l: adapt function number for RZ/G3S Claudiu
2023-09-29 5:39 ` Claudiu
2023-10-04 12:58 ` Geert Uytterhoeven
2023-10-04 12:58 ` Geert Uytterhoeven
2023-09-29 5:39 ` [PATCH v2 17/28] pinctrl: renesas: rzg2l: move ds and oi to SoC specific configuration Claudiu
2023-09-29 5:39 ` Claudiu
2023-10-04 13:18 ` Geert Uytterhoeven
2023-10-04 13:18 ` Geert Uytterhoeven
2023-09-29 5:39 ` [PATCH v2 18/28] pinctrl: renesas: rzg2l: add support for different ds values on different groups Claudiu
2023-09-29 5:39 ` Claudiu
2023-09-29 9:24 ` Paul Barker
2023-09-29 9:24 ` Paul Barker
2023-10-04 13:17 ` Geert Uytterhoeven
2023-10-04 13:17 ` Geert Uytterhoeven
2023-10-05 5:05 ` claudiu beznea
2023-10-05 5:05 ` claudiu beznea
2023-10-05 10:04 ` Geert Uytterhoeven
2023-10-05 10:04 ` Geert Uytterhoeven
2023-09-29 5:39 ` [PATCH v2 19/28] dt-bindings: pinctrl: renesas: set additionalProperties: false Claudiu
2023-09-29 5:39 ` Claudiu
2023-09-29 14:09 ` Conor Dooley
2023-09-29 14:09 ` Conor Dooley
2023-10-02 14:50 ` Rob Herring [this message]
2023-10-02 14:50 ` Rob Herring
2023-10-03 3:57 ` claudiu beznea
2023-10-03 3:57 ` claudiu beznea
2023-09-29 5:39 ` [PATCH v2 20/28] dt-bindings: pinctrl: renesas: document RZ/G3S SoC Claudiu
2023-09-29 5:39 ` Claudiu
2023-09-29 14:07 ` Conor Dooley
2023-09-29 14:07 ` Conor Dooley
2023-10-04 13:21 ` Geert Uytterhoeven
2023-10-04 13:21 ` Geert Uytterhoeven
2023-09-29 5:39 ` [PATCH v2 21/28] pinctrl: renesas: rzg2l: add support for " Claudiu
2023-09-29 5:39 ` Claudiu
2023-10-04 13:24 ` Geert Uytterhoeven
2023-10-04 13:24 ` Geert Uytterhoeven
2023-09-29 5:39 ` [PATCH v2 22/28] arm64: dts: renesas: add initial DTSI " Claudiu
2023-09-29 5:39 ` Claudiu
2023-10-04 13:29 ` Geert Uytterhoeven
2023-10-04 13:29 ` Geert Uytterhoeven
2023-09-29 5:39 ` [PATCH v2 23/28] dt-bindings: arm: renesas: document RZ/G3S SMARC SoM Claudiu
2023-09-29 5:39 ` Claudiu
2023-09-29 14:05 ` Conor Dooley
2023-09-29 14:05 ` Conor Dooley
2023-10-04 13:28 ` Geert Uytterhoeven
2023-10-04 13:28 ` Geert Uytterhoeven
2023-09-29 5:39 ` [PATCH v2 24/28] arm64: dts: renesas: rzg3l-smarc-som: add initial support for " Claudiu
2023-09-29 5:39 ` Claudiu
2023-10-04 13:30 ` Geert Uytterhoeven
2023-10-04 13:30 ` Geert Uytterhoeven
2023-09-29 5:39 ` [PATCH v2 25/28] arm64: dts: renesas: rzg3s-smarc: add initial device tree for RZ SMARC Carrier-II Board Claudiu
2023-09-29 5:39 ` Claudiu
2023-10-04 13:31 ` Geert Uytterhoeven
2023-10-04 13:31 ` Geert Uytterhoeven
2023-09-29 5:39 ` [PATCH v2 26/28] dt-bindings: arm: renesas: document SMARC Carrier-II EVK Claudiu
2023-09-29 5:39 ` Claudiu
2023-09-29 14:05 ` Conor Dooley
2023-09-29 14:05 ` Conor Dooley
2023-10-04 13:32 ` Geert Uytterhoeven
2023-10-04 13:32 ` Geert Uytterhoeven
2023-09-29 5:39 ` [PATCH v2 27/28] arm64: dts: renesas: r9a08g045s33-smarc: add initial device tree for RZ/G3S SMARC EVK board Claudiu
2023-09-29 5:39 ` Claudiu
2023-10-04 13:33 ` Geert Uytterhoeven
2023-10-04 13:33 ` Geert Uytterhoeven
2023-09-29 5:39 ` [PATCH v2 28/28] arm64: defconfig: enable RZ/G3S (R9A08G045) SoC Claudiu
2023-09-29 5:39 ` Claudiu
2023-10-04 13:34 ` Geert Uytterhoeven
2023-10-04 13:34 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231002145052.GA1690001-robh@kernel.org \
--to=robh@kernel.org \
--cc=arnd@arndb.de \
--cc=biju.das.jz@bp.renesas.com \
--cc=catalin.marinas@arm.com \
--cc=claudiu.beznea@tuxon.dev \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=mturquette@baylibre.com \
--cc=neil.armstrong@linaro.org \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=quic_bjorande@quicinc.com \
--cc=sboyd@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.