From: Jason Gunthorpe <jgg@nvidia.com>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: kevin.tian@intel.com, yishaih@nvidia.com, brett.creeley@amd.com,
kvm@vger.kernel.org, anthony.l.nguyen@intel.com,
netdev@vger.kernel.org, Yahui Cao <yahui.cao@intel.com>,
jesse.brandeburg@intel.com, shameerali.kolothum.thodi@huawei.com,
edumazet@google.com, madhu.chittim@intel.com,
intel-wired-lan@lists.osuosl.org, sridhar.samudrala@intel.com,
kuba@kernel.org, pabeni@redhat.com, davem@davemloft.net
Subject: Re: [Intel-wired-lan] [PATCH iwl-next v3 13/13] vfio/ice: Implement vfio_pci driver for E800 devices
Date: Wed, 4 Oct 2023 09:25:23 -0300 [thread overview]
Message-ID: <20231004122523.GG682044@nvidia.com> (raw)
In-Reply-To: <20231003160421.54c57ceb.alex.williamson@redhat.com>
On Tue, Oct 03, 2023 at 04:04:21PM -0600, Alex Williamson wrote:
> > +/**
> > + * ice_vfio_pci_load_state - VFIO device state reloading
> > + * @ice_vdev: pointer to ice vfio pci core device structure
> > + *
> > + * Load device state and restore it. This function is called when the VFIO uAPI
> > + * consumer wants to load the device state info from VFIO migration region and
> > + * restore them into the device. This function should make sure all the device
> > + * state info is loaded and restored successfully. As a result, return value is
> > + * mandatory to be checked.
> > + *
> > + * Return 0 for success, negative value for failure.
> > + */
>
> Kudos on the kernel-doc comments throughout, nice!
>
> This appears to be a substantial improvement from the comments I see
> on v2, I'm curious where Kevin and Jason stand on this now. Thanks,
It is on my todo list, but I haven't been able to look
Did the fundamental issue with operating the VF from the VFIO driver
get fully fixed?
Jason
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
WARNING: multiple messages have this Message-ID (diff)
From: Jason Gunthorpe <jgg@nvidia.com>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: Yahui Cao <yahui.cao@intel.com>,
intel-wired-lan@lists.osuosl.org, kvm@vger.kernel.org,
netdev@vger.kernel.org, lingyu.liu@intel.com,
kevin.tian@intel.com, madhu.chittim@intel.com,
sridhar.samudrala@intel.com, yishaih@nvidia.com,
shameerali.kolothum.thodi@huawei.com, brett.creeley@amd.com,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, jesse.brandeburg@intel.com,
anthony.l.nguyen@intel.com
Subject: Re: [PATCH iwl-next v3 13/13] vfio/ice: Implement vfio_pci driver for E800 devices
Date: Wed, 4 Oct 2023 09:25:23 -0300 [thread overview]
Message-ID: <20231004122523.GG682044@nvidia.com> (raw)
In-Reply-To: <20231003160421.54c57ceb.alex.williamson@redhat.com>
On Tue, Oct 03, 2023 at 04:04:21PM -0600, Alex Williamson wrote:
> > +/**
> > + * ice_vfio_pci_load_state - VFIO device state reloading
> > + * @ice_vdev: pointer to ice vfio pci core device structure
> > + *
> > + * Load device state and restore it. This function is called when the VFIO uAPI
> > + * consumer wants to load the device state info from VFIO migration region and
> > + * restore them into the device. This function should make sure all the device
> > + * state info is loaded and restored successfully. As a result, return value is
> > + * mandatory to be checked.
> > + *
> > + * Return 0 for success, negative value for failure.
> > + */
>
> Kudos on the kernel-doc comments throughout, nice!
>
> This appears to be a substantial improvement from the comments I see
> on v2, I'm curious where Kevin and Jason stand on this now. Thanks,
It is on my todo list, but I haven't been able to look
Did the fundamental issue with operating the VF from the VFIO driver
get fully fixed?
Jason
next prev parent reply other threads:[~2023-10-04 12:25 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-18 6:25 [Intel-wired-lan] [PATCH iwl-next v3 00/13] Add E800 live migration driver Yahui Cao
2023-09-18 6:25 ` Yahui Cao
2023-09-18 6:25 ` [Intel-wired-lan] [PATCH iwl-next v3 01/13] ice: Fix missing legacy 32byte RXDID in the supported bitmap Yahui Cao
2023-09-18 6:25 ` Yahui Cao
2023-09-18 6:25 ` [Intel-wired-lan] [PATCH iwl-next v3 02/13] ice: Add function to get RX queue context Yahui Cao
2023-09-18 6:25 ` Yahui Cao
2023-09-18 6:25 ` [Intel-wired-lan] [PATCH iwl-next v3 03/13] ice: Add function to get and set TX " Yahui Cao
2023-09-18 6:25 ` Yahui Cao
2023-09-18 6:25 ` [Intel-wired-lan] [PATCH iwl-next v3 04/13] ice: Introduce VF state ICE_VF_STATE_REPLAYING_VC for migration Yahui Cao
2023-09-18 6:25 ` Yahui Cao
2023-09-18 6:25 ` [Intel-wired-lan] [PATCH iwl-next v3 05/13] ice: Add fundamental migration init and exit function Yahui Cao
2023-09-18 6:25 ` Yahui Cao
2023-09-18 6:25 ` [Intel-wired-lan] [PATCH iwl-next v3 06/13] ice: Log virtual channel messages in PF Yahui Cao
2023-09-18 6:25 ` Yahui Cao
2023-09-18 6:25 ` [Intel-wired-lan] [PATCH iwl-next v3 07/13] ice: Add device state save/restore function for migration Yahui Cao
2023-09-18 6:25 ` Yahui Cao
2023-09-18 6:25 ` [Intel-wired-lan] [PATCH iwl-next v3 08/13] ice: Fix VSI id in virtual channel message " Yahui Cao
2023-09-18 6:25 ` Yahui Cao
2023-09-18 6:25 ` [Intel-wired-lan] [PATCH iwl-next v3 09/13] ice: Save and restore RX Queue head Yahui Cao
2023-09-18 6:25 ` Yahui Cao
2023-09-18 6:25 ` [Intel-wired-lan] [PATCH iwl-next v3 10/13] ice: Save and restore TX " Yahui Cao
2023-09-18 6:25 ` Yahui Cao
2023-09-18 6:25 ` [Intel-wired-lan] [PATCH iwl-next v3 11/13] ice: Add device suspend function for migration Yahui Cao
2023-09-18 6:25 ` Yahui Cao
2023-09-18 6:25 ` [Intel-wired-lan] [PATCH iwl-next v3 12/13] ice: Save and restore mmio registers Yahui Cao
2023-09-18 6:25 ` Yahui Cao
2023-09-18 6:25 ` [Intel-wired-lan] [PATCH iwl-next v3 13/13] vfio/ice: Implement vfio_pci driver for E800 devices Yahui Cao
2023-09-18 6:25 ` Yahui Cao
2023-10-03 22:04 ` [Intel-wired-lan] " Alex Williamson
2023-10-03 22:04 ` Alex Williamson
2023-10-04 12:25 ` Jason Gunthorpe [this message]
2023-10-04 12:25 ` Jason Gunthorpe
2023-10-07 8:12 ` [Intel-wired-lan] " Cao, Yahui
2023-10-07 8:12 ` Cao, Yahui
2023-10-07 7:55 ` [Intel-wired-lan] " Cao, Yahui
2023-10-07 7:55 ` Cao, Yahui
2023-10-13 8:52 ` [Intel-wired-lan] " Tian, Kevin
2023-10-13 8:52 ` Tian, Kevin
2023-10-13 14:07 ` [Intel-wired-lan] " Jason Gunthorpe
2023-10-13 14:07 ` Jason Gunthorpe
2023-10-16 8:26 ` [Intel-wired-lan] " Tian, Kevin
2023-10-16 8:26 ` Tian, Kevin
2023-10-11 0:59 ` [Intel-wired-lan] [PATCH iwl-next v3 00/13] Add E800 live migration driver Jacob Keller
2023-10-16 16:51 ` Jason Gunthorpe
2023-10-16 16:51 ` Jason Gunthorpe
2023-10-20 6:49 ` [Intel-wired-lan] " Cao, Yahui
2023-10-20 6:49 ` Cao, Yahui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231004122523.GG682044@nvidia.com \
--to=jgg@nvidia.com \
--cc=alex.williamson@redhat.com \
--cc=anthony.l.nguyen@intel.com \
--cc=brett.creeley@amd.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jesse.brandeburg@intel.com \
--cc=kevin.tian@intel.com \
--cc=kuba@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=madhu.chittim@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=sridhar.samudrala@intel.com \
--cc=yahui.cao@intel.com \
--cc=yishaih@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.