From: Jakub Kicinski <kuba@kernel.org>
To: Moshe Shemesh <moshe@nvidia.com>
Cc: "David S. Miller" <davem@davemloft.net>, <netdev@vger.kernel.org>,
Jiri Pirko <jiri@nvidia.com>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net] devlink: Hold devlink lock on health reporter dump get
Date: Wed, 4 Oct 2023 16:39:29 -0700 [thread overview]
Message-ID: <20231004163929.70977d05@kernel.org> (raw)
In-Reply-To: <1696173580-222744-1-git-send-email-moshe@nvidia.com>
On Sun, 1 Oct 2023 18:19:40 +0300 Moshe Shemesh wrote:
> Devlink health dump get callback should take devlink lock as any other
> devlink callback. Add devlink lock to the callback and to any call for
> devlink_health_do_dump().
>
> As devlink lock is added to any callback of dump, the reporter dump_lock
> is now redundant and can be removed.
I love the change but it needs more info in the commit message :)
1. what exact / example but real problem are you solving?
2. some words of reassurance that you checked all the drivers
and the locking change should be safe (none of them take
instance locks in reporter callbacks etc)
--
pw-bot: cr
next prev parent reply other threads:[~2023-10-04 23:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-01 15:19 [PATCH net] devlink: Hold devlink lock on health reporter dump get Moshe Shemesh
2023-10-03 11:36 ` Simon Horman
2023-10-04 23:39 ` Jakub Kicinski [this message]
2023-10-05 11:59 ` Moshe Shemesh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231004163929.70977d05@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=jiri@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=moshe@nvidia.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.