From: Greg KH <gregkh@linuxfoundation.org>
To: Jay Buddhabhatti <jay.buddhabhatti@amd.com>
Cc: michal.simek@amd.com, tanmay.shah@amd.com,
nava.kishore.manne@amd.com, ben.levinsky@amd.com,
robh@kernel.org, dhaval.r.shah@amd.com, marex@denx.de,
izhar.ameer.shaikh@amd.com, arnd@arndb.de, ruanjinjie@huawei.com,
mathieu.poirier@linaro.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 1/6] firmware: xilinx: Update firmware call interface to support additional arg
Date: Wed, 4 Oct 2023 14:14:18 +0200 [thread overview]
Message-ID: <2023100445-rising-brittle-fe69@gregkh> (raw)
In-Reply-To: <20231004094116.27128-2-jay.buddhabhatti@amd.com>
On Wed, Oct 04, 2023 at 02:41:11AM -0700, Jay Buddhabhatti wrote:
> int zynqmp_pm_invoke_fn(u32 pm_api_id, u32 arg0, u32 arg1,
> - u32 arg2, u32 arg3, u32 *ret_payload)
> + u32 arg2, u32 arg3, u32 arg4,
> + u32 *ret_payload)
You do have 100 columns to use now, why wrap?
Same for other places you did this.
thanks,
greg k-h
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: Jay Buddhabhatti <jay.buddhabhatti@amd.com>
Cc: michal.simek@amd.com, tanmay.shah@amd.com,
nava.kishore.manne@amd.com, ben.levinsky@amd.com,
robh@kernel.org, dhaval.r.shah@amd.com, marex@denx.de,
izhar.ameer.shaikh@amd.com, arnd@arndb.de, ruanjinjie@huawei.com,
mathieu.poirier@linaro.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 1/6] firmware: xilinx: Update firmware call interface to support additional arg
Date: Wed, 4 Oct 2023 14:14:18 +0200 [thread overview]
Message-ID: <2023100445-rising-brittle-fe69@gregkh> (raw)
In-Reply-To: <20231004094116.27128-2-jay.buddhabhatti@amd.com>
On Wed, Oct 04, 2023 at 02:41:11AM -0700, Jay Buddhabhatti wrote:
> int zynqmp_pm_invoke_fn(u32 pm_api_id, u32 arg0, u32 arg1,
> - u32 arg2, u32 arg3, u32 *ret_payload)
> + u32 arg2, u32 arg3, u32 arg4,
> + u32 *ret_payload)
You do have 100 columns to use now, why wrap?
Same for other places you did this.
thanks,
greg k-h
next prev parent reply other threads:[~2023-10-04 12:14 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-04 9:41 [PATCH v2 0/6] update for versal net platform Jay Buddhabhatti
2023-10-04 9:41 ` Jay Buddhabhatti
2023-10-04 9:41 ` [PATCH v2 1/6] firmware: xilinx: Update firmware call interface to support additional arg Jay Buddhabhatti
2023-10-04 9:41 ` Jay Buddhabhatti
2023-10-04 12:14 ` Greg KH [this message]
2023-10-04 12:14 ` Greg KH
2023-10-04 9:41 ` [PATCH v2 2/6] firmware: xilinx: Expand feature check to support all PLM modules Jay Buddhabhatti
2023-10-04 9:41 ` Jay Buddhabhatti
2023-10-04 11:30 ` Michal Simek
2023-10-04 11:30 ` Michal Simek
2023-10-04 9:41 ` [PATCH v2 3/6] firmware: xilinx: Register event manager driver Jay Buddhabhatti
2023-10-04 9:41 ` Jay Buddhabhatti
2023-10-04 9:41 ` [PATCH v2 4/6] drivers: soc: xilinx: Fix error message on SGI registration failure Jay Buddhabhatti
2023-10-04 9:41 ` Jay Buddhabhatti
2023-10-04 12:15 ` Greg KH
2023-10-04 12:15 ` Greg KH
2023-10-04 12:48 ` Buddhabhatti, Jay
2023-10-04 12:48 ` Buddhabhatti, Jay
2023-10-04 12:51 ` Greg KH
2023-10-04 12:51 ` Greg KH
2023-10-04 9:41 ` [PATCH v2 5/6] firmware: zynqmp: Add support to handle IPI CRC failure Jay Buddhabhatti
2023-10-04 9:41 ` Jay Buddhabhatti
2023-10-04 9:41 ` [PATCH v2 6/6] drivers: soc: xilinx: update maintainer of event manager driver Jay Buddhabhatti
2023-10-04 9:41 ` Jay Buddhabhatti
2023-10-04 12:17 ` Greg KH
2023-10-04 12:17 ` Greg KH
2023-10-04 13:16 ` Michal Simek
2023-10-04 13:16 ` Michal Simek
2023-10-04 13:47 ` Greg KH
2023-10-04 13:47 ` Greg KH
2023-10-04 14:34 ` Michal Simek
2023-10-04 14:34 ` Michal Simek
2023-10-05 14:09 ` Buddhabhatti, Jay
2023-10-05 14:09 ` Buddhabhatti, Jay
2023-10-05 14:10 ` Greg KH
2023-10-05 14:10 ` Greg KH
2023-10-06 5:15 ` Buddhabhatti, Jay
2023-10-06 5:15 ` Buddhabhatti, Jay
2023-10-04 11:31 ` [PATCH v2 0/6] update for versal net platform Michal Simek
2023-10-04 11:31 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023100445-rising-brittle-fe69@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=ben.levinsky@amd.com \
--cc=dhaval.r.shah@amd.com \
--cc=izhar.ameer.shaikh@amd.com \
--cc=jay.buddhabhatti@amd.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marex@denx.de \
--cc=mathieu.poirier@linaro.org \
--cc=michal.simek@amd.com \
--cc=nava.kishore.manne@amd.com \
--cc=robh@kernel.org \
--cc=ruanjinjie@huawei.com \
--cc=tanmay.shah@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.