From: Jakub Kicinski <kuba@kernel.org>
To: Eric Dumazet <edumazet@google.com>
Cc: "Christian Marangi" <ansuelsmth@gmail.com>,
"Jason Gunthorpe" <jgg@ziepe.ca>,
"Leon Romanovsky" <leon@kernel.org>,
"Wolfgang Grandegger" <wg@grandegger.com>,
"Marc Kleine-Budde" <mkl@pengutronix.de>,
"David S. Miller" <davem@davemloft.net>,
"Paolo Abeni" <pabeni@redhat.com>,
"Chris Snook" <chris.snook@gmail.com>,
"Raju Rangoju" <rajur@chelsio.com>,
"Jeroen de Borst" <jeroendb@google.com>,
"Praveen Kaligineedi" <pkaligineedi@google.com>,
"Shailend Chand" <shailend@google.com>,
"Douglas Miller" <dougmill@linux.ibm.com>,
"Michael Ellerman" <mpe@ellerman.id.au>,
"Nicholas Piggin" <npiggin@gmail.com>,
"Christophe Leroy" <christophe.leroy@csgroup.eu>,
"Nick Child" <nnac123@linux.ibm.com>,
"Haren Myneni" <haren@linux.ibm.com>,
"Rick Lindsley" <ricklind@linux.ibm.com>,
"Dany Madden" <danymadden@us.ibm.com>,
"Thomas Falcon" <tlfalcon@linux.ibm.com>,
"Tariq Toukan" <tariqt@nvidia.com>,
"Alexandre Torgue" <alexandre.torgue@foss.st.com>,
"Jose Abreu" <joabreu@synopsys.com>,
"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
"Krzysztof Halasa" <khalasa@piap.pl>,
"Kalle Valo" <kvalo@kernel.org>,
"Jeff Johnson" <quic_jjohnson@quicinc.com>,
"Gregory Greenman" <gregory.greenman@intel.com>,
"Chandrashekar Devegowda" <chandrashekar.devegowda@intel.com>,
"Intel Corporation" <linuxwwan@intel.com>,
"Chiranjeevi Rapolu" <chiranjeevi.rapolu@linux.intel.com>,
"Liu Haijun" <haijun.liu@mediatek.com>,
"M Chetan Kumar" <m.chetan.kumar@linux.intel.com>,
"Ricardo Martinez" <ricardo.martinez@linux.intel.com>,
"Loic Poulain" <loic.poulain@linaro.org>,
"Sergey Ryazanov" <ryazanov.s.a@gmail.com>,
"Johannes Berg" <johannes@sipsolutions.net>,
"Yuanjun Gong" <ruc_gongyuanjun@163.com>,
"Simon Horman" <horms@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Ziwei Xiao" <ziweixiao@google.com>,
"Rushil Gupta" <rushilg@google.com>,
"Coco Li" <lixiaoyan@google.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Junfeng Guo" <junfeng.guo@intel.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Wei Fang" <wei.fang@nxp.com>,
"Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>,
"Yuri Karpov" <YKarpov@ispras.ru>,
"Zhengchao Shao" <shaozhengchao@huawei.com>,
"Andrew Lunn" <andrew@lunn.ch>,
"Zheng Zengkai" <zhengzengkai@huawei.com>,
"Lee Jones" <lee@kernel.org>,
"Maximilian Luz" <luzmaximilian@gmail.com>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
"Dawei Li" <set_pte_at@outlook.com>,
Anjaneyulu <pagadala.yesu.anjaneyulu@intel.com>,
"Benjamin Berg" <benjamin.berg@intel.com>,
linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-can@vger.kernel.org, netdev@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org, ath10k@lists.infradead.org,
linux-wireless@vger.kernel.org
Subject: Re: [net-next PATCH v2 3/4] netdev: replace napi_reschedule with napi_schedule
Date: Thu, 5 Oct 2023 09:32:53 -0700 [thread overview]
Message-ID: <20231005093253.2e25533a@kernel.org> (raw)
In-Reply-To: <CANn89iK226C-pHUJm7HKMyEtMycGC=KCA2M6kw2KJaUj0cCT6w@mail.gmail.com>
On Thu, 5 Oct 2023 18:11:56 +0200 Eric Dumazet wrote:
> OK, but I suspect some users of napi_reschedule() might not be race-free...
What's the race you're thinking of?
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
WARNING: multiple messages have this Message-ID (diff)
From: Jakub Kicinski <kuba@kernel.org>
To: Eric Dumazet <edumazet@google.com>
Cc: "Christian Marangi" <ansuelsmth@gmail.com>,
"Jason Gunthorpe" <jgg@ziepe.ca>,
"Leon Romanovsky" <leon@kernel.org>,
"Wolfgang Grandegger" <wg@grandegger.com>,
"Marc Kleine-Budde" <mkl@pengutronix.de>,
"David S. Miller" <davem@davemloft.net>,
"Paolo Abeni" <pabeni@redhat.com>,
"Chris Snook" <chris.snook@gmail.com>,
"Raju Rangoju" <rajur@chelsio.com>,
"Jeroen de Borst" <jeroendb@google.com>,
"Praveen Kaligineedi" <pkaligineedi@google.com>,
"Shailend Chand" <shailend@google.com>,
"Douglas Miller" <dougmill@linux.ibm.com>,
"Michael Ellerman" <mpe@ellerman.id.au>,
"Nicholas Piggin" <npiggin@gmail.com>,
"Christophe Leroy" <christophe.leroy@csgroup.eu>,
"Nick Child" <nnac123@linux.ibm.com>,
"Haren Myneni" <haren@linux.ibm.com>,
"Rick Lindsley" <ricklind@linux.ibm.com>,
"Dany Madden" <danymadden@us.ibm.com>,
"Thomas Falcon" <tlfalcon@linux.ibm.com>,
"Tariq Toukan" <tariqt@nvidia.com>,
"Alexandre Torgue" <alexandre.torgue@foss.st.com>,
"Jose Abreu" <joabreu@synopsys.com>,
"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
"Krzysztof Halasa" <khalasa@piap.pl>,
"Kalle Valo" <kvalo@kernel.org>,
"Jeff Johnson" <quic_jjohnson@quicinc.com>,
"Gregory Greenman" <gregory.greenman@intel.com>,
"Chandrashekar Devegowda" <chandrashekar.devegowda@intel.com>,
"Intel Corporation" <linuxwwan@intel.com>,
"Chiranjeevi Rapolu" <chiranjeevi.rapolu@linux.intel.com>,
"Liu Haijun" <haijun.liu@mediatek.com>,
"M Chetan Kumar" <m.chetan.kumar@linux.intel.com>,
"Ricardo Martinez" <ricardo.martinez@linux.intel.com>,
"Loic Poulain" <loic.poulain@linaro.org>,
"Sergey Ryazanov" <ryazanov.s.a@gmail.com>,
"Johannes Berg" <johannes@sipsolutions.net>,
"Yuanjun Gong" <ruc_gongyuanjun@163.com>,
"Simon Horman" <horms@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Ziwei Xiao" <ziweixiao@google.com>,
"Rushil Gupta" <rushilg@google.com>,
"Coco Li" <lixiaoyan@google.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Junfeng Guo" <junfeng.guo@intel.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Wei Fang" <wei.fang@nxp.com>,
"Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>,
"Yuri Karpov" <YKarpov@ispras.ru>,
"Zhengchao Shao" <shaozhengchao@huawei.com>,
"Andrew Lunn" <andrew@lunn.ch>,
"Zheng Zengkai" <zhengzengkai@huawei.com>,
"Lee Jones" <lee@kernel.org>,
"Maximilian Luz" <luzmaximilian@gmail.com>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
"Dawei Li" <set_pte_at@outlook.com>,
Anjaneyulu <pagadala.yesu.anjaneyulu@intel.com>,
"Benjamin Berg" <benjamin.berg@intel.com>,
linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-can@vger.kernel.org, netdev@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org, ath10k@lists.infradead.org,
linux-wireless@vger.kernel.org
Subject: Re: [net-next PATCH v2 3/4] netdev: replace napi_reschedule with napi_schedule
Date: Thu, 5 Oct 2023 09:32:53 -0700 [thread overview]
Message-ID: <20231005093253.2e25533a@kernel.org> (raw)
In-Reply-To: <CANn89iK226C-pHUJm7HKMyEtMycGC=KCA2M6kw2KJaUj0cCT6w@mail.gmail.com>
On Thu, 5 Oct 2023 18:11:56 +0200 Eric Dumazet wrote:
> OK, but I suspect some users of napi_reschedule() might not be race-free...
What's the race you're thinking of?
WARNING: multiple messages have this Message-ID (diff)
From: Jakub Kicinski <kuba@kernel.org>
To: Eric Dumazet <edumazet@google.com>
Cc: "Andrew Lunn" <andrew@lunn.ch>,
"Sergey Ryazanov" <ryazanov.s.a@gmail.com>,
"Ziwei Xiao" <ziweixiao@google.com>,
"Chris Snook" <chris.snook@gmail.com>,
"Rick Lindsley" <ricklind@linux.ibm.com>,
"Alexandre Torgue" <alexandre.torgue@foss.st.com>,
"Krzysztof Halasa" <khalasa@piap.pl>,
"Yuri Karpov" <YKarpov@ispras.ru>,
netdev@vger.kernel.org, ath10k@lists.infradead.org,
"Dany Madden" <danymadden@us.ibm.com>,
"Gregory Greenman" <gregory.greenman@intel.com>,
"Zhengchao Shao" <shaozhengchao@huawei.com>,
"Chiranjeevi Rapolu" <chiranjeevi.rapolu@linux.intel.com>,
"Dawei Li" <set_pte_at@outlook.com>,
"Intel Corporation" <linuxwwan@intel.com>,
"Rob Herring" <robh@kernel.org>,
"Jeroen de Borst" <jeroendb@google.com>,
"Leon Romanovsky" <leon@kernel.org>,
linux-rdma@vger.kernel.org, "Lee Jones" <lee@kernel.org>,
"Haren Myneni" <haren@linux.ibm.com>,
linux-stm32@st-md-mailman.stormreply.com,
"Rushil Gupta" <rushilg@google.com>,
"Jason Gunthorpe" <jgg@ziepe.ca>,
"Thomas Falcon" <tlfalcon@linux.ibm.com>,
"Jose Abreu" <joabreu@synopsys.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
linux-wireless@vger.kernel.org, "Paolo Abeni" <pabeni@redhat.com>,
"Wei Fang" <wei.fang@nxp.com>,
"Christian Marangi" <ansuelsmth@gmail.com>,
"Wolfgang Grandegger" <wg@grandegger.com>,
"Nick Child" <nnac123@linux.ibm.com>,
"Simon Horman" <horms@kernel.org>,
"Liu Haijun" <haijun.liu@mediatek.com>,
"Kalle Valo" <kvalo@kernel.org>,
linuxppc-dev@lists.ozlabs.org,
"Nicholas Piggin" <npiggin@gmail.com>,
linux-can@vger.kernel.org,
"Yuanjun Gong" <ruc_gongyuanjun@163.com>,
"Shailend Chand" <shailend@google.com>,
"Marc Kleine-Budde" <mkl@pengutronix.de>,
"Benjamin Berg" <benjamin.berg@intel.com>,
"M Chetan Kumar" <m.chetan.kumar@linux.intel.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Coco Li" <lixiaoyan@google.com>,
linux-arm-kernel@lists.infradead.org,
"Chandrashekar Devegowda" <chandrashekar.devegowda@intel.com>,
"Ricardo Martinez" <ricardo.martinez@linux.intel.com>,
"Loic Poulain" <loic.poulain@linaro.org>,
"Zheng Zengkai" <zhengzengkai@huawei.com>,
"Maxi milian Luz" <luzmaximilian@gmail.com>,
Anjaneyulu <pagadala.yesu.anjaneyulu@intel.com>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
"Douglas Miller" <dougmill@linux.ibm.com>,
linux-kernel@vger.kernel.org, "Tariq Toukan" <tariqt@nvidia.com>,
"Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>,
"Junfeng Guo" <junfeng.guo@intel.com>,
"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
"Raju Rangoju" <rajur@chelsio.com>,
"Praveen Kaligineedi" <pkaligineedi@google.com>,
"Johannes Berg" <johannes@sipsolutions.net>,
"Jeff Johnson" <quic_jjohnson@quicinc.com>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [net-next PATCH v2 3/4] netdev: replace napi_reschedule with napi_schedule
Date: Thu, 5 Oct 2023 09:32:53 -0700 [thread overview]
Message-ID: <20231005093253.2e25533a@kernel.org> (raw)
In-Reply-To: <CANn89iK226C-pHUJm7HKMyEtMycGC=KCA2M6kw2KJaUj0cCT6w@mail.gmail.com>
On Thu, 5 Oct 2023 18:11:56 +0200 Eric Dumazet wrote:
> OK, but I suspect some users of napi_reschedule() might not be race-free...
What's the race you're thinking of?
next prev parent reply other threads:[~2023-10-05 16:33 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-03 14:51 [net-next PATCH v2 1/4] netdev: replace simple napi_schedule_prep/__napi_schedule to napi_schedule Christian Marangi
2023-10-03 14:51 ` Christian Marangi
2023-10-03 14:51 ` [net-next PATCH v2 2/4] netdev: make napi_schedule return bool on NAPI successful schedule Christian Marangi
2023-10-03 14:51 ` Christian Marangi
2023-10-03 14:51 ` [net-next PATCH v2 3/4] netdev: replace napi_reschedule with napi_schedule Christian Marangi
2023-10-03 14:51 ` Christian Marangi
2023-10-05 16:11 ` Eric Dumazet
2023-10-05 16:11 ` Eric Dumazet
2023-10-05 16:11 ` Eric Dumazet
2023-10-05 16:32 ` Jakub Kicinski [this message]
2023-10-05 16:32 ` Jakub Kicinski
2023-10-05 16:32 ` Jakub Kicinski
2023-10-05 16:41 ` Eric Dumazet
2023-10-05 16:41 ` Eric Dumazet
2023-10-05 16:41 ` Eric Dumazet
2023-10-06 18:52 ` Christian Marangi
2023-10-06 18:52 ` Christian Marangi
2023-10-06 18:52 ` Christian Marangi
2023-10-08 7:00 ` Eric Dumazet
2023-10-08 7:00 ` Eric Dumazet
2023-10-08 7:00 ` Eric Dumazet
2023-10-03 14:51 ` [net-next PATCH v2 4/4] netdev: use napi_schedule bool instead of napi_schedule_prep/__napi_schedule Christian Marangi
2023-10-03 14:51 ` Christian Marangi
2023-10-05 16:16 ` Eric Dumazet
2023-10-05 16:16 ` Eric Dumazet
2023-10-05 16:16 ` Eric Dumazet
2023-10-06 18:49 ` Christian Marangi
2023-10-06 18:49 ` Christian Marangi
2023-10-06 18:49 ` Christian Marangi
2023-10-08 7:08 ` Eric Dumazet
2023-10-08 7:08 ` Eric Dumazet
2023-10-08 7:08 ` Eric Dumazet
2023-10-08 18:27 ` Christian Marangi
2023-10-08 18:27 ` Christian Marangi
2023-10-08 18:27 ` Christian Marangi
2023-10-09 8:27 ` Eric Dumazet
2023-10-09 8:27 ` Eric Dumazet
2023-10-09 8:27 ` Eric Dumazet
2023-10-05 16:09 ` [net-next PATCH v2 1/4] netdev: replace simple napi_schedule_prep/__napi_schedule to napi_schedule Eric Dumazet
2023-10-05 16:09 ` Eric Dumazet
2023-10-05 16:09 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231005093253.2e25533a@kernel.org \
--to=kuba@kernel.org \
--cc=YKarpov@ispras.ru \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew@lunn.ch \
--cc=ansuelsmth@gmail.com \
--cc=ath10k@lists.infradead.org \
--cc=benjamin.berg@intel.com \
--cc=chandrashekar.devegowda@intel.com \
--cc=chiranjeevi.rapolu@linux.intel.com \
--cc=chris.snook@gmail.com \
--cc=christophe.leroy@csgroup.eu \
--cc=danymadden@us.ibm.com \
--cc=davem@davemloft.net \
--cc=dougmill@linux.ibm.com \
--cc=edumazet@google.com \
--cc=gregory.greenman@intel.com \
--cc=haijun.liu@mediatek.com \
--cc=haren@linux.ibm.com \
--cc=horms@kernel.org \
--cc=jeroendb@google.com \
--cc=jgg@ziepe.ca \
--cc=joabreu@synopsys.com \
--cc=johannes@sipsolutions.net \
--cc=junfeng.guo@intel.com \
--cc=khalasa@piap.pl \
--cc=krzysztof.kozlowski@linaro.org \
--cc=kvalo@kernel.org \
--cc=lee@kernel.org \
--cc=leon@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=linuxwwan@intel.com \
--cc=lixiaoyan@google.com \
--cc=loic.poulain@linaro.org \
--cc=luzmaximilian@gmail.com \
--cc=m.chetan.kumar@linux.intel.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=mkl@pengutronix.de \
--cc=mpe@ellerman.id.au \
--cc=netdev@vger.kernel.org \
--cc=nnac123@linux.ibm.com \
--cc=npiggin@gmail.com \
--cc=pabeni@redhat.com \
--cc=pagadala.yesu.anjaneyulu@intel.com \
--cc=pkaligineedi@google.com \
--cc=quic_jjohnson@quicinc.com \
--cc=rafael.j.wysocki@intel.com \
--cc=rajur@chelsio.com \
--cc=ricardo.martinez@linux.intel.com \
--cc=ricklind@linux.ibm.com \
--cc=robh@kernel.org \
--cc=ruc_gongyuanjun@163.com \
--cc=rushilg@google.com \
--cc=ryazanov.s.a@gmail.com \
--cc=set_pte_at@outlook.com \
--cc=shailend@google.com \
--cc=shaozhengchao@huawei.com \
--cc=tariqt@nvidia.com \
--cc=tglx@linutronix.de \
--cc=tlfalcon@linux.ibm.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=wei.fang@nxp.com \
--cc=wg@grandegger.com \
--cc=zhengzengkai@huawei.com \
--cc=ziweixiao@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.