From: Bjorn Helgaas <helgaas@kernel.org>
To: Thomas Witt <kernel@witt.link>
Cc: "Mika Westerberg" <mika.westerberg@linux.intel.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Kuppuswamy Sathyanarayanan"
<sathyanarayanan.kuppuswamy@linux.intel.com>,
"Vidya Sagar" <vidyas@nvidia.com>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
"Kai-Heng Feng" <kai.heng.feng@canonical.com>,
"David E . Box" <david.e.box@linux.intel.com>,
"Tasev Nikola" <tasev.stefanoska@skynet.be>,
"Mark Enriquez" <enriquezmark36@gmail.com>,
"Koba Ko" <koba.ko@canonical.com>,
"Werner Sembach" <wse@tuxedocomputers.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"吳昊澄 Ricky" <ricky_wu@realtek.com>,
linux-pci@vger.kernel.org
Subject: Re: [PATCH v4] PCI/ASPM: Add back L1 PM Substate save and restore
Date: Thu, 5 Oct 2023 12:22:26 -0500 [thread overview]
Message-ID: <20231005172226.GA781644@bhelgaas> (raw)
In-Reply-To: <923d8df0-1112-aca9-8289-c6e2457298cd@witt.link>
On Thu, Oct 05, 2023 at 05:57:52PM +0200, Thomas Witt wrote:
> On 05/10/2023 17:30, Bjorn Helgaas wrote:
> ...
> > Right, without the denylist, I expect Thomas' TUXEDO to fail, but I
> > still hope we can figure out why. If we just keep it on the denylist,
> > that system will suffer from more power consumption than necessary,
> > but only after suspend/resume.
> >
> > A denylist seems like the absolute last resort. In this case we don't
> > know about anything *wrong* with those platforms; all we know is that
> > our resume path doesn't work. It's likely that it fails on other
> > platforms we haven't heard about, too.
>
> The best guess from Mika and David was a firmware issue, but I run the same
> Firmware revision as Werner. I even reflashed the Firmware, but that did not
> change anything:
Possibly a BIOS settings difference?
> Quoting David Box:
> > I agree that we should pursue an exception for your system. This is
> > looking like a firmware bug. One thing we did notice in the turbostat
> > results is your IRTL (Interrupt Response Time Limit) values are bogus:
> >
> > cpu6: MSR_PKGC3_IRTL: 0x0000884e (valid, 79872 ns)
> > cpu6: MSR_PKGC6_IRTL: 0x00008000 (valid, 0 ns)
> > cpu6: MSR_PKGC7_IRTL: 0x00008000 (valid, 0 ns)
> > cpu6: MSR_PKGC8_IRTL: 0x00008000 (valid, 0 ns)
> > cpu6: MSR_PKGC9_IRTL: 0x00008000 (valid, 0 ns)
> > cpu6: MSR_PKGC10_IRTL: 0x00008000 (valid, 0 ns)
> >
> > This is despite the PKGC configuration register showing that all
> > states are enabled:
> >
> > cpu6: MSR_PKG_CST_CONFIG_CONTROL: 0x1e008008 (UNdemote-C3, UNdemote-C1,
> demote-
> C3, demote-C1, locked, pkg-cstate-limit=8 (unlimited))
> >
> > Firmware sets this.
I can't find this discussion, but if there's a firmware issue related
to IRTL MSRs, I would want the workaround in intel-idle.c or whatever
code deals with the MSRs, not in the ASPM code.
Bjorn
next prev parent reply other threads:[~2023-10-05 17:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-02 7:00 [PATCH v4] PCI/ASPM: Add back L1 PM Substate save and restore Mika Westerberg
2023-10-04 22:23 ` Bjorn Helgaas
2023-10-05 9:02 ` Mika Westerberg
2023-10-05 15:30 ` Bjorn Helgaas
2023-10-05 15:57 ` Thomas Witt
2023-10-05 17:22 ` Bjorn Helgaas [this message]
2023-10-09 8:34 ` Mika Westerberg
2023-10-09 16:34 ` Bjorn Helgaas
2023-10-09 22:57 ` David E. Box
2023-10-10 4:53 ` Mika Westerberg
2023-11-03 19:51 ` David E. Box
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231005172226.GA781644@bhelgaas \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=david.e.box@linux.intel.com \
--cc=enriquezmark36@gmail.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=kai.heng.feng@canonical.com \
--cc=kernel@witt.link \
--cc=koba.ko@canonical.com \
--cc=linux-pci@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=rafael.j.wysocki@intel.com \
--cc=ricky_wu@realtek.com \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
--cc=tasev.stefanoska@skynet.be \
--cc=vidyas@nvidia.com \
--cc=wse@tuxedocomputers.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.