* [PATCH for-4.18] x86/memshr: Fix build in copy_vcpu_settings()
@ 2023-10-06 13:57 Andrew Cooper
2023-10-06 14:01 ` Henry Wang
2023-10-06 14:08 ` Roger Pau Monné
0 siblings, 2 replies; 3+ messages in thread
From: Andrew Cooper @ 2023-10-06 13:57 UTC (permalink / raw)
To: Xen-devel
Cc: Andrew Cooper, Jan Beulich, Roger Pau Monné, Wei Liu,
Tamas K Lengyel, Henry Wang
The last user of this variable was dropped.
Fixes: 295514ff7550 ("common: convert vCPU info area registration")
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Jan Beulich <JBeulich@suse.com>
CC: Roger Pau Monné <roger.pau@citrix.com>
CC: Wei Liu <wl@xen.org>
CC: Tamas K Lengyel <tamas@tklengyel.com>
CC: Henry Wang <Henry.Wang@arm.com>
I expect Gitlab randconfig to find this eventually, but it does depend on
CONFIG_MEM_SHARING being active to manifest.
---
xen/arch/x86/mm/mem_sharing.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/xen/arch/x86/mm/mem_sharing.c b/xen/arch/x86/mm/mem_sharing.c
index 5217c755a299..94b6b782ef2e 100644
--- a/xen/arch/x86/mm/mem_sharing.c
+++ b/xen/arch/x86/mm/mem_sharing.c
@@ -1706,7 +1706,6 @@ static int copy_vcpu_settings(struct domain *cd, const struct domain *d)
{
unsigned int i;
int ret = -EINVAL;
- mfn_t vcpu_info_mfn;
for ( i = 0; i < cd->max_vcpus; i++ )
{
--
2.30.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH for-4.18] x86/memshr: Fix build in copy_vcpu_settings()
2023-10-06 13:57 [PATCH for-4.18] x86/memshr: Fix build in copy_vcpu_settings() Andrew Cooper
@ 2023-10-06 14:01 ` Henry Wang
2023-10-06 14:08 ` Roger Pau Monné
1 sibling, 0 replies; 3+ messages in thread
From: Henry Wang @ 2023-10-06 14:01 UTC (permalink / raw)
To: Andrew Cooper
Cc: Xen-devel, Jan Beulich, Roger Pau Monné, Wei Liu,
Tamas K Lengyel
Hi Andrew,
> On Oct 6, 2023, at 21:57, Andrew Cooper <andrew.cooper3@citrix.com> wrote:
>
> The last user of this variable was dropped.
>
> Fixes: 295514ff7550 ("common: convert vCPU info area registration")
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Release-acked-by: Henry Wang <Henry.Wang@arm.com>
Kind regards,
Henry
> ---
> CC: Jan Beulich <JBeulich@suse.com>
> CC: Roger Pau Monné <roger.pau@citrix.com>
> CC: Wei Liu <wl@xen.org>
> CC: Tamas K Lengyel <tamas@tklengyel.com>
> CC: Henry Wang <Henry.Wang@arm.com>
>
> I expect Gitlab randconfig to find this eventually, but it does depend on
> CONFIG_MEM_SHARING being active to manifest.
> ---
> xen/arch/x86/mm/mem_sharing.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/xen/arch/x86/mm/mem_sharing.c b/xen/arch/x86/mm/mem_sharing.c
> index 5217c755a299..94b6b782ef2e 100644
> --- a/xen/arch/x86/mm/mem_sharing.c
> +++ b/xen/arch/x86/mm/mem_sharing.c
> @@ -1706,7 +1706,6 @@ static int copy_vcpu_settings(struct domain *cd, const struct domain *d)
> {
> unsigned int i;
> int ret = -EINVAL;
> - mfn_t vcpu_info_mfn;
>
> for ( i = 0; i < cd->max_vcpus; i++ )
> {
> --
> 2.30.2
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH for-4.18] x86/memshr: Fix build in copy_vcpu_settings()
2023-10-06 13:57 [PATCH for-4.18] x86/memshr: Fix build in copy_vcpu_settings() Andrew Cooper
2023-10-06 14:01 ` Henry Wang
@ 2023-10-06 14:08 ` Roger Pau Monné
1 sibling, 0 replies; 3+ messages in thread
From: Roger Pau Monné @ 2023-10-06 14:08 UTC (permalink / raw)
To: Andrew Cooper
Cc: Xen-devel, Jan Beulich, Wei Liu, Tamas K Lengyel, Henry Wang
On Fri, Oct 06, 2023 at 02:57:45PM +0100, Andrew Cooper wrote:
> The last user of this variable was dropped.
>
> Fixes: 295514ff7550 ("common: convert vCPU info area registration")
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>
Thanks for noticing this.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-10-06 14:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-06 13:57 [PATCH for-4.18] x86/memshr: Fix build in copy_vcpu_settings() Andrew Cooper
2023-10-06 14:01 ` Henry Wang
2023-10-06 14:08 ` Roger Pau Monné
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.