* [PATCH 0/3] nvmem: imx: correct nregs for i.MX6UL/ULL/SLL
@ 2023-10-08 8:10 ` Peng Fan (OSS)
0 siblings, 0 replies; 15+ messages in thread
From: Peng Fan (OSS) @ 2023-10-08 8:10 UTC (permalink / raw)
To: Srinivas Kandagatla, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team,
Anson Huang, Greg Kroah-Hartman, Bai Ping, Stefan Wahren
Cc: linux-arm-kernel, linux-kernel, Peng Fan
The current code does not include the register space hole, after check
the fuse map of the three SoCs, update the nregs to fix the issue.
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
Peng Fan (3):
nvmem: imx: correct nregs for i.MX6SLL
nvmem: imx: correct nregs for i.MX6UL
nvmem: imx: correct nregs for i.MX6ULL
drivers/nvmem/imx-ocotp.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
---
base-commit: 0f0fe5040de5e5fd9b040672e37725b046e312f0
change-id: 20231008-nvmem-imx-1af696badaf5
Best regards,
--
Peng Fan <peng.fan@nxp.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 15+ messages in thread* [PATCH 0/3] nvmem: imx: correct nregs for i.MX6UL/ULL/SLL @ 2023-10-08 8:10 ` Peng Fan (OSS) 0 siblings, 0 replies; 15+ messages in thread From: Peng Fan (OSS) @ 2023-10-08 8:10 UTC (permalink / raw) To: Srinivas Kandagatla, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team, Anson Huang, Greg Kroah-Hartman, Bai Ping, Stefan Wahren Cc: linux-arm-kernel, linux-kernel, Peng Fan The current code does not include the register space hole, after check the fuse map of the three SoCs, update the nregs to fix the issue. Signed-off-by: Peng Fan <peng.fan@nxp.com> --- Peng Fan (3): nvmem: imx: correct nregs for i.MX6SLL nvmem: imx: correct nregs for i.MX6UL nvmem: imx: correct nregs for i.MX6ULL drivers/nvmem/imx-ocotp.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) --- base-commit: 0f0fe5040de5e5fd9b040672e37725b046e312f0 change-id: 20231008-nvmem-imx-1af696badaf5 Best regards, -- Peng Fan <peng.fan@nxp.com> ^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH 1/3] nvmem: imx: correct nregs for i.MX6SLL 2023-10-08 8:10 ` Peng Fan (OSS) @ 2023-10-08 8:10 ` Peng Fan (OSS) -1 siblings, 0 replies; 15+ messages in thread From: Peng Fan (OSS) @ 2023-10-08 8:10 UTC (permalink / raw) To: Srinivas Kandagatla, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team, Anson Huang, Greg Kroah-Hartman, Bai Ping, Stefan Wahren Cc: linux-arm-kernel, linux-kernel, Peng Fan From: Peng Fan <peng.fan@nxp.com> The nregs for i.MX6SLL should be 80 per fuse map, correct it. Fixes: 6da27821a6f5 ("nvmem: imx-ocotp: add support for imx6sll") Signed-off-by: Peng Fan <peng.fan@nxp.com> --- drivers/nvmem/imx-ocotp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/nvmem/imx-ocotp.c b/drivers/nvmem/imx-ocotp.c index 434f197e27bf..c59cfe13a5f8 100644 --- a/drivers/nvmem/imx-ocotp.c +++ b/drivers/nvmem/imx-ocotp.c @@ -498,7 +498,7 @@ static const struct ocotp_params imx6sl_params = { }; static const struct ocotp_params imx6sll_params = { - .nregs = 128, + .nregs = 80, .bank_address_words = 0, .set_timing = imx_ocotp_set_imx6_timing, .ctrl = IMX_OCOTP_BM_CTRL_DEFAULT, -- 2.37.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH 1/3] nvmem: imx: correct nregs for i.MX6SLL @ 2023-10-08 8:10 ` Peng Fan (OSS) 0 siblings, 0 replies; 15+ messages in thread From: Peng Fan (OSS) @ 2023-10-08 8:10 UTC (permalink / raw) To: Srinivas Kandagatla, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team, Anson Huang, Greg Kroah-Hartman, Bai Ping, Stefan Wahren Cc: linux-arm-kernel, linux-kernel, Peng Fan From: Peng Fan <peng.fan@nxp.com> The nregs for i.MX6SLL should be 80 per fuse map, correct it. Fixes: 6da27821a6f5 ("nvmem: imx-ocotp: add support for imx6sll") Signed-off-by: Peng Fan <peng.fan@nxp.com> --- drivers/nvmem/imx-ocotp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/nvmem/imx-ocotp.c b/drivers/nvmem/imx-ocotp.c index 434f197e27bf..c59cfe13a5f8 100644 --- a/drivers/nvmem/imx-ocotp.c +++ b/drivers/nvmem/imx-ocotp.c @@ -498,7 +498,7 @@ static const struct ocotp_params imx6sl_params = { }; static const struct ocotp_params imx6sll_params = { - .nregs = 128, + .nregs = 80, .bank_address_words = 0, .set_timing = imx_ocotp_set_imx6_timing, .ctrl = IMX_OCOTP_BM_CTRL_DEFAULT, -- 2.37.1 ^ permalink raw reply related [flat|nested] 15+ messages in thread
* Re: [PATCH 1/3] nvmem: imx: correct nregs for i.MX6SLL 2023-10-08 8:10 ` Peng Fan (OSS) @ 2023-10-08 13:07 ` Greg Kroah-Hartman -1 siblings, 0 replies; 15+ messages in thread From: Greg Kroah-Hartman @ 2023-10-08 13:07 UTC (permalink / raw) To: Peng Fan (OSS) Cc: Srinivas Kandagatla, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team, Anson Huang, Bai Ping, Stefan Wahren, linux-arm-kernel, linux-kernel, Peng Fan On Sun, Oct 08, 2023 at 04:10:20PM +0800, Peng Fan (OSS) wrote: > From: Peng Fan <peng.fan@nxp.com> > > The nregs for i.MX6SLL should be 80 per fuse map, correct it. > > Fixes: 6da27821a6f5 ("nvmem: imx-ocotp: add support for imx6sll") > Signed-off-by: Peng Fan <peng.fan@nxp.com> > --- > drivers/nvmem/imx-ocotp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/nvmem/imx-ocotp.c b/drivers/nvmem/imx-ocotp.c > index 434f197e27bf..c59cfe13a5f8 100644 > --- a/drivers/nvmem/imx-ocotp.c > +++ b/drivers/nvmem/imx-ocotp.c > @@ -498,7 +498,7 @@ static const struct ocotp_params imx6sl_params = { > }; > > static const struct ocotp_params imx6sll_params = { > - .nregs = 128, > + .nregs = 80, > .bank_address_words = 0, > .set_timing = imx_ocotp_set_imx6_timing, > .ctrl = IMX_OCOTP_BM_CTRL_DEFAULT, > > -- > 2.37.1 > Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree. You are receiving this message because of the following common error(s) as indicated below: - You have marked a patch with a "Fixes:" tag for a commit that is in an older released kernel, yet you do not have a cc: stable line in the signed-off-by area at all, which means that the patch will not be applied to any older kernel releases. To properly fix this, please follow the documented rules in the Documentation/process/stable-kernel-rules.rst file for how to resolve this. If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers. thanks, greg k-h's patch email bot _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH 1/3] nvmem: imx: correct nregs for i.MX6SLL @ 2023-10-08 13:07 ` Greg Kroah-Hartman 0 siblings, 0 replies; 15+ messages in thread From: Greg Kroah-Hartman @ 2023-10-08 13:07 UTC (permalink / raw) To: Peng Fan (OSS) Cc: Srinivas Kandagatla, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team, Anson Huang, Bai Ping, Stefan Wahren, linux-arm-kernel, linux-kernel, Peng Fan On Sun, Oct 08, 2023 at 04:10:20PM +0800, Peng Fan (OSS) wrote: > From: Peng Fan <peng.fan@nxp.com> > > The nregs for i.MX6SLL should be 80 per fuse map, correct it. > > Fixes: 6da27821a6f5 ("nvmem: imx-ocotp: add support for imx6sll") > Signed-off-by: Peng Fan <peng.fan@nxp.com> > --- > drivers/nvmem/imx-ocotp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/nvmem/imx-ocotp.c b/drivers/nvmem/imx-ocotp.c > index 434f197e27bf..c59cfe13a5f8 100644 > --- a/drivers/nvmem/imx-ocotp.c > +++ b/drivers/nvmem/imx-ocotp.c > @@ -498,7 +498,7 @@ static const struct ocotp_params imx6sl_params = { > }; > > static const struct ocotp_params imx6sll_params = { > - .nregs = 128, > + .nregs = 80, > .bank_address_words = 0, > .set_timing = imx_ocotp_set_imx6_timing, > .ctrl = IMX_OCOTP_BM_CTRL_DEFAULT, > > -- > 2.37.1 > Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree. You are receiving this message because of the following common error(s) as indicated below: - You have marked a patch with a "Fixes:" tag for a commit that is in an older released kernel, yet you do not have a cc: stable line in the signed-off-by area at all, which means that the patch will not be applied to any older kernel releases. To properly fix this, please follow the documented rules in the Documentation/process/stable-kernel-rules.rst file for how to resolve this. If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers. thanks, greg k-h's patch email bot ^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH 2/3] nvmem: imx: correct nregs for i.MX6UL 2023-10-08 8:10 ` Peng Fan (OSS) @ 2023-10-08 8:10 ` Peng Fan (OSS) -1 siblings, 0 replies; 15+ messages in thread From: Peng Fan (OSS) @ 2023-10-08 8:10 UTC (permalink / raw) To: Srinivas Kandagatla, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team, Anson Huang, Greg Kroah-Hartman, Bai Ping, Stefan Wahren Cc: linux-arm-kernel, linux-kernel, Peng Fan From: Peng Fan <peng.fan@nxp.com> The nregs for i.MX6UL should be 144 per fuse map, correct it. Fixes: 4aa2b4802046 ("nvmem: octop: Add support for imx6ul") Signed-off-by: Peng Fan <peng.fan@nxp.com> --- drivers/nvmem/imx-ocotp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/nvmem/imx-ocotp.c b/drivers/nvmem/imx-ocotp.c index c59cfe13a5f8..8d30c8bfdbcf 100644 --- a/drivers/nvmem/imx-ocotp.c +++ b/drivers/nvmem/imx-ocotp.c @@ -512,7 +512,7 @@ static const struct ocotp_params imx6sx_params = { }; static const struct ocotp_params imx6ul_params = { - .nregs = 128, + .nregs = 144, .bank_address_words = 0, .set_timing = imx_ocotp_set_imx6_timing, .ctrl = IMX_OCOTP_BM_CTRL_DEFAULT, -- 2.37.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH 2/3] nvmem: imx: correct nregs for i.MX6UL @ 2023-10-08 8:10 ` Peng Fan (OSS) 0 siblings, 0 replies; 15+ messages in thread From: Peng Fan (OSS) @ 2023-10-08 8:10 UTC (permalink / raw) To: Srinivas Kandagatla, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team, Anson Huang, Greg Kroah-Hartman, Bai Ping, Stefan Wahren Cc: linux-arm-kernel, linux-kernel, Peng Fan From: Peng Fan <peng.fan@nxp.com> The nregs for i.MX6UL should be 144 per fuse map, correct it. Fixes: 4aa2b4802046 ("nvmem: octop: Add support for imx6ul") Signed-off-by: Peng Fan <peng.fan@nxp.com> --- drivers/nvmem/imx-ocotp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/nvmem/imx-ocotp.c b/drivers/nvmem/imx-ocotp.c index c59cfe13a5f8..8d30c8bfdbcf 100644 --- a/drivers/nvmem/imx-ocotp.c +++ b/drivers/nvmem/imx-ocotp.c @@ -512,7 +512,7 @@ static const struct ocotp_params imx6sx_params = { }; static const struct ocotp_params imx6ul_params = { - .nregs = 128, + .nregs = 144, .bank_address_words = 0, .set_timing = imx_ocotp_set_imx6_timing, .ctrl = IMX_OCOTP_BM_CTRL_DEFAULT, -- 2.37.1 ^ permalink raw reply related [flat|nested] 15+ messages in thread
* Re: [PATCH 2/3] nvmem: imx: correct nregs for i.MX6UL 2023-10-08 8:10 ` Peng Fan (OSS) @ 2023-10-08 13:07 ` Greg Kroah-Hartman -1 siblings, 0 replies; 15+ messages in thread From: Greg Kroah-Hartman @ 2023-10-08 13:07 UTC (permalink / raw) To: Peng Fan (OSS) Cc: Srinivas Kandagatla, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team, Anson Huang, Bai Ping, Stefan Wahren, linux-arm-kernel, linux-kernel, Peng Fan On Sun, Oct 08, 2023 at 04:10:21PM +0800, Peng Fan (OSS) wrote: > From: Peng Fan <peng.fan@nxp.com> > > The nregs for i.MX6UL should be 144 per fuse map, correct it. > > Fixes: 4aa2b4802046 ("nvmem: octop: Add support for imx6ul") > Signed-off-by: Peng Fan <peng.fan@nxp.com> > --- > drivers/nvmem/imx-ocotp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/nvmem/imx-ocotp.c b/drivers/nvmem/imx-ocotp.c > index c59cfe13a5f8..8d30c8bfdbcf 100644 > --- a/drivers/nvmem/imx-ocotp.c > +++ b/drivers/nvmem/imx-ocotp.c > @@ -512,7 +512,7 @@ static const struct ocotp_params imx6sx_params = { > }; > > static const struct ocotp_params imx6ul_params = { > - .nregs = 128, > + .nregs = 144, > .bank_address_words = 0, > .set_timing = imx_ocotp_set_imx6_timing, > .ctrl = IMX_OCOTP_BM_CTRL_DEFAULT, > > -- > 2.37.1 > Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree. You are receiving this message because of the following common error(s) as indicated below: - You have marked a patch with a "Fixes:" tag for a commit that is in an older released kernel, yet you do not have a cc: stable line in the signed-off-by area at all, which means that the patch will not be applied to any older kernel releases. To properly fix this, please follow the documented rules in the Documentation/process/stable-kernel-rules.rst file for how to resolve this. If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers. thanks, greg k-h's patch email bot _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH 2/3] nvmem: imx: correct nregs for i.MX6UL @ 2023-10-08 13:07 ` Greg Kroah-Hartman 0 siblings, 0 replies; 15+ messages in thread From: Greg Kroah-Hartman @ 2023-10-08 13:07 UTC (permalink / raw) To: Peng Fan (OSS) Cc: Srinivas Kandagatla, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team, Anson Huang, Bai Ping, Stefan Wahren, linux-arm-kernel, linux-kernel, Peng Fan On Sun, Oct 08, 2023 at 04:10:21PM +0800, Peng Fan (OSS) wrote: > From: Peng Fan <peng.fan@nxp.com> > > The nregs for i.MX6UL should be 144 per fuse map, correct it. > > Fixes: 4aa2b4802046 ("nvmem: octop: Add support for imx6ul") > Signed-off-by: Peng Fan <peng.fan@nxp.com> > --- > drivers/nvmem/imx-ocotp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/nvmem/imx-ocotp.c b/drivers/nvmem/imx-ocotp.c > index c59cfe13a5f8..8d30c8bfdbcf 100644 > --- a/drivers/nvmem/imx-ocotp.c > +++ b/drivers/nvmem/imx-ocotp.c > @@ -512,7 +512,7 @@ static const struct ocotp_params imx6sx_params = { > }; > > static const struct ocotp_params imx6ul_params = { > - .nregs = 128, > + .nregs = 144, > .bank_address_words = 0, > .set_timing = imx_ocotp_set_imx6_timing, > .ctrl = IMX_OCOTP_BM_CTRL_DEFAULT, > > -- > 2.37.1 > Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree. You are receiving this message because of the following common error(s) as indicated below: - You have marked a patch with a "Fixes:" tag for a commit that is in an older released kernel, yet you do not have a cc: stable line in the signed-off-by area at all, which means that the patch will not be applied to any older kernel releases. To properly fix this, please follow the documented rules in the Documentation/process/stable-kernel-rules.rst file for how to resolve this. If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers. thanks, greg k-h's patch email bot ^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH 3/3] nvmem: imx: correct nregs for i.MX6ULL 2023-10-08 8:10 ` Peng Fan (OSS) @ 2023-10-08 8:10 ` Peng Fan (OSS) -1 siblings, 0 replies; 15+ messages in thread From: Peng Fan (OSS) @ 2023-10-08 8:10 UTC (permalink / raw) To: Srinivas Kandagatla, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team, Anson Huang, Greg Kroah-Hartman, Bai Ping, Stefan Wahren Cc: linux-arm-kernel, linux-kernel, Peng Fan From: Peng Fan <peng.fan@nxp.com> The nregs for i.MX6ULL should be 80 per fuse map, correct it. Fixes: ffbc34bf0e9c ("nvmem: imx-ocotp: Implement i.MX6ULL/ULZ support") Signed-off-by: Peng Fan <peng.fan@nxp.com> --- drivers/nvmem/imx-ocotp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/nvmem/imx-ocotp.c b/drivers/nvmem/imx-ocotp.c index 8d30c8bfdbcf..f1e202efaa49 100644 --- a/drivers/nvmem/imx-ocotp.c +++ b/drivers/nvmem/imx-ocotp.c @@ -519,7 +519,7 @@ static const struct ocotp_params imx6ul_params = { }; static const struct ocotp_params imx6ull_params = { - .nregs = 64, + .nregs = 80, .bank_address_words = 0, .set_timing = imx_ocotp_set_imx6_timing, .ctrl = IMX_OCOTP_BM_CTRL_DEFAULT, -- 2.37.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH 3/3] nvmem: imx: correct nregs for i.MX6ULL @ 2023-10-08 8:10 ` Peng Fan (OSS) 0 siblings, 0 replies; 15+ messages in thread From: Peng Fan (OSS) @ 2023-10-08 8:10 UTC (permalink / raw) To: Srinivas Kandagatla, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team, Anson Huang, Greg Kroah-Hartman, Bai Ping, Stefan Wahren Cc: linux-arm-kernel, linux-kernel, Peng Fan From: Peng Fan <peng.fan@nxp.com> The nregs for i.MX6ULL should be 80 per fuse map, correct it. Fixes: ffbc34bf0e9c ("nvmem: imx-ocotp: Implement i.MX6ULL/ULZ support") Signed-off-by: Peng Fan <peng.fan@nxp.com> --- drivers/nvmem/imx-ocotp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/nvmem/imx-ocotp.c b/drivers/nvmem/imx-ocotp.c index 8d30c8bfdbcf..f1e202efaa49 100644 --- a/drivers/nvmem/imx-ocotp.c +++ b/drivers/nvmem/imx-ocotp.c @@ -519,7 +519,7 @@ static const struct ocotp_params imx6ul_params = { }; static const struct ocotp_params imx6ull_params = { - .nregs = 64, + .nregs = 80, .bank_address_words = 0, .set_timing = imx_ocotp_set_imx6_timing, .ctrl = IMX_OCOTP_BM_CTRL_DEFAULT, -- 2.37.1 ^ permalink raw reply related [flat|nested] 15+ messages in thread
* Re: [PATCH 3/3] nvmem: imx: correct nregs for i.MX6ULL 2023-10-08 8:10 ` Peng Fan (OSS) @ 2023-10-08 13:08 ` Greg Kroah-Hartman -1 siblings, 0 replies; 15+ messages in thread From: Greg Kroah-Hartman @ 2023-10-08 13:08 UTC (permalink / raw) To: Peng Fan (OSS) Cc: Srinivas Kandagatla, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team, Anson Huang, Bai Ping, Stefan Wahren, linux-arm-kernel, linux-kernel, Peng Fan On Sun, Oct 08, 2023 at 04:10:22PM +0800, Peng Fan (OSS) wrote: > From: Peng Fan <peng.fan@nxp.com> > > The nregs for i.MX6ULL should be 80 per fuse map, correct it. > > Fixes: ffbc34bf0e9c ("nvmem: imx-ocotp: Implement i.MX6ULL/ULZ support") > Signed-off-by: Peng Fan <peng.fan@nxp.com> > --- > drivers/nvmem/imx-ocotp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/nvmem/imx-ocotp.c b/drivers/nvmem/imx-ocotp.c > index 8d30c8bfdbcf..f1e202efaa49 100644 > --- a/drivers/nvmem/imx-ocotp.c > +++ b/drivers/nvmem/imx-ocotp.c > @@ -519,7 +519,7 @@ static const struct ocotp_params imx6ul_params = { > }; > > static const struct ocotp_params imx6ull_params = { > - .nregs = 64, > + .nregs = 80, > .bank_address_words = 0, > .set_timing = imx_ocotp_set_imx6_timing, > .ctrl = IMX_OCOTP_BM_CTRL_DEFAULT, > > -- > 2.37.1 > Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree. You are receiving this message because of the following common error(s) as indicated below: - Your patch breaks the build. - Your patch contains warnings and/or errors noticed by the scripts/checkpatch.pl tool. - Your patch is malformed (tabs converted to spaces, linewrapped, etc.) and can not be applied. Please read the file, Documentation/process/email-clients.rst in order to fix this. - Your patch was attached, please place it inline so that it can be applied directly from the email message itself. - Your patch does not have a Signed-off-by: line. Please read the kernel file, Documentation/process/submitting-patches.rst and resend it after adding that line. Note, the line needs to be in the body of the email, before the patch, not at the bottom of the patch or in the email signature. - Your patch was sent privately to Greg. Kernel development is done in public, please always cc: a public mailing list with a patch submission. Using the tool, scripts/get_maintainer.pl on the patch will tell you what mailing list to cc. - Your patch did many different things all at once, making it difficult to review. All Linux kernel patches need to only do one thing at a time. If you need to do multiple things (such as clean up all coding style issues in a file/driver), do it in a sequence of patches, each one doing only one thing. This will make it easier to review the patches to ensure that they are correct, and to help alleviate any merge issues that larger patches can cause. - Your patch did not apply to any known trees that Greg is in control of. Possibly this is because you made it against Linus's tree, not the linux-next tree, which is where all of the development for the next version of the kernel is at. Please refresh your patch against the linux-next tree, or even better yet, the development tree specified in the MAINTAINERS file for the subsystem you are submitting a patch for, and resend it. - You sent multiple patches, yet no indication of which ones should be applied in which order. Greg could just guess, but if you are receiving this email, he guessed wrong and the patches didn't apply. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/process/submitting-patches.rst for a description of how to do this so that Greg has a chance to apply these correctly. - You did not specify a description of why the patch is needed, or possibly, any description at all, in the email body. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/process/submitting-patches.rst for what is needed in order to properly describe the change. - You did not write a descriptive Subject: for the patch, allowing Greg, and everyone else, to know what this patch is all about. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/process/submitting-patches.rst for what a proper Subject: line should look like. - It looks like you did not use your "real" name for the patch on either the Signed-off-by: line, or the From: line (both of which have to match). Please read the kernel file, Documentation/process/submitting-patches.rst for how to do this correctly. - This looks like a new version of a previously submitted patch, but you did not list below the --- line any changes from the previous version. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/process/submitting-patches.rst for what needs to be done here to properly describe this. - You sent a patch that has been sent multiple times in the past few days, and is identical to ones that has been recently rejected. Please always look at the mailing list traffic to determine if you are duplicating other people's work. - You have marked a patch with a "Fixes:" tag for a commit that is in an older released kernel, yet you do not have a cc: stable line in the signed-off-by area at all, which means that the patch will not be applied to any older kernel releases. To properly fix this, please follow the documented rules in the Documetnation/process/stable-kernel-rules.rst file for how to resolve this. If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers. thanks, greg k-h's patch email bot _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH 3/3] nvmem: imx: correct nregs for i.MX6ULL @ 2023-10-08 13:08 ` Greg Kroah-Hartman 0 siblings, 0 replies; 15+ messages in thread From: Greg Kroah-Hartman @ 2023-10-08 13:08 UTC (permalink / raw) To: Peng Fan (OSS) Cc: Srinivas Kandagatla, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team, Anson Huang, Bai Ping, Stefan Wahren, linux-arm-kernel, linux-kernel, Peng Fan On Sun, Oct 08, 2023 at 04:10:22PM +0800, Peng Fan (OSS) wrote: > From: Peng Fan <peng.fan@nxp.com> > > The nregs for i.MX6ULL should be 80 per fuse map, correct it. > > Fixes: ffbc34bf0e9c ("nvmem: imx-ocotp: Implement i.MX6ULL/ULZ support") > Signed-off-by: Peng Fan <peng.fan@nxp.com> > --- > drivers/nvmem/imx-ocotp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/nvmem/imx-ocotp.c b/drivers/nvmem/imx-ocotp.c > index 8d30c8bfdbcf..f1e202efaa49 100644 > --- a/drivers/nvmem/imx-ocotp.c > +++ b/drivers/nvmem/imx-ocotp.c > @@ -519,7 +519,7 @@ static const struct ocotp_params imx6ul_params = { > }; > > static const struct ocotp_params imx6ull_params = { > - .nregs = 64, > + .nregs = 80, > .bank_address_words = 0, > .set_timing = imx_ocotp_set_imx6_timing, > .ctrl = IMX_OCOTP_BM_CTRL_DEFAULT, > > -- > 2.37.1 > Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree. You are receiving this message because of the following common error(s) as indicated below: - Your patch breaks the build. - Your patch contains warnings and/or errors noticed by the scripts/checkpatch.pl tool. - Your patch is malformed (tabs converted to spaces, linewrapped, etc.) and can not be applied. Please read the file, Documentation/process/email-clients.rst in order to fix this. - Your patch was attached, please place it inline so that it can be applied directly from the email message itself. - Your patch does not have a Signed-off-by: line. Please read the kernel file, Documentation/process/submitting-patches.rst and resend it after adding that line. Note, the line needs to be in the body of the email, before the patch, not at the bottom of the patch or in the email signature. - Your patch was sent privately to Greg. Kernel development is done in public, please always cc: a public mailing list with a patch submission. Using the tool, scripts/get_maintainer.pl on the patch will tell you what mailing list to cc. - Your patch did many different things all at once, making it difficult to review. All Linux kernel patches need to only do one thing at a time. If you need to do multiple things (such as clean up all coding style issues in a file/driver), do it in a sequence of patches, each one doing only one thing. This will make it easier to review the patches to ensure that they are correct, and to help alleviate any merge issues that larger patches can cause. - Your patch did not apply to any known trees that Greg is in control of. Possibly this is because you made it against Linus's tree, not the linux-next tree, which is where all of the development for the next version of the kernel is at. Please refresh your patch against the linux-next tree, or even better yet, the development tree specified in the MAINTAINERS file for the subsystem you are submitting a patch for, and resend it. - You sent multiple patches, yet no indication of which ones should be applied in which order. Greg could just guess, but if you are receiving this email, he guessed wrong and the patches didn't apply. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/process/submitting-patches.rst for a description of how to do this so that Greg has a chance to apply these correctly. - You did not specify a description of why the patch is needed, or possibly, any description at all, in the email body. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/process/submitting-patches.rst for what is needed in order to properly describe the change. - You did not write a descriptive Subject: for the patch, allowing Greg, and everyone else, to know what this patch is all about. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/process/submitting-patches.rst for what a proper Subject: line should look like. - It looks like you did not use your "real" name for the patch on either the Signed-off-by: line, or the From: line (both of which have to match). Please read the kernel file, Documentation/process/submitting-patches.rst for how to do this correctly. - This looks like a new version of a previously submitted patch, but you did not list below the --- line any changes from the previous version. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/process/submitting-patches.rst for what needs to be done here to properly describe this. - You sent a patch that has been sent multiple times in the past few days, and is identical to ones that has been recently rejected. Please always look at the mailing list traffic to determine if you are duplicating other people's work. - You have marked a patch with a "Fixes:" tag for a commit that is in an older released kernel, yet you do not have a cc: stable line in the signed-off-by area at all, which means that the patch will not be applied to any older kernel releases. To properly fix this, please follow the documented rules in the Documetnation/process/stable-kernel-rules.rst file for how to resolve this. If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers. thanks, greg k-h's patch email bot ^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH 0/3] nvmem: fixes for v6.6 @ 2023-10-13 12:49 srinivas.kandagatla 2023-10-13 12:49 ` [PATCH 1/3] nvmem: imx: correct nregs for i.MX6SLL srinivas.kandagatla 0 siblings, 1 reply; 15+ messages in thread From: srinivas.kandagatla @ 2023-10-13 12:49 UTC (permalink / raw) To: gregkh; +Cc: linux-kernel, Srinivas Kandagatla From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> Hi Greg, Here are some fixes in nvmem mostly around imx register count. Can you please apply them for v6.6 thanks, Srini Peng Fan (3): nvmem: imx: correct nregs for i.MX6SLL nvmem: imx: correct nregs for i.MX6UL nvmem: imx: correct nregs for i.MX6ULL drivers/nvmem/imx-ocotp.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) -- 2.25.1 ^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH 1/3] nvmem: imx: correct nregs for i.MX6SLL 2023-10-13 12:49 [PATCH 0/3] nvmem: fixes for v6.6 srinivas.kandagatla @ 2023-10-13 12:49 ` srinivas.kandagatla 0 siblings, 0 replies; 15+ messages in thread From: srinivas.kandagatla @ 2023-10-13 12:49 UTC (permalink / raw) To: gregkh; +Cc: linux-kernel, Peng Fan, Stable, Srinivas Kandagatla From: Peng Fan <peng.fan@nxp.com> The nregs for i.MX6SLL should be 80 per fuse map, correct it. Fixes: 6da27821a6f5 ("nvmem: imx-ocotp: add support for imx6sll") Cc: <Stable@vger.kernel.org> Signed-off-by: Peng Fan <peng.fan@nxp.com> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> --- drivers/nvmem/imx-ocotp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/nvmem/imx-ocotp.c b/drivers/nvmem/imx-ocotp.c index a223d9537f22..7302f25b14a1 100644 --- a/drivers/nvmem/imx-ocotp.c +++ b/drivers/nvmem/imx-ocotp.c @@ -498,7 +498,7 @@ static const struct ocotp_params imx6sl_params = { }; static const struct ocotp_params imx6sll_params = { - .nregs = 128, + .nregs = 80, .bank_address_words = 0, .set_timing = imx_ocotp_set_imx6_timing, .ctrl = IMX_OCOTP_BM_CTRL_DEFAULT, -- 2.25.1 ^ permalink raw reply related [flat|nested] 15+ messages in thread
end of thread, other threads:[~2023-10-13 12:49 UTC | newest] Thread overview: 15+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2023-10-08 8:10 [PATCH 0/3] nvmem: imx: correct nregs for i.MX6UL/ULL/SLL Peng Fan (OSS) 2023-10-08 8:10 ` Peng Fan (OSS) 2023-10-08 8:10 ` [PATCH 1/3] nvmem: imx: correct nregs for i.MX6SLL Peng Fan (OSS) 2023-10-08 8:10 ` Peng Fan (OSS) 2023-10-08 13:07 ` Greg Kroah-Hartman 2023-10-08 13:07 ` Greg Kroah-Hartman 2023-10-08 8:10 ` [PATCH 2/3] nvmem: imx: correct nregs for i.MX6UL Peng Fan (OSS) 2023-10-08 8:10 ` Peng Fan (OSS) 2023-10-08 13:07 ` Greg Kroah-Hartman 2023-10-08 13:07 ` Greg Kroah-Hartman 2023-10-08 8:10 ` [PATCH 3/3] nvmem: imx: correct nregs for i.MX6ULL Peng Fan (OSS) 2023-10-08 8:10 ` Peng Fan (OSS) 2023-10-08 13:08 ` Greg Kroah-Hartman 2023-10-08 13:08 ` Greg Kroah-Hartman -- strict thread matches above, loose matches on Subject: below -- 2023-10-13 12:49 [PATCH 0/3] nvmem: fixes for v6.6 srinivas.kandagatla 2023-10-13 12:49 ` [PATCH 1/3] nvmem: imx: correct nregs for i.MX6SLL srinivas.kandagatla
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.