* [PATCH v4 0/2] arm64: dts: ti: k3-j7200: Fixes for various dtbs_checks warnings
@ 2023-10-09 8:24 ` Vaishnav Achath
0 siblings, 0 replies; 12+ messages in thread
From: Vaishnav Achath @ 2023-10-09 8:24 UTC (permalink / raw)
To: vigneshr, nm, kristo, krzysztof.kozlowski+dt, afd
Cc: devicetree, linux-arm-kernel, linux-kernel, robh+dt, u-kumar1,
vaishnav.a
Hi,
Few fixups for j7200 dtbs_check warnings.
This is V4 for the following series rebased and tested with 6.6-rc5,
V3 : https://lore.kernel.org/all/20230513101343.785-1-vaishnav.a@ti.com
V2 : https://lore.kernel.org/all/20230505115858.7391-1-vaishnav.a@ti.com/
V1 : https://lore.kernel.org/all/20230424173623.477577-1-nm@ti.com/
Bootlog with basic hyperflash testing (6.6.0-rc5-next-20231009):
https://gist.github.com/vaishnavachath/f7265e932725fd992dbc4e48b993e9c0
Patch 2/2 depends on the following patch under review which enables reg-mux
to be used when parent node is not syscon :
https://lore.kernel.org/all/20230911151030.71100-1-afd@ti.com/
Changelog:
V3->V4:
* Rebase and tested with 6.6-rc5
V2->V3:
* Drop pinctrl fix patch as the fix [2] is already merged to next.
* Keep register regions unchanged as it is correct according to memory
map, update commit message.
V1->V2:
* Address feedback as recommended in [3].
* Address feedback from Udit to limit the FSS register region size as
per TRM.
* Use reg-mux changes in [4] to simplify the hbmc-mux modelling
[1] https://lore.kernel.org/all/76da0b98-3274-b047-db11-ecabc117ae11@ti.com/
[2] https://lore.kernel.org/all/20230510091850.28881-1-tony@atomide.com/
[3] https://lore.kernel.org/all/20230503115130.c7m4a7crub7kmfjw@gluten/
[4] https://lore.kernel.org/all/20230911151030.71100-1-afd@ti.com/
Nishanth Menon (2):
arm64: dts: ti: k3-j7200-mcu-wakeup: Switch mcu_syscon to
ti,j721e-system-controller
arm64: dts: ti: k3-j7200-mcu-wakeup: Update fss node and hbmc_mux
arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 12+ messages in thread* [PATCH v4 0/2] arm64: dts: ti: k3-j7200: Fixes for various dtbs_checks warnings @ 2023-10-09 8:24 ` Vaishnav Achath 0 siblings, 0 replies; 12+ messages in thread From: Vaishnav Achath @ 2023-10-09 8:24 UTC (permalink / raw) To: vigneshr, nm, kristo, krzysztof.kozlowski+dt, afd Cc: devicetree, linux-arm-kernel, linux-kernel, robh+dt, u-kumar1, vaishnav.a Hi, Few fixups for j7200 dtbs_check warnings. This is V4 for the following series rebased and tested with 6.6-rc5, V3 : https://lore.kernel.org/all/20230513101343.785-1-vaishnav.a@ti.com V2 : https://lore.kernel.org/all/20230505115858.7391-1-vaishnav.a@ti.com/ V1 : https://lore.kernel.org/all/20230424173623.477577-1-nm@ti.com/ Bootlog with basic hyperflash testing (6.6.0-rc5-next-20231009): https://gist.github.com/vaishnavachath/f7265e932725fd992dbc4e48b993e9c0 Patch 2/2 depends on the following patch under review which enables reg-mux to be used when parent node is not syscon : https://lore.kernel.org/all/20230911151030.71100-1-afd@ti.com/ Changelog: V3->V4: * Rebase and tested with 6.6-rc5 V2->V3: * Drop pinctrl fix patch as the fix [2] is already merged to next. * Keep register regions unchanged as it is correct according to memory map, update commit message. V1->V2: * Address feedback as recommended in [3]. * Address feedback from Udit to limit the FSS register region size as per TRM. * Use reg-mux changes in [4] to simplify the hbmc-mux modelling [1] https://lore.kernel.org/all/76da0b98-3274-b047-db11-ecabc117ae11@ti.com/ [2] https://lore.kernel.org/all/20230510091850.28881-1-tony@atomide.com/ [3] https://lore.kernel.org/all/20230503115130.c7m4a7crub7kmfjw@gluten/ [4] https://lore.kernel.org/all/20230911151030.71100-1-afd@ti.com/ Nishanth Menon (2): arm64: dts: ti: k3-j7200-mcu-wakeup: Switch mcu_syscon to ti,j721e-system-controller arm64: dts: ti: k3-j7200-mcu-wakeup: Update fss node and hbmc_mux arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) -- 2.17.1 ^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH v4 1/2] arm64: dts: ti: k3-j7200-mcu-wakeup: Switch mcu_syscon to ti,j721e-system-controller 2023-10-09 8:24 ` Vaishnav Achath @ 2023-10-09 8:24 ` Vaishnav Achath -1 siblings, 0 replies; 12+ messages in thread From: Vaishnav Achath @ 2023-10-09 8:24 UTC (permalink / raw) To: vigneshr, nm, kristo, krzysztof.kozlowski+dt, afd Cc: devicetree, linux-arm-kernel, linux-kernel, robh+dt, u-kumar1, vaishnav.a From: Nishanth Menon <nm@ti.com> Use ti,j721e-system-controller to be explicit about the syscon node we are using. Signed-off-by: Nishanth Menon <nm@ti.com> Signed-off-by: Vaishnav Achath <vaishnav.a@ti.com> --- No changes since V1. arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi index 6ffaf85fa63f..2ee6215e38a6 100644 --- a/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi +++ b/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi @@ -165,7 +165,7 @@ }; mcu_conf: syscon@40f00000 { - compatible = "syscon", "simple-mfd"; + compatible = "ti,j721e-system-controller", "syscon", "simple-mfd"; reg = <0x00 0x40f00000 0x00 0x20000>; #address-cells = <1>; #size-cells = <1>; -- 2.17.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH v4 1/2] arm64: dts: ti: k3-j7200-mcu-wakeup: Switch mcu_syscon to ti,j721e-system-controller @ 2023-10-09 8:24 ` Vaishnav Achath 0 siblings, 0 replies; 12+ messages in thread From: Vaishnav Achath @ 2023-10-09 8:24 UTC (permalink / raw) To: vigneshr, nm, kristo, krzysztof.kozlowski+dt, afd Cc: devicetree, linux-arm-kernel, linux-kernel, robh+dt, u-kumar1, vaishnav.a From: Nishanth Menon <nm@ti.com> Use ti,j721e-system-controller to be explicit about the syscon node we are using. Signed-off-by: Nishanth Menon <nm@ti.com> Signed-off-by: Vaishnav Achath <vaishnav.a@ti.com> --- No changes since V1. arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi index 6ffaf85fa63f..2ee6215e38a6 100644 --- a/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi +++ b/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi @@ -165,7 +165,7 @@ }; mcu_conf: syscon@40f00000 { - compatible = "syscon", "simple-mfd"; + compatible = "ti,j721e-system-controller", "syscon", "simple-mfd"; reg = <0x00 0x40f00000 0x00 0x20000>; #address-cells = <1>; #size-cells = <1>; -- 2.17.1 ^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH v4 1/2] arm64: dts: ti: k3-j7200-mcu-wakeup: Switch mcu_syscon to ti,j721e-system-controller 2023-10-09 8:24 ` Vaishnav Achath @ 2023-10-19 19:13 ` reidt -1 siblings, 0 replies; 12+ messages in thread From: reidt @ 2023-10-19 19:13 UTC (permalink / raw) To: Vaishnav Achath Cc: vigneshr, nm, kristo, krzysztof.kozlowski+dt, afd, devicetree, linux-arm-kernel, linux-kernel, robh+dt, u-kumar1 On 13:54-20231009, Vaishnav Achath wrote: > From: Nishanth Menon <nm@ti.com> > > Use ti,j721e-system-controller to be explicit about the syscon node we > are using. > > Signed-off-by: Nishanth Menon <nm@ti.com> > Signed-off-by: Vaishnav Achath <vaishnav.a@ti.com> > --- > > No changes since V1. > > arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi > index 6ffaf85fa63f..2ee6215e38a6 100644 > --- a/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi > +++ b/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi > @@ -165,7 +165,7 @@ > }; > > mcu_conf: syscon@40f00000 { > - compatible = "syscon", "simple-mfd"; > + compatible = "ti,j721e-system-controller", "syscon", "simple-mfd"; > reg = <0x00 0x40f00000 0x00 0x20000>; > #address-cells = <1>; > #size-cells = <1>; > -- > 2.17.1 > > Reviewed-by: Reid tonking <reidt@ti.com> _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v4 1/2] arm64: dts: ti: k3-j7200-mcu-wakeup: Switch mcu_syscon to ti,j721e-system-controller @ 2023-10-19 19:13 ` reidt 0 siblings, 0 replies; 12+ messages in thread From: reidt @ 2023-10-19 19:13 UTC (permalink / raw) To: Vaishnav Achath Cc: vigneshr, nm, kristo, krzysztof.kozlowski+dt, afd, devicetree, linux-arm-kernel, linux-kernel, robh+dt, u-kumar1 On 13:54-20231009, Vaishnav Achath wrote: > From: Nishanth Menon <nm@ti.com> > > Use ti,j721e-system-controller to be explicit about the syscon node we > are using. > > Signed-off-by: Nishanth Menon <nm@ti.com> > Signed-off-by: Vaishnav Achath <vaishnav.a@ti.com> > --- > > No changes since V1. > > arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi > index 6ffaf85fa63f..2ee6215e38a6 100644 > --- a/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi > +++ b/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi > @@ -165,7 +165,7 @@ > }; > > mcu_conf: syscon@40f00000 { > - compatible = "syscon", "simple-mfd"; > + compatible = "ti,j721e-system-controller", "syscon", "simple-mfd"; > reg = <0x00 0x40f00000 0x00 0x20000>; > #address-cells = <1>; > #size-cells = <1>; > -- > 2.17.1 > > Reviewed-by: Reid tonking <reidt@ti.com> ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v4 1/2] arm64: dts: ti: k3-j7200-mcu-wakeup: Switch mcu_syscon to ti,j721e-system-controller 2023-10-09 8:24 ` Vaishnav Achath @ 2023-10-19 21:05 ` Andrew Davis -1 siblings, 0 replies; 12+ messages in thread From: Andrew Davis @ 2023-10-19 21:05 UTC (permalink / raw) To: Vaishnav Achath, vigneshr, nm, kristo, krzysztof.kozlowski+dt Cc: devicetree, linux-arm-kernel, linux-kernel, robh+dt, u-kumar1 On 10/9/23 3:24 AM, Vaishnav Achath wrote: > From: Nishanth Menon <nm@ti.com> > > Use ti,j721e-system-controller to be explicit about the syscon node we > are using. > > Signed-off-by: Nishanth Menon <nm@ti.com> > Signed-off-by: Vaishnav Achath <vaishnav.a@ti.com> > --- > > No changes since V1. > > arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi > index 6ffaf85fa63f..2ee6215e38a6 100644 > --- a/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi > +++ b/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi > @@ -165,7 +165,7 @@ > }; > > mcu_conf: syscon@40f00000 { > - compatible = "syscon", "simple-mfd"; > + compatible = "ti,j721e-system-controller", "syscon", "simple-mfd"; There is already a "ti,j721e-system-controller" in the main domain dtsi. And this is not one of those. You are hiding a valid DT warning by adding an incorrect compatible string that just so happens to not throw the warning. This should be a "simple-bus" node. Andrew > reg = <0x00 0x40f00000 0x00 0x20000>; > #address-cells = <1>; > #size-cells = <1>; _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v4 1/2] arm64: dts: ti: k3-j7200-mcu-wakeup: Switch mcu_syscon to ti,j721e-system-controller @ 2023-10-19 21:05 ` Andrew Davis 0 siblings, 0 replies; 12+ messages in thread From: Andrew Davis @ 2023-10-19 21:05 UTC (permalink / raw) To: Vaishnav Achath, vigneshr, nm, kristo, krzysztof.kozlowski+dt Cc: devicetree, linux-arm-kernel, linux-kernel, robh+dt, u-kumar1 On 10/9/23 3:24 AM, Vaishnav Achath wrote: > From: Nishanth Menon <nm@ti.com> > > Use ti,j721e-system-controller to be explicit about the syscon node we > are using. > > Signed-off-by: Nishanth Menon <nm@ti.com> > Signed-off-by: Vaishnav Achath <vaishnav.a@ti.com> > --- > > No changes since V1. > > arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi > index 6ffaf85fa63f..2ee6215e38a6 100644 > --- a/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi > +++ b/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi > @@ -165,7 +165,7 @@ > }; > > mcu_conf: syscon@40f00000 { > - compatible = "syscon", "simple-mfd"; > + compatible = "ti,j721e-system-controller", "syscon", "simple-mfd"; There is already a "ti,j721e-system-controller" in the main domain dtsi. And this is not one of those. You are hiding a valid DT warning by adding an incorrect compatible string that just so happens to not throw the warning. This should be a "simple-bus" node. Andrew > reg = <0x00 0x40f00000 0x00 0x20000>; > #address-cells = <1>; > #size-cells = <1>; ^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH v4 2/2] arm64: dts: ti: k3-j7200-mcu-wakeup: Update fss node and hbmc_mux 2023-10-09 8:24 ` Vaishnav Achath @ 2023-10-09 8:24 ` Vaishnav Achath -1 siblings, 0 replies; 12+ messages in thread From: Vaishnav Achath @ 2023-10-09 8:24 UTC (permalink / raw) To: vigneshr, nm, kristo, krzysztof.kozlowski+dt, afd Cc: devicetree, linux-arm-kernel, linux-kernel, robh+dt, u-kumar1, vaishnav.a From: Nishanth Menon <nm@ti.com> FSS node claims to be a syscon node, while it actually is a simple bus where OSPI, HBMC peripherals are located and a mux for path select between OSPI and Hyperbus which can be modelled as a reg-mux. So model it accordingly and use reg-mux to describe the hbmc_mux. Signed-off-by: Nishanth Menon <nm@ti.com> Signed-off-by: Vaishnav Achath <vaishnav.a@ti.com> --- V2->V3: * Keep register regions unchanged as it is correct according to memory map. * Update commit messages as per Vignesh's suggestion. V1->V2: * Address feedback from Udit to limit the FSS register region size as per TRM. * Use reg-mux changes to simplify the hbmc-mux modelling. * Update commit message to reflect changes. Depends on: https://lore.kernel.org/all/20230911151030.71100-1-afd@ti.com/ arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi index 2ee6215e38a6..4f98ea685d33 100644 --- a/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi +++ b/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi @@ -507,15 +507,16 @@ status = "disabled"; }; - fss: syscon@47000000 { - compatible = "syscon", "simple-mfd"; + fss: bus@47000000 { + compatible = "simple-bus"; reg = <0x00 0x47000000 0x00 0x100>; #address-cells = <2>; #size-cells = <2>; ranges; - hbmc_mux: hbmc-mux { - compatible = "mmio-mux"; + hbmc_mux: mux-controller@47000004 { + compatible = "reg-mux"; + reg = <0x00 0x47000004 0x00 0x2>; #mux-control-cells = <1>; mux-reg-masks = <0x4 0x2>; /* HBMC select */ }; -- 2.17.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH v4 2/2] arm64: dts: ti: k3-j7200-mcu-wakeup: Update fss node and hbmc_mux @ 2023-10-09 8:24 ` Vaishnav Achath 0 siblings, 0 replies; 12+ messages in thread From: Vaishnav Achath @ 2023-10-09 8:24 UTC (permalink / raw) To: vigneshr, nm, kristo, krzysztof.kozlowski+dt, afd Cc: devicetree, linux-arm-kernel, linux-kernel, robh+dt, u-kumar1, vaishnav.a From: Nishanth Menon <nm@ti.com> FSS node claims to be a syscon node, while it actually is a simple bus where OSPI, HBMC peripherals are located and a mux for path select between OSPI and Hyperbus which can be modelled as a reg-mux. So model it accordingly and use reg-mux to describe the hbmc_mux. Signed-off-by: Nishanth Menon <nm@ti.com> Signed-off-by: Vaishnav Achath <vaishnav.a@ti.com> --- V2->V3: * Keep register regions unchanged as it is correct according to memory map. * Update commit messages as per Vignesh's suggestion. V1->V2: * Address feedback from Udit to limit the FSS register region size as per TRM. * Use reg-mux changes to simplify the hbmc-mux modelling. * Update commit message to reflect changes. Depends on: https://lore.kernel.org/all/20230911151030.71100-1-afd@ti.com/ arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi index 2ee6215e38a6..4f98ea685d33 100644 --- a/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi +++ b/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi @@ -507,15 +507,16 @@ status = "disabled"; }; - fss: syscon@47000000 { - compatible = "syscon", "simple-mfd"; + fss: bus@47000000 { + compatible = "simple-bus"; reg = <0x00 0x47000000 0x00 0x100>; #address-cells = <2>; #size-cells = <2>; ranges; - hbmc_mux: hbmc-mux { - compatible = "mmio-mux"; + hbmc_mux: mux-controller@47000004 { + compatible = "reg-mux"; + reg = <0x00 0x47000004 0x00 0x2>; #mux-control-cells = <1>; mux-reg-masks = <0x4 0x2>; /* HBMC select */ }; -- 2.17.1 ^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH v4 2/2] arm64: dts: ti: k3-j7200-mcu-wakeup: Update fss node and hbmc_mux 2023-10-09 8:24 ` Vaishnav Achath @ 2023-10-19 19:15 ` reidt -1 siblings, 0 replies; 12+ messages in thread From: reidt @ 2023-10-19 19:15 UTC (permalink / raw) To: Vaishnav Achath Cc: vigneshr, nm, kristo, krzysztof.kozlowski+dt, afd, devicetree, linux-arm-kernel, linux-kernel, robh+dt, u-kumar1 On 13:54-20231009, Vaishnav Achath wrote: > From: Nishanth Menon <nm@ti.com> > > FSS node claims to be a syscon node, while it actually is a simple bus > where OSPI, HBMC peripherals are located and a mux for path select > between OSPI and Hyperbus which can be modelled as a reg-mux. So model > it accordingly and use reg-mux to describe the hbmc_mux. > > Signed-off-by: Nishanth Menon <nm@ti.com> > Signed-off-by: Vaishnav Achath <vaishnav.a@ti.com> > --- > > V2->V3: > * Keep register regions unchanged as it is correct according to memory > map. > * Update commit messages as per Vignesh's suggestion. > > V1->V2: > * Address feedback from Udit to limit the FSS register region size as > per TRM. > * Use reg-mux changes to simplify the hbmc-mux modelling. > * Update commit message to reflect changes. > > Depends on: > https://lore.kernel.org/all/20230911151030.71100-1-afd@ti.com/ > > arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi > index 2ee6215e38a6..4f98ea685d33 100644 > --- a/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi > +++ b/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi > @@ -507,15 +507,16 @@ > status = "disabled"; > }; > > - fss: syscon@47000000 { > - compatible = "syscon", "simple-mfd"; > + fss: bus@47000000 { > + compatible = "simple-bus"; > reg = <0x00 0x47000000 0x00 0x100>; > #address-cells = <2>; > #size-cells = <2>; > ranges; > > - hbmc_mux: hbmc-mux { > - compatible = "mmio-mux"; > + hbmc_mux: mux-controller@47000004 { > + compatible = "reg-mux"; > + reg = <0x00 0x47000004 0x00 0x2>; > #mux-control-cells = <1>; > mux-reg-masks = <0x4 0x2>; /* HBMC select */ > }; > -- > 2.17.1 > > Reviewed-by: Reid Tonking <reidt@ti.com> _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v4 2/2] arm64: dts: ti: k3-j7200-mcu-wakeup: Update fss node and hbmc_mux @ 2023-10-19 19:15 ` reidt 0 siblings, 0 replies; 12+ messages in thread From: reidt @ 2023-10-19 19:15 UTC (permalink / raw) To: Vaishnav Achath Cc: vigneshr, nm, kristo, krzysztof.kozlowski+dt, afd, devicetree, linux-arm-kernel, linux-kernel, robh+dt, u-kumar1 On 13:54-20231009, Vaishnav Achath wrote: > From: Nishanth Menon <nm@ti.com> > > FSS node claims to be a syscon node, while it actually is a simple bus > where OSPI, HBMC peripherals are located and a mux for path select > between OSPI and Hyperbus which can be modelled as a reg-mux. So model > it accordingly and use reg-mux to describe the hbmc_mux. > > Signed-off-by: Nishanth Menon <nm@ti.com> > Signed-off-by: Vaishnav Achath <vaishnav.a@ti.com> > --- > > V2->V3: > * Keep register regions unchanged as it is correct according to memory > map. > * Update commit messages as per Vignesh's suggestion. > > V1->V2: > * Address feedback from Udit to limit the FSS register region size as > per TRM. > * Use reg-mux changes to simplify the hbmc-mux modelling. > * Update commit message to reflect changes. > > Depends on: > https://lore.kernel.org/all/20230911151030.71100-1-afd@ti.com/ > > arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi > index 2ee6215e38a6..4f98ea685d33 100644 > --- a/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi > +++ b/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi > @@ -507,15 +507,16 @@ > status = "disabled"; > }; > > - fss: syscon@47000000 { > - compatible = "syscon", "simple-mfd"; > + fss: bus@47000000 { > + compatible = "simple-bus"; > reg = <0x00 0x47000000 0x00 0x100>; > #address-cells = <2>; > #size-cells = <2>; > ranges; > > - hbmc_mux: hbmc-mux { > - compatible = "mmio-mux"; > + hbmc_mux: mux-controller@47000004 { > + compatible = "reg-mux"; > + reg = <0x00 0x47000004 0x00 0x2>; > #mux-control-cells = <1>; > mux-reg-masks = <0x4 0x2>; /* HBMC select */ > }; > -- > 2.17.1 > > Reviewed-by: Reid Tonking <reidt@ti.com> ^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2023-10-19 21:05 UTC | newest] Thread overview: 12+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2023-10-09 8:24 [PATCH v4 0/2] arm64: dts: ti: k3-j7200: Fixes for various dtbs_checks warnings Vaishnav Achath 2023-10-09 8:24 ` Vaishnav Achath 2023-10-09 8:24 ` [PATCH v4 1/2] arm64: dts: ti: k3-j7200-mcu-wakeup: Switch mcu_syscon to ti,j721e-system-controller Vaishnav Achath 2023-10-09 8:24 ` Vaishnav Achath 2023-10-19 19:13 ` reidt 2023-10-19 19:13 ` reidt 2023-10-19 21:05 ` Andrew Davis 2023-10-19 21:05 ` Andrew Davis 2023-10-09 8:24 ` [PATCH v4 2/2] arm64: dts: ti: k3-j7200-mcu-wakeup: Update fss node and hbmc_mux Vaishnav Achath 2023-10-09 8:24 ` Vaishnav Achath 2023-10-19 19:15 ` reidt 2023-10-19 19:15 ` reidt
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.