All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Christoph Hellwig <hch@lst.de>,
	iommu@lists.linux.dev, Robin Murphy <robin.murphy@arm.com>,
	Marek Szyprowski <m.szyprowski@samsung.com>,
	Wei Fang <wei.fang@nxp.com>, Shenwei Wang <shenwei.wang@nxp.com>,
	Clark Wang <xiaoning.wang@nxp.com>,
	NXP Linux Team <linux-imx@nxp.com>,
	linux-m68k@lists.linux-m68k.org, netdev@vger.kernel.org,
	Jim Quinlan <james.quinlan@broadcom.com>,
	linux-riscv <linux-riscv@lists.infradead.org>,
	Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
	"Lad, Prabhakar" <prabhakar.mahadev-lad.rj@bp.renesas.com>
Subject: Re: [PATCH 1/6] dma-direct: add depdenencies to CONFIG_DMA_GLOBAL_POOL
Date: Mon, 9 Oct 2023 11:43:30 +0200	[thread overview]
Message-ID: <20231009094330.GA24836@lst.de> (raw)
In-Reply-To: <CAMuHMdUZNewD-QC8J7MWSBP197Vc169meOjjK6=b7M11kVjUzg@mail.gmail.com>

On Mon, Oct 09, 2023 at 11:34:55AM +0200, Geert Uytterhoeven wrote:
> The fix you are referring too is probably commit c1ec4b450ab729e3
> ("soc: renesas: Make ARCH_R9A07G043 (riscv version) depend
> on NONPORTABLE") in next-20231006 and later.  It is not yet upstream.
> 
> Still, it merely makes ARCH_R9A07G043 (which selects DMA_GLOBAL_POOL)
> depend on ARCH_R9A07G043.
> RISCV_DMA_NONCOHERENT still selects DMA_DIRECT_REMAP, so both can end
> up being enabled.

Ok, so we need to actually fix this properly.  Lad, can you respin
the fix to not select DMA_DIRECT_REMAP, for ARCH_R9A07G043?


WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Christoph Hellwig <hch@lst.de>,
	iommu@lists.linux.dev, Robin Murphy <robin.murphy@arm.com>,
	Marek Szyprowski <m.szyprowski@samsung.com>,
	Wei Fang <wei.fang@nxp.com>, Shenwei Wang <shenwei.wang@nxp.com>,
	Clark Wang <xiaoning.wang@nxp.com>,
	NXP Linux Team <linux-imx@nxp.com>,
	linux-m68k@lists.linux-m68k.org, netdev@vger.kernel.org,
	Jim Quinlan <james.quinlan@broadcom.com>,
	linux-riscv <linux-riscv@lists.infradead.org>,
	Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
	"Lad, Prabhakar" <prabhakar.mahadev-lad.rj@bp.renesas.com>
Subject: Re: [PATCH 1/6] dma-direct: add depdenencies to CONFIG_DMA_GLOBAL_POOL
Date: Mon, 9 Oct 2023 11:43:30 +0200	[thread overview]
Message-ID: <20231009094330.GA24836@lst.de> (raw)
In-Reply-To: <CAMuHMdUZNewD-QC8J7MWSBP197Vc169meOjjK6=b7M11kVjUzg@mail.gmail.com>

On Mon, Oct 09, 2023 at 11:34:55AM +0200, Geert Uytterhoeven wrote:
> The fix you are referring too is probably commit c1ec4b450ab729e3
> ("soc: renesas: Make ARCH_R9A07G043 (riscv version) depend
> on NONPORTABLE") in next-20231006 and later.  It is not yet upstream.
> 
> Still, it merely makes ARCH_R9A07G043 (which selects DMA_GLOBAL_POOL)
> depend on ARCH_R9A07G043.
> RISCV_DMA_NONCOHERENT still selects DMA_DIRECT_REMAP, so both can end
> up being enabled.

Ok, so we need to actually fix this properly.  Lad, can you respin
the fix to not select DMA_DIRECT_REMAP, for ARCH_R9A07G043?


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

  reply	other threads:[~2023-10-09  9:43 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-09  7:41 fix the non-coherent coldfire dma_alloc_coherent Christoph Hellwig
2023-10-09  7:41 ` [PATCH 1/6] dma-direct: add depdenencies to CONFIG_DMA_GLOBAL_POOL Christoph Hellwig
2023-10-09  8:43   ` Geert Uytterhoeven
2023-10-09  8:43     ` Geert Uytterhoeven
2023-10-09  9:16     ` Christoph Hellwig
2023-10-09  9:16       ` Christoph Hellwig
2023-10-09  9:34       ` Geert Uytterhoeven
2023-10-09  9:34         ` Geert Uytterhoeven
2023-10-09  9:43         ` Christoph Hellwig [this message]
2023-10-09  9:43           ` Christoph Hellwig
2023-10-09  9:51           ` Geert Uytterhoeven
2023-10-09  9:51             ` Geert Uytterhoeven
2023-10-09 10:04             ` Robin Murphy
2023-10-09 10:04               ` Robin Murphy
2023-10-09 11:10               ` Geert Uytterhoeven
2023-10-09 11:10                 ` Geert Uytterhoeven
2023-10-09 12:48                 ` Christoph Hellwig
2023-10-09 12:48                   ` Christoph Hellwig
2023-10-09 16:45                   ` Robin Murphy
2023-10-09 16:45                     ` Robin Murphy
2023-10-09  7:41 ` [PATCH 2/6] dma-direct: add a CONFIG_ARCH_DMA_ALLOC symbol Christoph Hellwig
2023-10-09  7:41 ` [PATCH 3/6] dma-direct: simplify the use atomic pool logic in dma_direct_alloc Christoph Hellwig
2023-10-09  7:41 ` [PATCH 4/6] dma-direct: warn when coherent allocations aren't supported Christoph Hellwig
2023-10-09  7:41 ` [PATCH 5/6] net: fec: use dma_alloc_noncoherent for m532x Christoph Hellwig
2023-10-09 10:29   ` Robin Murphy
2023-10-09 12:58     ` Christoph Hellwig
2023-10-10 14:44       ` Greg Ungerer
2023-10-16  9:12         ` Geert Uytterhoeven
2023-10-17  8:31           ` Geert Uytterhoeven
2023-10-10 14:20     ` Greg Ungerer
2023-10-11  5:52       ` Christoph Hellwig
2023-10-11 13:09         ` Greg Ungerer
2023-10-11 18:21           ` Michael Schmitz
2023-10-12 13:25             ` Greg Ungerer
2023-10-12 14:00               ` Christoph Hellwig
2023-10-13  1:48                 ` Greg Ungerer
2023-10-12 19:18               ` Michael Schmitz
2023-10-09  7:41 ` [PATCH 6/6] m68k: don't provide arch_dma_alloc for nommu/coldfire Christoph Hellwig
2023-10-09  8:39 ` fix the non-coherent coldfire dma_alloc_coherent Geert Uytterhoeven
2023-10-09  9:15   ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231009094330.GA24836@lst.de \
    --to=hch@lst.de \
    --cc=geert@linux-m68k.org \
    --cc=iommu@lists.linux.dev \
    --cc=james.quinlan@broadcom.com \
    --cc=linux-imx@nxp.com \
    --cc=linux-m68k@lists.linux-m68k.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=m.szyprowski@samsung.com \
    --cc=netdev@vger.kernel.org \
    --cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
    --cc=robin.murphy@arm.com \
    --cc=shenwei.wang@nxp.com \
    --cc=wei.fang@nxp.com \
    --cc=xiaoning.wang@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.