From: Shawn Guo <shawnguo@kernel.org>
To: Hao Ge <gehao@kylinos.cn>
Cc: s.hauer@pengutronix.de, kernel@pengutronix.de,
festevam@gmail.com, linux-imx@nxp.com,
christophe.jaillet@wanadoo.fr, robh@kernel.org,
treding@nvidia.com, daniel.baluta@nxp.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, gehao618@163.com
Subject: Re: [PATCH] firmware/imx-dsp: Fix use_after_free in imx_dsp_setup_channels()
Date: Tue, 10 Oct 2023 10:33:08 +0800 [thread overview]
Message-ID: <20231010023308.GM819755@dragon> (raw)
In-Reply-To: <20231008032908.11448-1-gehao@kylinos.cn>
On Sun, Oct 08, 2023 at 11:29:08AM +0800, Hao Ge wrote:
> dsp_chan->name and chan_name points to same block of memory,
> because dev_err still needs to be used it,so we need free
> it's memory after use to avoid use_after_free.
>
> Fixes: e527adfb9b7d ("firmware: imx-dsp: Fix an error handling path in imx_dsp_setup_channels()")
> Signed-off-by: Hao Ge <gehao@kylinos.cn>
Applied, thanks!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo@kernel.org>
To: Hao Ge <gehao@kylinos.cn>
Cc: s.hauer@pengutronix.de, kernel@pengutronix.de,
festevam@gmail.com, linux-imx@nxp.com,
christophe.jaillet@wanadoo.fr, robh@kernel.org,
treding@nvidia.com, daniel.baluta@nxp.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, gehao618@163.com
Subject: Re: [PATCH] firmware/imx-dsp: Fix use_after_free in imx_dsp_setup_channels()
Date: Tue, 10 Oct 2023 10:33:08 +0800 [thread overview]
Message-ID: <20231010023308.GM819755@dragon> (raw)
In-Reply-To: <20231008032908.11448-1-gehao@kylinos.cn>
On Sun, Oct 08, 2023 at 11:29:08AM +0800, Hao Ge wrote:
> dsp_chan->name and chan_name points to same block of memory,
> because dev_err still needs to be used it,so we need free
> it's memory after use to avoid use_after_free.
>
> Fixes: e527adfb9b7d ("firmware: imx-dsp: Fix an error handling path in imx_dsp_setup_channels()")
> Signed-off-by: Hao Ge <gehao@kylinos.cn>
Applied, thanks!
next prev parent reply other threads:[~2023-10-10 2:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-08 3:29 [PATCH] firmware/imx-dsp: Fix use_after_free in imx_dsp_setup_channels() Hao Ge
2023-10-08 3:29 ` Hao Ge
2023-10-09 11:07 ` Daniel Baluta
2023-10-09 11:07 ` Daniel Baluta
2023-10-10 2:33 ` Shawn Guo [this message]
2023-10-10 2:33 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231010023308.GM819755@dragon \
--to=shawnguo@kernel.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=daniel.baluta@nxp.com \
--cc=festevam@gmail.com \
--cc=gehao618@163.com \
--cc=gehao@kylinos.cn \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.