[freescale-fslc:pr/642 538/30000] drivers/video/fbdev/mxc/mxc_edid.c:190:5: warning: no previous declaration for 'mxc_edid_fb_mode_is_equal'

[freescale-fslc:pr/642 538/30000] drivers/video/fbdev/mxc/mxc_edid.c:190:5: warning: no previous declaration for 'mxc_edid_fb_mode_is_equal'

[kernel test robot]

tree:   https://github.com/Freescale/linux-fslc pr/642
head:   c8b7cf62c7fea8456dec789d550b8006d73b8f04
commit: bf9855d59aee1df9ce038a24159c9e8f986be3bf [538/30000] video: fbdev: mxc: add Northwest Logic DSI driver support
config: x86_64-randconfig-001-20231013 (https://download.01.org/0day-ci/archive/20231013/202310131312.osGRkFgO-lkp@intel.com/config)
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231013/202310131312.osGRkFgO-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202310131312.osGRkFgO-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/video/fbdev/mxc/mxc_edid.c:190:5: warning: no previous declaration for 'mxc_edid_fb_mode_is_equal' [-Wmissing-declarations]
    int mxc_edid_fb_mode_is_equal(bool use_aspect,
        ^~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/video/fbdev/mxc/mxc_edid.c: In function 'get_detailed_timing':
   drivers/video/fbdev/mxc/mxc_edid.c:257:34: warning: suggest braces around empty body in an 'if' statement [-Wempty-body]
      DPRINTK("Aspect ratio: 16:9\n");
                                     ^
   drivers/video/fbdev/mxc/mxc_edid.c:259:33: warning: suggest braces around empty body in an 'if' statement [-Wempty-body]
      DPRINTK("Aspect ratio: 4:3\n");
                                    ^


vim +/mxc_edid_fb_mode_is_equal +190 drivers/video/fbdev/mxc/mxc_edid.c

   184	
   185	/*
   186	 * We have a special version of fb_mode_is_equal that ignores
   187	 * pixclock, since for many CEA modes, 2 frequencies are supported
   188	 * e.g. 640x480 @ 60Hz or 59.94Hz
   189	 */
 > 190	int mxc_edid_fb_mode_is_equal(bool use_aspect,
   191				const struct fb_videomode *mode1,
   192				const struct fb_videomode *mode2)
   193	{
   194		u32 mask;
   195	
   196		if (use_aspect)
   197			mask = ~0;
   198		else
   199			mask = ~FB_VMODE_ASPECT_MASK;
   200	
   201		return (mode1->xres         == mode2->xres &&
   202			mode1->yres         == mode2->yres &&
   203			mode1->hsync_len    == mode2->hsync_len &&
   204			mode1->vsync_len    == mode2->vsync_len &&
   205			mode1->left_margin  == mode2->left_margin &&
   206			mode1->right_margin == mode2->right_margin &&
   207			mode1->upper_margin == mode2->upper_margin &&
   208			mode1->lower_margin == mode2->lower_margin &&
   209			mode1->sync         == mode2->sync &&
   210			/* refresh check, 59.94Hz and 60Hz have the same parameter
   211			 * in struct of mxc_cea_mode */
   212			abs(mode1->refresh - mode2->refresh) <= 1 &&
   213			(mode1->vmode & mask) == (mode2->vmode & mask));
   214	}
   215	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki