* [asahilinux:pr/208 1/1] drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c:7455 brcmf_get_bwcap() warn: ignoring unreachable code.
@ 2023-10-13 22:41 kernel test robot
0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2023-10-13 22:41 UTC (permalink / raw)
To: oe-kbuild; +Cc: lkp, Dan Carpenter
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
TO: Daniel Berlin <dberlin@dberlin.org>
tree: https://github.com/AsahiLinux/linux pr/208
head: f82c1849a64ad37b55d74b1cc4681e819c068b93
commit: f82c1849a64ad37b55d74b1cc4681e819c068b93 [1/1] Fix invalid frequency issues and issues with HE supporting/only AP's
:::::: branch date: 5 days ago
:::::: commit date: 5 days ago
config: x86_64-randconfig-161-20231013 (https://download.01.org/0day-ci/archive/20231014/202310140627.FEmReRFq-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce: (https://download.01.org/0day-ci/archive/20231014/202310140627.FEmReRFq-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202310140627.FEmReRFq-lkp@intel.com/
New smatch warnings:
drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c:7455 brcmf_get_bwcap() warn: ignoring unreachable code.
Old smatch warnings:
drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c:3982 brcmf_get_netinfo_array() error: uninitialized symbol 'netinfo'.
drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c:4006 brcmf_get_netinfo_v3_array() error: uninitialized symbol 'netinfo'.
drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c:5369 brcmf_cfg80211_start_ap() warn: inconsistent indenting
vim +7455 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
aa70b4fa43dfe5 drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c Arend van Spriel 2014-07-12 7439
f82c1849a64ad3 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Daniel Berlin 2023-10-08 7440 static void brcmf_get_bwcap(struct brcmf_if *ifp, u32 bw_cap[], bool has_6g)
2375d9701bb2f5 drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c Arend van Spriel 2014-01-06 7441 {
16e64676839633 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Rafał Miłecki 2019-02-15 7442 struct brcmf_pub *drvr = ifp->drvr;
2375d9701bb2f5 drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c Arend van Spriel 2014-01-06 7443 u32 band, mimo_bwcap;
2375d9701bb2f5 drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c Arend van Spriel 2014-01-06 7444 int err;
2375d9701bb2f5 drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c Arend van Spriel 2014-01-06 7445
2375d9701bb2f5 drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c Arend van Spriel 2014-01-06 7446 band = WLC_BAND_2G;
2375d9701bb2f5 drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c Arend van Spriel 2014-01-06 7447 err = brcmf_fil_iovar_int_get(ifp, "bw_cap", &band);
2375d9701bb2f5 drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c Arend van Spriel 2014-01-06 7448 if (!err) {
57fbcce37be7c1 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Johannes Berg 2016-04-12 7449 bw_cap[NL80211_BAND_2GHZ] = band;
2375d9701bb2f5 drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c Arend van Spriel 2014-01-06 7450 band = WLC_BAND_5G;
2375d9701bb2f5 drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c Arend van Spriel 2014-01-06 7451 err = brcmf_fil_iovar_int_get(ifp, "bw_cap", &band);
2375d9701bb2f5 drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c Arend van Spriel 2014-01-06 7452 if (!err) {
57fbcce37be7c1 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Johannes Berg 2016-04-12 7453 bw_cap[NL80211_BAND_5GHZ] = band;
2375d9701bb2f5 drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c Arend van Spriel 2014-01-06 7454 return;
f82c1849a64ad3 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Daniel Berlin 2023-10-08 @7455 if (!has_6g)
f82c1849a64ad3 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Daniel Berlin 2023-10-08 7456 return;
f82c1849a64ad3 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Daniel Berlin 2023-10-08 7457 band = WLC_BAND_6G;
f82c1849a64ad3 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Daniel Berlin 2023-10-08 7458 err = brcmf_fil_iovar_int_get(ifp, "bw_cap", &band);
f82c1849a64ad3 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Daniel Berlin 2023-10-08 7459 if (!err) {
f82c1849a64ad3 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Daniel Berlin 2023-10-08 7460 bw_cap[NL80211_BAND_6GHZ] = band;
f82c1849a64ad3 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Daniel Berlin 2023-10-08 7461 return;
2375d9701bb2f5 drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c Arend van Spriel 2014-01-06 7462 }
f82c1849a64ad3 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Daniel Berlin 2023-10-08 7463 return;
f82c1849a64ad3 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Daniel Berlin 2023-10-08 7464 }
f82c1849a64ad3 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Daniel Berlin 2023-10-08 7465
2375d9701bb2f5 drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c Arend van Spriel 2014-01-06 7466 WARN_ON(1);
2375d9701bb2f5 drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c Arend van Spriel 2014-01-06 7467 return;
2375d9701bb2f5 drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c Arend van Spriel 2014-01-06 7468 }
f82c1849a64ad3 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Daniel Berlin 2023-10-08 7469
2375d9701bb2f5 drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c Arend van Spriel 2014-01-06 7470 brcmf_dbg(INFO, "fallback to mimo_bw_cap info\n");
2375d9701bb2f5 drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c Arend van Spriel 2014-01-06 7471 mimo_bwcap = 0;
2375d9701bb2f5 drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c Arend van Spriel 2014-01-06 7472 err = brcmf_fil_iovar_int_get(ifp, "mimo_bw_cap", &mimo_bwcap);
2375d9701bb2f5 drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c Arend van Spriel 2014-01-06 7473 if (err)
2375d9701bb2f5 drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c Arend van Spriel 2014-01-06 7474 /* assume 20MHz if firmware does not give a clue */
2375d9701bb2f5 drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c Arend van Spriel 2014-01-06 7475 mimo_bwcap = WLC_N_BW_20ALL;
2375d9701bb2f5 drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c Arend van Spriel 2014-01-06 7476
2375d9701bb2f5 drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c Arend van Spriel 2014-01-06 7477 switch (mimo_bwcap) {
2375d9701bb2f5 drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c Arend van Spriel 2014-01-06 7478 case WLC_N_BW_40ALL:
57fbcce37be7c1 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Johannes Berg 2016-04-12 7479 bw_cap[NL80211_BAND_2GHZ] |= WLC_BW_40MHZ_BIT;
0bde10dc553d27 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Gustavo A. R. Silva 2020-08-21 7480 fallthrough;
2375d9701bb2f5 drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c Arend van Spriel 2014-01-06 7481 case WLC_N_BW_20IN2G_40IN5G:
57fbcce37be7c1 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Johannes Berg 2016-04-12 7482 bw_cap[NL80211_BAND_5GHZ] |= WLC_BW_40MHZ_BIT;
0bde10dc553d27 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Gustavo A. R. Silva 2020-08-21 7483 fallthrough;
2375d9701bb2f5 drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c Arend van Spriel 2014-01-06 7484 case WLC_N_BW_20ALL:
57fbcce37be7c1 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Johannes Berg 2016-04-12 7485 bw_cap[NL80211_BAND_2GHZ] |= WLC_BW_20MHZ_BIT;
57fbcce37be7c1 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Johannes Berg 2016-04-12 7486 bw_cap[NL80211_BAND_5GHZ] |= WLC_BW_20MHZ_BIT;
2375d9701bb2f5 drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c Arend van Spriel 2014-01-06 7487 break;
2375d9701bb2f5 drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c Arend van Spriel 2014-01-06 7488 default:
16e64676839633 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Rafał Miłecki 2019-02-15 7489 bphy_err(drvr, "invalid mimo_bw_cap value\n");
2375d9701bb2f5 drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c Arend van Spriel 2014-01-06 7490 }
2375d9701bb2f5 drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c Arend van Spriel 2014-01-06 7491 }
d48200ba45dd2e drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c Hante Meuleman 2013-04-03 7492
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 2+ messages in thread
* [asahilinux:pr/208 1/1] drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c:7455 brcmf_get_bwcap() warn: ignoring unreachable code.
@ 2023-10-16 4:49 Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2023-10-16 4:49 UTC (permalink / raw)
To: oe-kbuild, Daniel Berlin; +Cc: lkp, oe-kbuild-all
tree: https://github.com/AsahiLinux/linux pr/208
head: f82c1849a64ad37b55d74b1cc4681e819c068b93
commit: f82c1849a64ad37b55d74b1cc4681e819c068b93 [1/1] Fix invalid frequency issues and issues with HE supporting/only AP's
config: x86_64-randconfig-161-20231013 (https://download.01.org/0day-ci/archive/20231014/202310140627.FEmReRFq-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce: (https://download.01.org/0day-ci/archive/20231014/202310140627.FEmReRFq-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
| Closes: https://lore.kernel.org/r/202310140627.FEmReRFq-lkp@intel.com/
New smatch warnings:
drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c:7455 brcmf_get_bwcap() warn: ignoring unreachable code.
vim +7455 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
f82c1849a64ad3 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Daniel Berlin 2023-10-08 7440 static void brcmf_get_bwcap(struct brcmf_if *ifp, u32 bw_cap[], bool has_6g)
2375d9701bb2f5 drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c Arend van Spriel 2014-01-06 7441 {
16e64676839633 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Rafał Miłecki 2019-02-15 7442 struct brcmf_pub *drvr = ifp->drvr;
2375d9701bb2f5 drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c Arend van Spriel 2014-01-06 7443 u32 band, mimo_bwcap;
2375d9701bb2f5 drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c Arend van Spriel 2014-01-06 7444 int err;
2375d9701bb2f5 drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c Arend van Spriel 2014-01-06 7445
2375d9701bb2f5 drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c Arend van Spriel 2014-01-06 7446 band = WLC_BAND_2G;
2375d9701bb2f5 drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c Arend van Spriel 2014-01-06 7447 err = brcmf_fil_iovar_int_get(ifp, "bw_cap", &band);
2375d9701bb2f5 drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c Arend van Spriel 2014-01-06 7448 if (!err) {
57fbcce37be7c1 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Johannes Berg 2016-04-12 7449 bw_cap[NL80211_BAND_2GHZ] = band;
2375d9701bb2f5 drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c Arend van Spriel 2014-01-06 7450 band = WLC_BAND_5G;
2375d9701bb2f5 drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c Arend van Spriel 2014-01-06 7451 err = brcmf_fil_iovar_int_get(ifp, "bw_cap", &band);
2375d9701bb2f5 drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c Arend van Spriel 2014-01-06 7452 if (!err) {
57fbcce37be7c1 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Johannes Berg 2016-04-12 7453 bw_cap[NL80211_BAND_5GHZ] = band;
2375d9701bb2f5 drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c Arend van Spriel 2014-01-06 7454 return;
^^^^^^^
Ancient return statement
f82c1849a64ad3 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Daniel Berlin 2023-10-08 @7455 if (!has_6g)
Unreachable new code
f82c1849a64ad3 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Daniel Berlin 2023-10-08 7456 return;
f82c1849a64ad3 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Daniel Berlin 2023-10-08 7457 band = WLC_BAND_6G;
f82c1849a64ad3 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Daniel Berlin 2023-10-08 7458 err = brcmf_fil_iovar_int_get(ifp, "bw_cap", &band);
f82c1849a64ad3 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Daniel Berlin 2023-10-08 7459 if (!err) {
f82c1849a64ad3 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Daniel Berlin 2023-10-08 7460 bw_cap[NL80211_BAND_6GHZ] = band;
f82c1849a64ad3 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Daniel Berlin 2023-10-08 7461 return;
2375d9701bb2f5 drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c Arend van Spriel 2014-01-06 7462 }
f82c1849a64ad3 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Daniel Berlin 2023-10-08 7463 return;
f82c1849a64ad3 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Daniel Berlin 2023-10-08 7464 }
f82c1849a64ad3 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c Daniel Berlin 2023-10-08 7465
2375d9701bb2f5 drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c Arend van Spriel 2014-01-06 7466 WARN_ON(1);
2375d9701bb2f5 drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c Arend van Spriel 2014-01-06 7467 return;
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-10-16 4:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-13 22:41 [asahilinux:pr/208 1/1] drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c:7455 brcmf_get_bwcap() warn: ignoring unreachable code kernel test robot
-- strict thread matches above, loose matches on Subject: below --
2023-10-16 4:49 Dan Carpenter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.