* Need advice on planning patches for staging/vme_user
@ 2023-10-16 1:41 Soumya Negi
0 siblings, 0 replies; only message in thread
From: Soumya Negi @ 2023-10-16 1:41 UTC (permalink / raw)
To: Greg Kroah-Hartman, Martyn Welch, Manohar Vanga; +Cc: outreachy
Hi,
There are printk's in the staging driver vme_user(all in 1 file) which triggers
checkpatch warnings all over. To replace printk() with appropriate logging
mechanisms(a mix of dev_err/warn & pr_err/warn), if I go by a patch for each
function that calls printk, the patchset will be too big(~33 patches).
Or, if I split up patches this way: printk() to pr_*() &
printk() to dev_*(), there would be fewer patches(atleast 4) but perhaps
it will be harder to review? (There are ~78 call sites)
What would be a good way to structure the patchset?
Plus there are some other changes, like using __func__ instead of func
name in printk error messages, that can be done. Is it okay to make this
change in the error string while replacing the printk() or does it need to be
in a separate patch( after the printk's are replaced)?
Thanks,
Soumya
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2023-10-16 1:41 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-16 1:41 Need advice on planning patches for staging/vme_user Soumya Negi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.