All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Ahmed Zaki <ahmed.zaki@intel.com>
Cc: mkubecek@suse.cz, andrew@lunn.ch,
	Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
	Wojciech Drewek <wojciech.drewek@intel.com>,
	corbet@lwn.net, netdev@vger.kernel.org,
	linux-doc@vger.kernel.org, jesse.brandeburg@intel.com,
	edumazet@google.com, anthony.l.nguyen@intel.com,
	horms@kernel.org, vladimir.oltean@nxp.com,
	intel-wired-lan@lists.osuosl.org, pabeni@redhat.com,
	davem@davemloft.net
Subject: Re: [Intel-wired-lan] [PATCH net-next v3 1/6] net: ethtool: allow symmetric-xor RSS hash for any flow type
Date: Mon, 16 Oct 2023 08:02:02 -0700	[thread overview]
Message-ID: <20231016080202.0d755ef3@kernel.org> (raw)
In-Reply-To: <cf6c824a-be09-4b6c-b2a2-fb870e9f0c37@intel.com>

On Sat, 14 Oct 2023 06:19:54 -0600 Ahmed Zaki wrote:
> >> +#define        RXH_SYMMETRIC_XOR       (1 << 30)
> >> +#define        RXH_DISCARD             (1 << 31)
> >>
> >> Are these indentation changes intentional?
> >>
> >>
> >> Yes, for alignment ("RXH_SYMMETRIC_XOR" is too long).  
> > 
> > I think it's preferable to not touch other lines. Among others, that
> > messes up git blame. But it's subjective. Follow your preference if no
> > one else chimes in.  
> 
> Jakub,
> 
> Sorry for late reply, I was off for few days.
> 
> I'd like to keep this version, I don't see any other comments that needs 
> to be addressed. Can you accept this or need a v4/rebase ?

I think you should add a comment above the define explaining what
"symmetric-xor" is. Is this correct?

/* XOR corresponding source and destination fields, both copies 
 * of the XOR'ed fields are fed into the RSS and RXHASH calculation.
 */
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan

WARNING: multiple messages have this Message-ID (diff)
From: Jakub Kicinski <kuba@kernel.org>
To: Ahmed Zaki <ahmed.zaki@intel.com>
Cc: <netdev@vger.kernel.org>, <intel-wired-lan@lists.osuosl.org>,
	<corbet@lwn.net>, <jesse.brandeburg@intel.com>,
	<anthony.l.nguyen@intel.com>, <davem@davemloft.net>,
	<edumazet@google.com>, <pabeni@redhat.com>,
	<vladimir.oltean@nxp.com>, <andrew@lunn.ch>, <horms@kernel.org>,
	<mkubecek@suse.cz>, <linux-doc@vger.kernel.org>,
	Wojciech Drewek <wojciech.drewek@intel.com>,
	Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Subject: Re: [PATCH net-next v3 1/6] net: ethtool: allow symmetric-xor RSS hash for any flow type
Date: Mon, 16 Oct 2023 08:02:02 -0700	[thread overview]
Message-ID: <20231016080202.0d755ef3@kernel.org> (raw)
In-Reply-To: <cf6c824a-be09-4b6c-b2a2-fb870e9f0c37@intel.com>

On Sat, 14 Oct 2023 06:19:54 -0600 Ahmed Zaki wrote:
> >> +#define        RXH_SYMMETRIC_XOR       (1 << 30)
> >> +#define        RXH_DISCARD             (1 << 31)
> >>
> >> Are these indentation changes intentional?
> >>
> >>
> >> Yes, for alignment ("RXH_SYMMETRIC_XOR" is too long).  
> > 
> > I think it's preferable to not touch other lines. Among others, that
> > messes up git blame. But it's subjective. Follow your preference if no
> > one else chimes in.  
> 
> Jakub,
> 
> Sorry for late reply, I was off for few days.
> 
> I'd like to keep this version, I don't see any other comments that needs 
> to be addressed. Can you accept this or need a v4/rebase ?

I think you should add a comment above the define explaining what
"symmetric-xor" is. Is this correct?

/* XOR corresponding source and destination fields, both copies 
 * of the XOR'ed fields are fed into the RSS and RXHASH calculation.
 */

  reply	other threads:[~2023-10-16 15:02 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-10 20:04 [Intel-wired-lan] [PATCH net-next v3 0/6] Support symmetric RSS (Toeplitz) hash Ahmed Zaki
2023-10-10 20:04 ` Ahmed Zaki
2023-10-10 20:04 ` [Intel-wired-lan] [PATCH net-next v3 1/6] net: ethtool: allow symmetric-xor RSS hash for any flow type Ahmed Zaki
2023-10-10 20:04   ` Ahmed Zaki
2023-10-10 20:40   ` [Intel-wired-lan] " Willem de Bruijn
2023-10-10 20:40     ` Willem de Bruijn
2023-10-10 21:34     ` [Intel-wired-lan] " Ahmed Zaki
2023-10-11 22:45       ` Willem de Bruijn
2023-10-11 22:45         ` Willem de Bruijn
2023-10-14 12:19         ` [Intel-wired-lan] " Ahmed Zaki
2023-10-14 12:19           ` Ahmed Zaki
2023-10-16 15:02           ` Jakub Kicinski [this message]
2023-10-16 15:02             ` Jakub Kicinski
2023-10-16 15:27             ` [Intel-wired-lan] " Ahmed Zaki
2023-10-16 15:27               ` Ahmed Zaki
2023-10-11 14:49     ` Ahmed Zaki
2023-10-11 14:49       ` Ahmed Zaki
2023-10-10 20:04 ` [Intel-wired-lan] [PATCH net-next v3 2/6] ice: fix ICE_AQ_VSI_Q_OPT_RSS_* register values Ahmed Zaki
2023-10-10 20:04   ` Ahmed Zaki
2023-10-10 20:04 ` [Intel-wired-lan] [PATCH net-next v3 3/6] ice: refactor RSS configuration Ahmed Zaki
2023-10-10 20:04   ` Ahmed Zaki
2023-10-10 20:04 ` [Intel-wired-lan] [PATCH net-next v3 4/6] ice: refactor the FD and RSS flow ID generation Ahmed Zaki
2023-10-10 20:04   ` Ahmed Zaki
2023-10-10 20:04 ` [Intel-wired-lan] [PATCH net-next v3 5/6] ice: enable symmetric RSS Toeplitz hash for any flow type Ahmed Zaki
2023-10-10 20:04   ` Ahmed Zaki
2023-10-10 20:04 ` [Intel-wired-lan] [PATCH net-next v3 6/6] iavf: enable symmetric RSS Toeplitz hash Ahmed Zaki
2023-10-10 20:04   ` Ahmed Zaki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231016080202.0d755ef3@kernel.org \
    --to=kuba@kernel.org \
    --cc=ahmed.zaki@intel.com \
    --cc=andrew@lunn.ch \
    --cc=anthony.l.nguyen@intel.com \
    --cc=corbet@lwn.net \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=jesse.brandeburg@intel.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=mkubecek@suse.cz \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=vladimir.oltean@nxp.com \
    --cc=willemdebruijn.kernel@gmail.com \
    --cc=wojciech.drewek@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.