All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Horman <horms@kernel.org>
To: Takeru Hayasaka <hayatake396@gmail.com>
Cc: intel-wired-lan@lists.osuosl.org,
	Jesse Brandeburg <jesse.brandeburg@intel.com>,
	linux-kernel@vger.kernel.org, Eric Dumazet <edumazet@google.com>,
	Tony Nguyen <anthony.l.nguyen@intel.com>,
	netdev@vger.kernel.org, Jakub Kicinski <kuba@kernel.org>,
	Paolo Abeni <pabeni@redhat.com>,
	"David S. Miller" <davem@davemloft.net>
Subject: Re: [Intel-wired-lan] [PATCH net-next v2] ethtool: ice: Support for RSS settings to GTP from ethtool
Date: Mon, 16 Oct 2023 11:27:00 +0200	[thread overview]
Message-ID: <20231016092700.GH1501712@kernel.org> (raw)
In-Reply-To: <20231012060115.107183-1-hayatake396@gmail.com>

On Thu, Oct 12, 2023 at 06:01:15AM +0000, Takeru Hayasaka wrote:
> This is a patch that enables RSS functionality for GTP packets using
> ethtool.
> A user can include her TEID and make RSS work for GTP-U over IPv4 by
> doing the following:
> `ethtool -N ens3 rx-flow-hash gtpu4 sde`
> In addition to gtpu(4|6), we now support gtpc(4|6),gtpc(4|6)t,gtpu(4|6)e,
> gtpu(4|6)u, and gtpu(4|6)d.
> 
> GTP generates a flow that includes an ID called TEID to identify the
> tunnel. This tunnel is created for each UE (User Equipment).
> By performing RSS based on this flow, it is possible to apply RSS for
> each communication unit from the UE.
> Without this, RSS would only be effective within the range of IP
> addresses.
> For instance, the PGW can only perform RSS within the IP range of the
> SGW.
> problematic from a load distribution perspective, especially if there's
> a bias in the terminals connected to a particular base station.
> This case can be solved by using this patch
> 
> Signed-off-by: Takeru Hayasaka <hayatake396@gmail.com>
> ---
> Added commit messages and options based on reviews

Thanks Hayasaka-san,

Overall this looks good to me. And I see that the review of v1
has been addressed - by adding information about the need for
this to the commit message.

Reviewed-by: Simon Horman <horms@kernel.org>
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan

WARNING: multiple messages have this Message-ID (diff)
From: Simon Horman <horms@kernel.org>
To: Takeru Hayasaka <hayatake396@gmail.com>
Cc: Jesse Brandeburg <jesse.brandeburg@intel.com>,
	Tony Nguyen <anthony.l.nguyen@intel.com>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2] ethtool: ice: Support for RSS settings to GTP from ethtool
Date: Mon, 16 Oct 2023 11:27:00 +0200	[thread overview]
Message-ID: <20231016092700.GH1501712@kernel.org> (raw)
In-Reply-To: <20231012060115.107183-1-hayatake396@gmail.com>

On Thu, Oct 12, 2023 at 06:01:15AM +0000, Takeru Hayasaka wrote:
> This is a patch that enables RSS functionality for GTP packets using
> ethtool.
> A user can include her TEID and make RSS work for GTP-U over IPv4 by
> doing the following:
> `ethtool -N ens3 rx-flow-hash gtpu4 sde`
> In addition to gtpu(4|6), we now support gtpc(4|6),gtpc(4|6)t,gtpu(4|6)e,
> gtpu(4|6)u, and gtpu(4|6)d.
> 
> GTP generates a flow that includes an ID called TEID to identify the
> tunnel. This tunnel is created for each UE (User Equipment).
> By performing RSS based on this flow, it is possible to apply RSS for
> each communication unit from the UE.
> Without this, RSS would only be effective within the range of IP
> addresses.
> For instance, the PGW can only perform RSS within the IP range of the
> SGW.
> problematic from a load distribution perspective, especially if there's
> a bias in the terminals connected to a particular base station.
> This case can be solved by using this patch
> 
> Signed-off-by: Takeru Hayasaka <hayatake396@gmail.com>
> ---
> Added commit messages and options based on reviews

Thanks Hayasaka-san,

Overall this looks good to me. And I see that the review of v1
has been addressed - by adding information about the need for
this to the commit message.

Reviewed-by: Simon Horman <horms@kernel.org>

  reply	other threads:[~2023-10-16  9:27 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-12  6:01 [Intel-wired-lan] [PATCH net-next v2] ethtool: ice: Support for RSS settings to GTP from ethtool Takeru Hayasaka
2023-10-12  6:01 ` Takeru Hayasaka
2023-10-16  9:27 ` Simon Horman [this message]
2023-10-16  9:27   ` Simon Horman
2023-10-16 22:23 ` [Intel-wired-lan] " Jakub Kicinski
2023-10-16 22:23   ` Jakub Kicinski
2023-10-17  6:11   ` [Intel-wired-lan] " Harald Welte
2023-10-17  6:11     ` Harald Welte
2023-10-17  6:44     ` [Intel-wired-lan] " Harald Welte
2023-10-17  6:44       ` Harald Welte
2023-10-17 14:18   ` [Intel-wired-lan] " takeru hayasaka
2023-10-17 14:18     ` takeru hayasaka
2023-10-17 14:37     ` [Intel-wired-lan] " takeru hayasaka
2023-10-17 14:37       ` takeru hayasaka
2023-10-17 16:49       ` [Intel-wired-lan] " takeru hayasaka
2023-10-17 16:49         ` takeru hayasaka
2023-10-18  8:25         ` [Intel-wired-lan] " Harald Welte
2023-10-18  8:25           ` Harald Welte
2023-10-18 16:20           ` [Intel-wired-lan] " takeru hayasaka
2023-10-18 16:20             ` takeru hayasaka
2023-10-17 23:49       ` [Intel-wired-lan] " Jakub Kicinski
2023-10-17 23:49         ` Jakub Kicinski
2023-10-18  1:53         ` [Intel-wired-lan] " takeru hayasaka
2023-10-18  1:53           ` takeru hayasaka
2023-10-18  8:12           ` [Intel-wired-lan] " Harald Welte
2023-10-18  8:12             ` Harald Welte
2023-10-18 17:40             ` [Intel-wired-lan] " Jakub Kicinski
2023-10-18 17:40               ` Jakub Kicinski
2023-10-18 17:37           ` [Intel-wired-lan] " Jakub Kicinski
2023-10-18 17:37             ` Jakub Kicinski
2023-10-18 17:57             ` [Intel-wired-lan] " Harald Welte
2023-10-18 17:57               ` Harald Welte

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231016092700.GH1501712@kernel.org \
    --to=horms@kernel.org \
    --cc=anthony.l.nguyen@intel.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=hayatake396@gmail.com \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=jesse.brandeburg@intel.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.