From: Juan Quintela <quintela@redhat.com>
To: qemu-devel@nongnu.org
Cc: Peter Xu <peterx@redhat.com>, Leonardo Bras <leobras@redhat.com>,
Juan Quintela <quintela@redhat.com>,
Fabiano Rosas <farosas@suse.de>,
Lukas Straub <lukasstraub2@web.de>
Subject: [PULL 06/11] migration: Simplify decompress_data_with_multi_threads()
Date: Wed, 18 Oct 2023 12:06:46 +0200 [thread overview]
Message-ID: <20231018100651.32674-7-quintela@redhat.com> (raw)
In-Reply-To: <20231018100651.32674-1-quintela@redhat.com>
Doing a break to do another break is just confused. Just call return
when we know we want to return.
Signed-off-by: Juan Quintela <quintela@redhat.com>
Reviewed-by: Lukas Straub <lukasstraub2@web.de>
Message-ID: <20230613145757.10131-14-quintela@redhat.com>
---
migration/ram-compress.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/migration/ram-compress.c b/migration/ram-compress.c
index 3ad5975d48..95a8d6b906 100644
--- a/migration/ram-compress.c
+++ b/migration/ram-compress.c
@@ -481,14 +481,10 @@ void decompress_data_with_multi_threads(QEMUFile *f, void *host, int len)
decomp_param[idx].len = len;
qemu_cond_signal(&decomp_param[idx].cond);
qemu_mutex_unlock(&decomp_param[idx].mutex);
- break;
+ return;
}
}
- if (idx < thread_count) {
- break;
- } else {
- qemu_cond_wait(&decomp_done_cond, &decomp_done_lock);
- }
+ qemu_cond_wait(&decomp_done_cond, &decomp_done_lock);
}
}
--
2.41.0
next prev parent reply other threads:[~2023-10-18 10:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-18 10:06 [PULL 00/11] Migration 20231018 patches Juan Quintela
2023-10-18 10:06 ` [PULL 01/11] migration: RDMA is not compatible with anything else Juan Quintela
2023-10-18 10:06 ` [PULL 02/11] migration: Move compression_counters cleanup ram-compress.c Juan Quintela
2023-10-18 10:06 ` [PULL 03/11] migration: Create populate_compress() Juan Quintela
2023-10-18 10:06 ` [PULL 04/11] migration: Create ram_compressed_pages() Juan Quintela
2023-10-18 10:06 ` [PULL 05/11] migration: Move update_compress_threads_counts() to ram-compress.c Juan Quintela
2023-10-18 10:06 ` Juan Quintela [this message]
2023-10-18 10:06 ` [PULL 07/11] migration: Use "i" as an for index in ram-compress.c Juan Quintela
2023-10-18 10:06 ` [PULL 08/11] migration: Print block status when needed Juan Quintela
2023-10-18 10:06 ` [PULL 09/11] migration: save_compress_page() can take block through pss Juan Quintela
2023-10-18 10:06 ` [PULL 10/11] migration: control_save_page() " Juan Quintela
2023-10-18 10:06 ` [PULL 11/11] migration: save_zero_page() " Juan Quintela
2023-10-19 18:51 ` [PULL 00/11] Migration 20231018 patches Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231018100651.32674-7-quintela@redhat.com \
--to=quintela@redhat.com \
--cc=farosas@suse.de \
--cc=leobras@redhat.com \
--cc=lukasstraub2@web.de \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.